Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-30 Thread Dimitry Andric
On 2011-12-30 14:28, David Chisnall wrote: On 30 Dec 2011, at 13:06, Dimitry Andric wrote: sys/gnu/fs/xfs/xfs_dir2_block.c:1149:17: warning: array index of '1' indexes past the end of an array (that contains 1 element) [-Warray-bounds] I recall some discussion of this warning on the clang

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-30 Thread David Chisnall
On 30 Dec 2011, at 13:06, Dimitry Andric wrote: > sys/gnu/fs/xfs/xfs_dir2_block.c:1149:17: warning: array index of '1' indexes > past the end of an array (that contains 1 element) [-Warray-bounds] I recall some discussion of this warning on the clang list a few months ago, and I believe that i

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-30 Thread Chuck Burns
On 12/30/2011 7:06 AM, Dimitry Andric wrote: On 2011-12-26 11:10, Alexander Best wrote: that's why i'd like to propose the following patch. i ran a full tinderbox run against r228878 and it suceeded. Did you also try this with clang? For example the xfs module alone gets a whole slew of warnin

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-30 Thread Dimitry Andric
On 2011-12-26 11:10, Alexander Best wrote: that's why i'd like to propose the following patch. i ran a full tinderbox run against r228878 and it suceeded. Did you also try this with clang? For example the xfs module alone gets a whole slew of warnings, which would be fatal if WERROR= was remov

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-29 Thread Ed Schouten
* Philip Paeps , 20111227 02:04: > Wouldn't it be better to set WARNS=x rather than WERROR=? Not entirely related to the discussion, but worth mentioning: WARNS is only used by -- not . -- Ed Schouten WWW: http://80386.nl/ pgpmcXP0kSzD8.pgp Description: PGP signature

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-27 Thread Dimitry Andric
On 2011-12-27 02:04, Philip Paeps wrote: On 2011-12-26 10:10:40 (+), Alexander Best wrote: i grep'ed through src/sys and found several places where WERROR= was set in order to get rid of the default -Werror setting. i tried to remove those WERROR= overrides from any Makefile, where doing so

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-27 Thread Alexander Best
On Tue Dec 27 11, Warner Losh wrote: > > On Dec 26, 2011, at 6:04 PM, Philip Paeps wrote: > > > On 2011-12-26 10:10:40 (+), Alexander Best wrote: > >> i grep'ed through src/sys and found several places where WERROR= was set in > >> order to get rid of the default -Werror setting. i tried to

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-27 Thread Warner Losh
On Dec 26, 2011, at 6:04 PM, Philip Paeps wrote: > On 2011-12-26 10:10:40 (+), Alexander Best wrote: >> i grep'ed through src/sys and found several places where WERROR= was set in >> order to get rid of the default -Werror setting. i tried to remove those >> WERROR= overrides from any Makefi

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-27 Thread Alexander Best
On Tue Dec 27 11, Luigi Rizzo wrote: > On Tue, Dec 27, 2011 at 11:27:43AM +, Alexander Best wrote: > > On Tue Dec 27 11, Philip Paeps wrote: > > > On 2011-12-26 10:10:40 (+), Alexander Best > > > wrote: > > > > i grep'ed through src/sys and found several places where WERROR= was > > > >

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-27 Thread Luigi Rizzo
On Tue, Dec 27, 2011 at 11:27:43AM +, Alexander Best wrote: > On Tue Dec 27 11, Philip Paeps wrote: > > On 2011-12-26 10:10:40 (+), Alexander Best wrote: > > > i grep'ed through src/sys and found several places where WERROR= was set > > > in > > > order to get rid of the default -Werror s

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-27 Thread Alexander Best
On Tue Dec 27 11, Philip Paeps wrote: > On 2011-12-26 10:10:40 (+), Alexander Best wrote: > > i grep'ed through src/sys and found several places where WERROR= was set in > > order to get rid of the default -Werror setting. i tried to remove those > > WERROR= overrides from any Makefile, where

Re: [rfc] removing/conditionalising WERROR= in Makefiles

2011-12-27 Thread Philip Paeps
On 2011-12-26 10:10:40 (+), Alexander Best wrote: > i grep'ed through src/sys and found several places where WERROR= was set in > order to get rid of the default -Werror setting. i tried to remove those > WERROR= overrides from any Makefile, where doing so did not break tinderbox. > > in thos