> > However, I'm not sure why we are changing the output. It seems
> > gratiutious.
>
> I cannot find "gratiutious" in my dictionary... But changing output is
> not necessary, I'll keep it as original.
It's spelled "gratuitous".
Terry Lambert
> > > @@ -138,9 +138,9 @@
> > > usage(msg)
> > > char *msg;
> > > {
> > > - warnx("enabler: %s", msg);
> > > + fprintf(stderr, "enabler: %s\n", msg);
> > > fprintf(stderr,
> > > -"usage: pccardc enabler slot driver [-m addr size] [-a iobase] [-i
> > > irq]\n");
> > > +"Usag
Nate Williams wrote:
> > @@ -138,9 +138,9 @@
> > usage(msg)
> > char *msg;
> > {
> > - warnx("enabler: %s", msg);
> > + fprintf(stderr, "enabler: %s\n", msg);
> > fprintf(stderr,
> > -"usage: pccardc enabler slot driver [-m addr size] [-a iobase] [-i
> > irq]\n");
> > +"Usa
fprintf(stderr,
-"usage: pccardc enabler slot driver [-m addr size] [-a iobase] [-i irq]\n");
+"Usage: enabler slot driver [-m addr size] [-a iobase] [-i irq]\n");
Usage string use to start with "usage", not "Usage". Progname should
follow.
- fprintf(stderr, "usage: pccardc ...\n
> This is a patch for better (I think) error handling for pccardc.
> (obtained from PAO3)
>
> Please review.
Some of it I like, and others I don't.
> @@ -138,9 +138,9 @@
> usage(msg)
> char *msg;
> {
> - warnx("enabler: %s", msg);
> + fprintf(stderr, "enabler: %s\n", msg);
>
This is a patch for better (I think) error handling for pccardc.
(obtained from PAO3)
Please review.
--
Jun Kuriyama // kuriy...@sky.rim.or.jp
// kuriy...@freebsd.orgIndex: pccardc/dumpcis.c
===
RCS file: /home/ncvs/src
