Re: Clang warning patches

2013-01-15 Thread hiren panchasara
On Tue, Jan 15, 2013 at 3:22 PM, John-Mark Gurney wrote: > John-Mark Gurney wrote this message on Tue, Jan 15, 2013 at 15:10 -0800: >> hiren panchasara wrote this message on Tue, Jan 15, 2013 at 07:52 -0800: >> > http://www.strugglingcoder.info/patches/clang_warnings_dev_bktr.txt >> >> This patch

Re: Clang warning patches

2013-01-15 Thread John-Mark Gurney
John-Mark Gurney wrote this message on Tue, Jan 15, 2013 at 15:10 -0800: > hiren panchasara wrote this message on Tue, Jan 15, 2013 at 07:52 -0800: > > http://www.strugglingcoder.info/patches/clang_warnings_dev_bktr.txt > > This patch does not look correct at all... It is simply removing code.. >

Re: Clang warning patches

2013-01-15 Thread John-Mark Gurney
hiren panchasara wrote this message on Tue, Jan 15, 2013 at 07:52 -0800: > http://www.strugglingcoder.info/patches/clang_warnings_dev_bktr.txt This patch does not look correct at all... It is simply removing code.. How is is good that after we failed to set the tv_freq that we continue on? What