Re: [patch] pam_exec: use program exit code instead of PAM_SYSTEM_ERR

2012-02-08 Thread Jean-Sébastien Pédron
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/26/2012 11:07, Gleb Kurtsou wrote: > Please consider making it optional. It will break for generic > applications because pam_sm_chauthtok error codes are documented > and standardized. I'm not aware of any application that uses PAM > error con

Re: [patch] pam_exec: use program exit code instead of PAM_SYSTEM_ERR

2012-01-27 Thread Jean-Sébastien Pédron
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26.01.2012 11:07, Gleb Kurtsou wrote: > On (24/01/2012 15:25), Jean-Sébastien Pédron wrote: >> Attached is a patch that changes the behaviour to always return >> the program exit code as-is. > > Please consider making it optional. It will break fo

Re: [patch] pam_exec: use program exit code instead of PAM_SYSTEM_ERR

2012-01-26 Thread Gleb Kurtsou
On (24/01/2012 15:25), Jean-S?bastien P?dron wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > If the specified program exits with non-zero, current implementation > of pam_exec(8) logs this code and return PAM_SYSTEM_ERR. Therefore, > applications have no idea what went wrong

[patch] pam_exec: use program exit code instead of PAM_SYSTEM_ERR

2012-01-24 Thread Jean-Sébastien Pédron
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, If the specified program exits with non-zero, current implementation of pam_exec(8) logs this code and return PAM_SYSTEM_ERR. Therefore, applications have no idea what went wrong with authentication. Attached is a patch that changes the behaviour