Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-29 Thread George Neville-Neil
On Jun 26, 2012, at 15:06 , Fabian Keil wrote: > Pedro Giffuni wrote: > >> --- Mar 26/6/12, Mark Peek ha scritto: > >>> Try this, change the assert on line 1429 in file dt_cc.c >>> from: >>> >>> assert(!(arg & (UINT16_MAX << args[i].shift))); >>> >>> to >>> >>> assert(!(arg & ((uint64_t)UI

Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-26 Thread Pedro Giffuni
--- Mar 26/6/12, Fabian Keil ha scritto: > Pedro Giffuni wrote: > > > --- Mar 26/6/12, Mark Peek > ha scritto: > > > > Try this, change the assert on line 1429 in file > dt_cc.c > > > from: > > > > > > assert(!(arg & (UINT16_MAX << > args[i].shift))); > > > > > > to > > > > > > assert(!(

Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-26 Thread Fabian Keil
Pedro Giffuni wrote: > --- Mar 26/6/12, Mark Peek ha scritto: > > Try this, change the assert on line 1429 in file dt_cc.c > > from: > > > > assert(!(arg & (UINT16_MAX << args[i].shift))); > > > > to > > > > assert(!(arg & ((uint64_t)UINT16_MAX << > > args[i].shift))); > > > > This certain

Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-26 Thread Pedro Giffuni
--- Mar 26/6/12, Mark Peek ha scritto: > > > > It's a different assertion. > > > > Probably some difference between Solaris and BSD. > > this is very useful, thanks! > > Try this, change the assert on line 1429 in file dt_cc.c > from: > > assert(!(arg & (UINT16_MAX << args[i].shift))); > > t

Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-26 Thread Mark Peek
On 6/23/12 11:09 AM, Pedro Giffuni wrote: --- Sab 23/6/12, Fabian Keil ha scritto: ... My suggestion would be to instead try using the test scripts in cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize/ err.D_LLQUANT_FACTORSMALL.d (for example) has @ = llquantize(0, 1, 0, 10,

Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-23 Thread Pedro Giffuni
--- Sab 23/6/12, Fabian Keil ha scritto: ... > > My suggestion would be to instead try using the test > > scripts in > > > cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize/ > > > > err.D_LLQUANT_FACTORSMALL.d (for example) has > > > > @ = llquantize(0, 1, 0, 10, 10); > > The pro

Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-23 Thread Fabian Keil
Pedro Giffuni wrote: > Hello Fabian; > > --- Sab 23/6/12, Fabian Keil ha scritto: > > > Pedro Giffuni wrote: > > > > > I am not a Dtrace user (yet) but I started to port the > > Log/linear > > > quantizations from Illumos: > > > > > > http://dtrace.org/blogs/bmc/2011/02/08/llquantize/ > > >

Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-23 Thread Pedro Giffuni
Hello Fabian; --- Sab 23/6/12, Fabian Keil ha scritto: > Pedro Giffuni wrote: > > > I am not a Dtrace user (yet) but I started to port the > Log/linear > > quantizations from Illumos: > > > > http://dtrace.org/blogs/bmc/2011/02/08/llquantize/ > > > > Apparently this patch should do it: > > >

Re: [RFT] llquantize for FreeBSD's dtrace

2012-06-23 Thread Fabian Keil
Pedro Giffuni wrote: > I am not a Dtrace user (yet) but I started to port the Log/linear > quantizations from Illumos: > > http://dtrace.org/blogs/bmc/2011/02/08/llquantize/ > > Apparently this patch should do it: > > http://people.freebsd.org/~pfg/patches/patch-llquantize-complete > > Unfort

[RFT] llquantize for FreeBSD's dtrace

2012-06-22 Thread Pedro Giffuni
Hello; I am not a Dtrace user (yet) but I started to port the Log/linear quantizations from Illumos: http://dtrace.org/blogs/bmc/2011/02/08/llquantize/ Apparently this patch should do it: http://people.freebsd.org/~pfg/patches/patch-llquantize-complete Unfortunately when I tried to build curr