On Tue, Jul 02, 2013 at 10:30:53PM +0200, Ed Schouten wrote:
> 2013/7/2 Steve Kargl :
> > Could someone (this could even be me, but need approval) please
> > fix nvmecontrol?
>
> off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?
> Also, the call of malloc(sb.st_size) is not rea
On Tue, Jul 02, 2013 at 10:37:35PM +0200, Dimitry Andric wrote:
> On Jul 2, 2013, at 22:30, Ed Schouten wrote:
> > 2013/7/2 Steve Kargl :
> >> Could someone (this could even be me, but need approval) please
> >> fix nvmecontrol?
> >
> > off_t doesn't need to be intmax_t, right? Maybe add an expli
On Jul 2, 2013, at 22:30, Ed Schouten wrote:
> 2013/7/2 Steve Kargl :
>> Could someone (this could even be me, but need approval) please
>> fix nvmecontrol?
>
> off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?
Yes, that is what Bruce has suggested for off_t many times in the
2013/7/2 Steve Kargl :
> Could someone (this could even be me, but need approval) please
> fix nvmecontrol?
off_t doesn't need to be intmax_t, right? Maybe add an explicit cast?
Also, the call of malloc(sb.st_size) is not really safe...
--
Ed Schouten
___
Could someone (this could even be me, but need approval) please
fix nvmecontrol?
Index: nvmecontrol/firmware.c
===
--- nvmecontrol/firmware.c (revision 252514)
+++ nvmecontrol/firmware.c (working copy)
@@ -82,7 +82,7 @@ read
