Re: [PATCH] mtree should not output size if the file is not a regular file

2013-09-22 Thread Brooks Davis
On Tue, Sep 10, 2013 at 08:00:02AM +0200, Matthias Andree wrote: > Am 10.09.2013 01:51, schrieb Christos Zoulas: > > On Sep 10, 1:21am, d...@des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) > > wrote: > > -- Subject: Re: [PATCH] mtree should not output size if the file is not a > > reg > > > > | R

Re: [PATCH] mtree should not output size if the file is not a regular file

2013-09-09 Thread Matthias Andree
Am 10.09.2013 01:51, schrieb Christos Zoulas: > On Sep 10, 1:21am, d...@des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) wrote: > -- Subject: Re: [PATCH] mtree should not output size if the file is not a reg > > | Roll a large tarball (e.g. a complete FreeBSD installation). Copy it to > | different

Re: [PATCH] mtree should not output size if the file is not a regular file

2013-09-09 Thread Tim Kientzle
On Sep 9, 2013, at 4:51 PM, Christos Zoulas wrote: > On Sep 10, 1:21am, d...@des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) wrote: > -- Subject: Re: [PATCH] mtree should not output size if the file is not a reg > > | Roll a large tarball (e.g. a complete FreeBSD installation). Copy it to > | d

Re: [PATCH] mtree should not output size if the file is not a regular file

2013-09-09 Thread Christos Zoulas
On Sep 10, 1:21am, d...@des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) wrote: -- Subject: Re: [PATCH] mtree should not output size if the file is not a reg | Roll a large tarball (e.g. a complete FreeBSD installation). Copy it to | different machines with different filesystems. Untar and run mtr

Re: [PATCH] mtree should not output size if the file is not a regular file

2013-09-09 Thread Dag-Erling Smørgrav
Christos Zoulas writes: > Xin Li writes: > > I think it doesn't make sense to emit size information for non-regular > > files like directories, symlinks, etc. although both our and NetBSD's > > mtree would emit it. > We could change that, but what's the harm? Roll a large tarball (e.g. a complet

Re: [PATCH] mtree should not output size if the file is not a regular file

2013-09-09 Thread Christos Zoulas
On Sep 9, 2:35pm, delp...@delphij.net (Xin Li) wrote: -- Subject: [PATCH] mtree should not output size if the file is not a regular | Hi, | | I think it doesn't make sense to emit size information for non-regular | files like directories, symlinks, etc. although both our and NetBSD's | mtree wou

Re: [PATCH] mtree should not output size if the file is not a regular file

2013-09-09 Thread Dag-Erling Smørgrav
Xin Li writes: > I think it doesn't make sense to emit size information for non-regular > files like directories, symlinks, etc. although both our and NetBSD's > mtree would emit it. I agree. The size of a directory will vary from filesystem to filesystem, while the size of a symlink is simply t

[PATCH] mtree should not output size if the file is not a regular file

2013-09-09 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I think it doesn't make sense to emit size information for non-regular files like directories, symlinks, etc. although both our and NetBSD's mtree would emit it. Comments? Index: usr.sbin/mtree/create.c