Re: [PATCH] Fix NKPT kernel config option

2011-09-02 Thread Robert Millan
2011/9/2 John Baldwin : > A more useful test would be to alter pmap.h so it says: > > #ifndef NKPT > #define NKPT doesnt_compile > #endif Uhm fair enough, thanks for the explanation John. -- Robert Millan ___ freebsd-current@freebsd.org mailing list ht

Re: [PATCH] Fix NKPT kernel config option

2011-09-02 Thread John Baldwin
On Friday, September 02, 2011 1:23:16 am Robert Millan wrote: > 2011/9/1 John Baldwin : > > In general we force the relevant C files to use opt_*.h includes and avoid > > nested includes of those in headers. > > With this approach I can't trust that this feature will do the right > thing. I would

Re: [PATCH] Fix NKPT kernel config option

2011-09-02 Thread Robert Millan
2011/9/1 John Baldwin : > In general we force the relevant C files to use opt_*.h includes and avoid > nested includes of those in headers. With this approach I can't trust that this feature will do the right thing. I would rather modify pmap.h by hand than run the unnecessary risk. > Do you kno

Re: [PATCH] Fix NKPT kernel config option

2011-09-01 Thread John Baldwin
On Thursday, September 01, 2011 3:46:43 pm Robert Millan wrote: > Hi John, > > Thanks for adding an NKPT kernel config option (r225194), but this > doesn't seem to work unless opt_pmap.h is included, see attached > patch. > > Without this include, there's no garantee that the NKPT definition code

[PATCH] Fix NKPT kernel config option

2011-09-01 Thread Robert Millan
Hi John, Thanks for adding an NKPT kernel config option (r225194), but this doesn't seem to work unless opt_pmap.h is included, see attached patch. Without this include, there's no garantee that the NKPT definition code: #ifndef NKPT #define NKPT32 #endif will use the value specifie