Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-27 Thread Robert Millan
Hi Bruce, 2011/11/27 Bruce Evans : > % Index: sys/cam/scsi/scsi_low.h > % === > % --- sys/cam/scsi/scsi_low.h   (revision 227956) > % +++ sys/cam/scsi/scsi_low.h   (working copy) > % @@ -53,10 +53,10 @@ > %  #define      SCSI_LOW_INTE

Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-26 Thread Bruce Evans
On Sat, 26 Nov 2011, Robert Millan wrote: On Fri, Nov 25, 2011 at 11:16:15AM -0700, Warner Losh wrote: Hey Bruce, These sound like good suggestions, but I'd hoped to actually go through all these files with a fine-toothed comb to see which ones were still relevant. You've found a bunch of g

Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-26 Thread Warner Losh
This looks fine to me. Warner On Nov 26, 2011, at 1:07 PM, Robert Millan wrote: > ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@fre

Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-26 Thread Robert Millan
On Fri, Nov 25, 2011 at 11:16:15AM -0700, Warner Losh wrote: > Hey Bruce, > > These sound like good suggestions, but I'd hoped to actually go through all > these files with a fine-toothed comb to see which ones were still relevant. > You've found a bunch of good areas to clean up, but I'd like

Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-25 Thread Warner Losh
Hey Bruce, These sound like good suggestions, but I'd hoped to actually go through all these files with a fine-toothed comb to see which ones were still relevant. You've found a bunch of good areas to clean up, but I'd like to humbly suggest they be done in a follow-on commit. Warner On Nov

Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-25 Thread Bruce Evans
On Thu, 24 Nov 2011, Robert Millan wrote: 2011/11/24 Bruce Evans : Now it adds lots of namespace pollution (all of , including all of its namespace pollution), just to get 1 new symbol defined. Well, my initial patch (see mail with same subject modulo "v2") didn't have this problem. Now that

Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-24 Thread Robert Millan
Hi Bruce, 2011/11/24 Bruce Evans : > Now it adds lots of namespace pollution (all of , including > all of its namespace pollution), just to get 1 new symbol defined. Well, my initial patch (see mail with same subject modulo "v2") didn't have this problem. Now that __FreeBSD_kernel__ is defined,

Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-23 Thread Bruce Evans
On Wed, 23 Nov 2011, Robert Millan wrote: Here we go again :-) Out of the kernel headers that are installed in /usr/include/ hierracy, there are some which include support multiple operating systems (usually FreeBSD and other *BSD flavours). This patch adds support to detect GNU/kFreeBSD as we

[PATCH] Detect GNU/kFreeBSD in user-visible kernel headers (v2)

2011-11-22 Thread Robert Millan
Here we go again :-) Out of the kernel headers that are installed in /usr/include/ hierracy, there are some which include support multiple operating systems (usually FreeBSD and other *BSD flavours). This patch adds support to detect GNU/kFreeBSD as well. In all cases, we match the same declara