Buf ring cleanups

2015-07-30 Thread Zbigniew Bodek
Hello, I'm writing to ensure what to do with that patch: https://reviews.freebsd.org/D1945 It was created as a result of discussion related to this review: https://reviews.freebsd.org/D1833 The patch (D1945) is still waiting to be committed. We really need fix for ARM in buf_ring so if someone is

Patch to replace part of common bus code with one function.

2015-01-12 Thread Zbigniew Bodek
Hello all, I would like to share a patch that groups some portion of common bus code into one function that can be then reused. You can check it out in Phabricator https://reviews.freebsd.org/D1504 Feel free to test the patch and send your comments as well as remarks. Best regards zbb __

Re: Changes to UART ns8250

2013-10-26 Thread Zbigniew Bodek
Hello again. I've just committed the patch: http://svnweb.freebsd.org/base?view=revision&revision=257170 Thanks and best regards Zbigniew Bodek 2013/10/26 Zbigniew Bodek : > Hello Everyone, > > I'm attaching the newest version of the ns8250 UART patch. > After some d

Re: Changes to UART ns8250

2013-10-25 Thread Zbigniew Bodek
time since we know that LCR is locked). If there are no objections then I would like to commit this soon. Best regards Zbigniew Bodek 2013/10/9 Zbigniew Bodek : > Hello Ganbold. > > Thank you for testing the patch and pointing those issue out. > My detection log from Armada XP

Re: Changes to UART ns8250

2013-10-09 Thread Zbigniew Bodek
is causing that we only wait until UART is not busy anymore. I can't find why would that cause problems if your UART requires busy detection anyway. Best regards Zbigniew Bodek 2013/10/9 Ganbold Tsagaankhuu > > > > On Tue, Oct 8, 2013 at 9:58 AM, Ganbold Tsagaankhuu wrote: &g

Re: Changes to UART ns8250

2013-10-07 Thread Zbigniew Bodek
a critical section" Best regards Zbigniew Bodek 2013/10/7 Ian Lepore > On Mon, 2013-10-07 at 14:56 -0600, Ian Lepore wrote: > > On Mon, 2013-10-07 at 22:36 +0200, Zbigniew Bodek wrote: > > > Hello Adrian, > > > > > > Thank you for your remarks. > > &g

Re: Changes to UART ns8250

2013-10-07 Thread Zbigniew Bodek
Hello Adrian, Thank you for your remarks. Please check my answers in-line. Best regards Zbigniew Bodek 2013/10/7 Adrian Chadd > Hi, > > You should add: > > * a loop counter, to break out after a while; > [ZBB] In general as long as UART is busy we cannot proceed but if the

Changes to UART ns8250

2013-10-07 Thread Zbigniew Bodek
this issue 100/100 attempts. The patch was tested by kevlo@ and me and it works on our Armada XP - based systems. Please send your comment or remarks if there are any. Best regards Zbigniew Bodek 0001-Wait-for-DesignWare-UART-transfers-completion-before.patch Description: Binary data