Re: change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Jakob Alvermark
On 4/26/23 16:00, Dmitry Chagin wrote: On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote: Hi, I use net/citrix_ica for work. https://cgit.FreeBSD.org/src/commit/?id=76f8584e49cf7eedaa2e1312593bf46c7225d79a Yes, this works. Thanks for the quick response! After a recent change t

Re: change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Dmitry Chagin
On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote: > Hi, > > > I use net/citrix_ica for work. https://cgit.FreeBSD.org/src/commit/?id=76f8584e49cf7eedaa2e1312593bf46c7225d79a > > After a recent change to -current in compat/linux it no longer works. > The binary just segfaults. >

Re: Link modules to DYN type

2023-04-26 Thread Jan Martin Mikkelsen
> On 26. Apr 2023, at 13:38, Hans Petter Selasky wrote: > > On 4/26/23 13:12, Konstantin Belousov wrote: >> No, in-kernel linker does not behave this way. >> Modules need to contain explicit reference to all modules they depend upon, >> using the MODULE_DEPEND() macro. Only symbols from the de

Re: Link modules to DYN type

2023-04-26 Thread Konstantin Belousov
On Wed, Apr 26, 2023 at 01:38:32PM +0200, Hans Petter Selasky wrote: > On 4/26/23 13:12, Konstantin Belousov wrote: > > No, in-kernel linker does not behave this way. > > Modules need to contain explicit reference to all modules they depend upon, > > using the MODULE_DEPEND() macro. Only symbols f

Re: github CI failures related to tzsetup

2023-04-26 Thread Yuri
Yuri wrote: > Looking at the CI jobs on github, all seem to fail in tzsetup while > making kernel-toolchain target. Obviously this build for me locally, > FreeBSD's CI is fine with it, it's only ubuntu and macos jobs reporting > the errors, and I don't see why; any hints? > > https://github.com/f

github CI failures related to tzsetup

2023-04-26 Thread Yuri
Looking at the CI jobs on github, all seem to fail in tzsetup while making kernel-toolchain target. Obviously this build for me locally, FreeBSD's CI is fine with it, it's only ubuntu and macos jobs reporting the errors, and I don't see why; any hints? https://github.com/freebsd/freebsd-src/actio

Re: Link modules to DYN type

2023-04-26 Thread Hans Petter Selasky
On 4/26/23 13:12, Konstantin Belousov wrote: No, in-kernel linker does not behave this way. Modules need to contain explicit reference to all modules they depend upon, using the MODULE_DEPEND() macro. Only symbols from the dependencies are resolved. All modules get an implicit reference to kern

Re: Link modules to DYN type

2023-04-26 Thread Konstantin Belousov
On Wed, Apr 26, 2023 at 12:55:02PM +0200, Hans Petter Selasky wrote: > On 4/26/23 12:36, Zhenlei Huang wrote: > > Hi, > > > > I'm recently working on https://reviews.freebsd.org/D39638 (sysctl(9): > > Enable vnet sysctl variables be loader tunable), > > the changes to `sys/kern/link_elf_obj.c` ar

Re: Link modules to DYN type

2023-04-26 Thread Hans Petter Selasky
On 4/26/23 12:36, Zhenlei Huang wrote: Hi, I'm recently working on https://reviews.freebsd.org/D39638 (sysctl(9): Enable vnet sysctl variables be loader tunable), the changes to `sys/kern/link_elf_obj.c` are runtime tested, but not those to `sys/kern/link_elf.c` . After some hacking I realize

Link modules to DYN type

2023-04-26 Thread Zhenlei Huang
Hi, I'm recently working on https://reviews.freebsd.org/D39638 (sysctl(9): Enable vnet sysctl variables be loader tunable), the changes to `sys/kern/link_elf_obj.c` are runtime tested, but not those to `sys/kern/link_elf.c` . After some hacking I realized that `link_elf.c` is for EXEC (Executab

Re: change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Dmitry Chagin
On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote: > Hi, > > > I use net/citrix_ica for work. > > After a recent change to -current in compat/linux it no longer works. > The binary just segfaults. > > I have bisected and it happened after this commit: > > commit 40c36c4674eb9602

Re: change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Alexander Leidinger
Quoting Jakob Alvermark (from Wed, 26 Apr 2023 09:01:00 +0200): Hi, I use net/citrix_ica for work. After a recent change to -current in compat/linux it no longer works. The binary just segfaults. What does "sysctl compat.linux.osrelease" display? If it is not 2.6.30 or higher, try to

change in compat/linux breaking net/citrix_ica

2023-04-26 Thread Jakob Alvermark
Hi, I use net/citrix_ica for work. After a recent change to -current in compat/linux it no longer works. The binary just segfaults. I have bisected and it happened after this commit: commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6 Author: Dmitry Chagin Date:   Sat Apr 22 22:17:17 2023 +030