Re: Coarray on trunk

2025-07-01 Thread Andre Vehreschild
Hi Jerry, thanks for the report. I am positive that I merged the correct patch, but I'll check tomorrow when it's a little bit cooler. At the moment it's so incredibly hot, one can't concentrate. Sorry for the mess, Andre Andre Vehreschild * ve...@gmx.de Am 1. Juli 2025 19:33:41 schrieb Jerry

Re: Coarray on trunk

2025-07-01 Thread Andre Vehreschild
Hi Jerry, I just had a look into pr120843 and I have successfully merged the old version of the patch. This what you are hitting now. I am very sorry. The new 'else if' near the coarray error message should be something like: else if (!op1.ref || !gfc_ref_this_image (op1.ref) || and the same

[PATCH] Fortran: fix minor issues with coarrays

2025-07-01 Thread Harald Anlauf
Dear all, the attached patch fixes the following minor issues found by running f951 under valgrind for the just added new testcases coindexed_6.f90 and coindexed_7.f90: - minor front-end memleaks with non-freed strings and lost GMP variables (these are simple and obvious fixes) - an inconsiste

Re: [PATCH] Fortran: fix minor issues with coarrays

2025-07-01 Thread Jerry D
On 7/1/25 12:51 PM, Harald Anlauf wrote: Dear all, the attached patch fixes the following minor issues found by running f951 under valgrind for the just added new testcases coindexed_6.f90 and coindexed_7.f90: - minor front-end memleaks with non-freed strings and lost GMP variables  (these are

Coarray on trunk

2025-07-01 Thread Jerry D
Hi all, With latest trunk this morning after Andre's commits I am still getting failures with Toon's random_weather.f90. Was there another patch I missed? Jerry $ gfc -fcoarray=single random-weather.f90 f951: internal compiler error: in gfc_ref_this_image, at fortran/expr.cc:5948 0x21dce1f i

Re: [PATCH] Fortran: fix minor issues with coarrays

2025-07-01 Thread Harald Anlauf
Am 01.07.25 um 21:54 schrieb Jerry D: On 7/1/25 12:51 PM, Harald Anlauf wrote: Dear all, the attached patch fixes the following minor issues found by running f951 under valgrind for the just added new testcases coindexed_6.f90 and coindexed_7.f90: - minor front-end memleaks with non-freed stri

Re: [PATCH] gcc: middle-end opt for trigonometric pi-based functions builtins

2025-07-01 Thread Jakub Jelinek
On Sat, Jun 28, 2025 at 02:19:59AM +, Yuao Ma wrote: > > signbit is documented to be a macro, so please don't declare > > int signbit (double); > > function in the testcase and instead of signbit use __builtin_signbit. > > This is indeed my negligence. Done. > > If everything looks good, coul

Re: [Fortran, Patch, PR120843, v2] Fix reject valid, because of inconformable coranks

2025-07-01 Thread Andre Vehreschild
Hi Harald, thanks for the review. Committed as gcc-16-1885-g1b0930e9046. Will backport to gcc-15 in about a week. Thanks again. Regards, Andre On Mon, 30 Jun 2025 22:31:08 +0200 Harald Anlauf wrote: > Am 30.06.25 um 15:25 schrieb Andre Vehreschild: > > Hi all, > > > > here now the v

Re: [Fortran, Patch, PR120847 (was: PR120846), v1] Fix ICE when a function is called more than once in a coarray expression.

2025-07-01 Thread Andre Vehreschild
Hi Harald, thanks for review. Committed as gcc-16-1891-gee31ab9b195. Sorry for the typo in the email title. I should have proof read that before sending. I will set me a reminder to backport in a week to gcc-15. Thanks again, Andre On Mon, 30 Jun 2025 21:44:03 +0200 Harald Anlauf wrot