[Patch, Fortran] Fix PR 24878, checking actual arguments against global symbols

2025-02-08 Thread Thomas Koenig
Hello world, this fixes a rather old PR from 2005, where a subroutine could be passed and called as a function. This patch checks for that, also for the reverse, and for wrong types of functions. I expect that this will find a few bugs in dusty deck code... Regression-tested. OK for trunk? Be

Re: [PATCH] OpenMP: Improve Fortran metadirective diagnostics [PR107067]

2025-02-08 Thread Sandra Loosemore
On 2/4/25 01:49, Tobias Burnus wrote: [snip] To conclude: The patch LGTM but consider giving the user some hint how to solve it, e.g. using one of the ideas above. Thanks for the review. I've pushed the attached version of the patch, which suggests using BLOCK or BEGIN/END METADIRECTIVE (but

Re: [Patch, Fortran] Fix PR 24878, checking actual arguments against global symbols

2025-02-08 Thread Harald Anlauf
Hi Thomas, Am 08.02.25 um 15:31 schrieb Thomas Koenig: Hello world, this fixes a rather old PR from 2005, where a subroutine could be passed and called as a function.  This patch checks for that, also for the reverse, and for wrong types of functions. looks good, just two minor comments: +