Re: [PATCH, v2] Fortran: reject procedures and procedure pointers as IO element [PR107074]

2022-10-06 Thread Mikael Morin
Le 05/10/2022 à 22:40, Harald Anlauf a écrit : Hi Mikael, Gesendet: Mittwoch, 05. Oktober 2022 um 12:34 Uhr Von: "Mikael Morin" Please move the check to resolve_transfer in resolve.cc. I have done this, see attached updated patch. Regtests cleanly on x86_64-pc-linux-gnu. Strangely, the pa

[Patch] openmp: Map holds clause to IFN_ASSUME for Fortran

2022-10-06 Thread Tobias Burnus
Same as for C/C++, albeit a tiny bit longer patch. I don't know whether it makes sense to handle – in the long run – the case of se.pre/se.post being nonempty – and, if so, how. OK for mainline? Tobias - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 806

Re: [Patch] openmp: Map holds clause to IFN_ASSUME for Fortran

2022-10-06 Thread Jakub Jelinek via Fortran
On Thu, Oct 06, 2022 at 12:55:01PM +0200, Tobias Burnus wrote: > Same as for C/C++, albeit a tiny bit longer patch. > > I don't know whether it makes sense to handle – in the long run – the > case of se.pre/se.post being nonempty – and, if so, how. I think it is essential not to throw those away,

Re: [Patch] openmp: Map holds clause to IFN_ASSUME for Fortran

2022-10-06 Thread Tobias Burnus
On 06.10.22 14:17, Jakub Jelinek wrote: On Thu, Oct 06, 2022 at 12:55:01PM +0200, Tobias Burnus wrote: I don't know whether it makes sense to handle – in the long run – the case of se.pre/se.post being nonempty – and, if so, how. I think it is essential not to throw those away, if se.pre or se.

Re: [Patch] openmp: Map holds clause to IFN_ASSUME for Fortran

2022-10-06 Thread Jakub Jelinek via Fortran
On Thu, Oct 06, 2022 at 06:15:52PM +0200, Tobias Burnus wrote: > On 06.10.22 14:17, Jakub Jelinek wrote: > > On Thu, Oct 06, 2022 at 12:55:01PM +0200, Tobias Burnus wrote: > > > I don't know whether it makes sense to handle – in the long run – the > > > case of se.pre/se.post being nonempty – and,

Re: [PATCH, v2] Fortran: error recovery for invalid types in array constructors [PR107000]

2022-10-06 Thread Mikael Morin
Le 05/10/2022 à 23:40, Harald Anlauf a écrit : There is one last thing that I'm dissatisfied with. The handling of unknown types should be moved to reduce_binary, because the dispatching in reduce_binary doesn't handle EXPR_OP, so even if either or both operands are scalar, they are handled by

Re: [PATCH, v2] Fortran: reject procedures and procedure pointers as IO element [PR107074]

2022-10-06 Thread Mikael Morin
Le 06/10/2022 à 10:37, Mikael Morin a écrit : Le 05/10/2022 à 22:40, Harald Anlauf a écrit : Hi Mikael, Gesendet: Mittwoch, 05. Oktober 2022 um 12:34 Uhr Von: "Mikael Morin" Please move the check to resolve_transfer in resolve.cc. I have done this, see attached updated patch. Regtests clea

Aw: Re: [PATCH, v2] Fortran: reject procedures and procedure pointers as IO element [PR107074]

2022-10-06 Thread Harald Anlauf via Fortran
Hi Mikael, I definitely agree that we need a temporary for the result of MERGE(a,a,.true.), I just haven't found out how to do that. The reason for the bad one-liner was that in gfc_simplify_merge result = gfc_get_parentheses (result); actually does have issues, in that the subsequent

Re: [PATCH, v2] Fortran: error recovery for invalid types in array constructors [PR107000]

2022-10-06 Thread Harald Anlauf via Fortran
Hi Mikael, > Gesendet: Donnerstag, 06. Oktober 2022 um 22:14 Uhr > Von: "Mikael Morin" > An: "Harald Anlauf" > Cc: "fortran" , "gcc-patches" > Betreff: Re: [PATCH, v2] Fortran: error recovery for invalid types in array > constructors [PR107000] > > Le 05/10/2022 à 23:40, Harald Anlauf a écrit