Re: [PATCH v3 06/11] OpenMP: Pointers and member mappings

2022-09-23 Thread Julian Brown
On Thu, 22 Sep 2022 15:17:08 +0200 Jakub Jelinek wrote: > > + bool built_sym_hash = false; > > So, I think usually we don't construct such hash_maps right away, > but have just pointer to the hash map initialized to NULL (then you > don't need to built_sym_hash next to it) and you simply new

Re: [PATCH v2 0/9] fortran: clobber fixes [PR41453]

2022-09-23 Thread Mikael Morin
Le 22/09/2022 à 22:42, Harald Anlauf via Fortran a écrit : Hi Mikael, thanks for this impressive series of patches. Am 18.09.22 um 22:15 schrieb Mikael Morin via Fortran: The first patch is a refactoring moving the clobber generation in gfc_conv_procedure_call where it feels more appropriate.

Re: [PATCH v3 06/11] OpenMP: Pointers and member mappings

2022-09-23 Thread Jakub Jelinek via Fortran
On Fri, Sep 23, 2022 at 08:29:46AM +0100, Julian Brown wrote: > On Thu, 22 Sep 2022 15:17:08 +0200 > Jakub Jelinek wrote: > > > > + bool built_sym_hash = false; > > > > So, I think usually we don't construct such hash_maps right away, > > but have just pointer to the hash map initialized to N

Re: [PATCH v3 06/11] OpenMP: Pointers and member mappings

2022-09-23 Thread Tobias Burnus
Hi Julian and Jakub, hi all, On 23.09.22 09:29, Julian Brown wrote: How about this version? (Re-tested.) [...] * * * Some more generic (pre)remarks – not affecting the patch code, but possibly the commit log message: This follows OMP 5.0, 2.19.7.1 "map Clause": which is also in "OMP 5.2, 5