[Patch] Fortran/OpenMP: Add memory routines existing for C/C++

2021-08-18 Thread Tobias Burnus
The added routines existed before for C/C++ (being part of OpenMP 5.0) but not for Fortran (new there since OpenMP 5.1) – as those are all bind(C), it only affects 'omp_lib' and uses the C interface otherwise. Note 1: OpenMP 5.1 added additional (target) memory routines for C/C++ and Fortran; tho

Re: [Patch] Fortran/OpenMP: Add memory routines existing for C/C++

2021-08-18 Thread Jakub Jelinek via Fortran
On Wed, Aug 18, 2021 at 11:00:47AM +0200, Tobias Burnus wrote: > Note 2 --- > 'omp_lib.h' is included in as declaration-construct in the > specification-part of a file (i.e. possibly after an implicit statement); > hence, it cannot contain a use-stmt. Additiona

Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514

2021-08-18 Thread Tobias Burnus
Hi Harald, sorry for the belated review. On 03.08.21 23:17, Harald Anlauf wrote: allocate(x%str2, source="abd") if (len (x%str)) /= 1) ... if (len (x%str2(1:2) /= 2) ... etc. Namely: Search the last_ref = expr->ref->next->next ...? and then check that lastref? The mentioned search is now impl

(Re: [committed] openmp: Add nothing directive support)

2021-08-18 Thread Tobias Burnus
On 18.08.21 11:18, Jakub Jelinek wrote: As has been clarified, it is intentional that nothing directive is accepted in substatements of selection and looping statements and after labels and is handled as if the directive just isn't there ... And here is the Fortran version; as ST_NONE is used,

Re: (Re: [committed] openmp: Add nothing directive support)

2021-08-18 Thread Jakub Jelinek via Fortran
On Wed, Aug 18, 2021 at 01:10:12PM +0200, Tobias Burnus wrote: > I think otherwise the patch is boring - as boring as 'omp nothing' itself > (outside its use in metadirectives). Yeah, I think nobody sane will use it for anything but metadirective except in compiler testsuites. > Fortran: Add Open

Re: (Re: [committed] openmp: Add nothing directive support)

2021-08-18 Thread Tobias Burnus
On 18.08.21 13:18, Jakub Jelinek wrote: gcc/testsuite/ChangeLog: * gfortran.dg/nothing-1.f90: New test. * gfortran.dg/nothing-2.f90: New test. While testing manually with -fopenmp, I did manage to place it for the testsuite run outside the 'gomp/' subdirectory. – Now fixed → attachme

F2018 C949

2021-08-18 Thread Steve Kargl via Fortran
For those that might care, I draw your attention to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101967 Good opportunity for a lurker to step forward and become a gfortran committer. Otherwise, this patch will fester in bugzilla with the dozen or so other patches I've attached to PRs over the la

Re: [PATCH] PR fortran/100950 - ICE in output_constructor_regular_field, at varasm.c:5514

2021-08-18 Thread Harald Anlauf via Fortran
Hi Tobias, > Gesendet: Mittwoch, 18. August 2021 um 12:22 Uhr > Von: "Tobias Burnus" > > Note, however, that gfc_simplify_len still won't handle neither > > deferred strings nor their substrings. > > > > I think there is nothing to simplify at compile time here. > > Obviously, nonsubstrings can

[PATCH, Fortran] Revert to non-multilib-specific ISO_Fortran_binding.h

2021-08-18 Thread Sandra Loosemore
This is a follow-up to commit fef67987cf502fe322e92ddce22eea7ac46b4d75: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=fef67987cf502fe322e92ddce22eea7ac46b4d75 I realized last week that having multilib-specific versions of ISO_Fortran_binding.h (generated by running the compiler to ask what kin

[patch, libgfortran] Further fixes for GFC/CFI descriptor conversions

2021-08-18 Thread Sandra Loosemore
This patch addresses several bugs in converting from GFC to CFI descriptors and vice versa. It incorporates bits and pieces of an earlier patch from José https://gcc.gnu.org/pipermail/fortran/2021-June/056154.html that is now quite bit-rotten. The root of all the problems addressed here is t

Re: F2018 C937

2021-08-18 Thread Arjen Markus via Fortran
Hi Steve, I am willing to take up this challenge ;), as well as the patch for C949. It would be my next attempt to get acquainted with the source code (a first step hopefully to actively contribute). Regards, Arjen Op di 17 aug. 2021 om 21:02 schreef Steve Kargl via Fortran < fortran@gcc.gnu.or