Enable 'gfortran.dg/weak-2.f90' for nvptx target (was: Support for WEAK attribute, part 2)

2023-03-28 Thread Thomas Schwinge
Hi! On 2023-02-24T07:16:51+0200, Rimvydas Jasinskas via Fortran wrote: > From 5b83226c714b17780334b5bad9b17c2266af8232 Mon Sep 17 00:00:00 2001 > From: Rimvydas Jasinskas > Date: Fri, 24 Feb 2023 04:41:00 + > Subject: Fortran: Add support for WEAK attribute for variables > > Add the rest o

Re: Support for WEAK attribute, part 2

2023-02-24 Thread Harald Anlauf via Fortran
Hi Rimvydas, Am 24.02.23 um 06:16 schrieb Rimvydas Jasinskas via Gcc-patches: On Thu, Feb 23, 2023 at 10:53 PM Harald Anlauf wrote: the patch is mostly fine, but there is a minor style issue: + if (sym->attr.ext_attr & (1 << EXT_ATTR_WEAK)) + gfc_error ("Symbol %qs at %L has the WE

Re: Support for WEAK attribute, part 2

2023-02-23 Thread Rimvydas Jasinskas via Fortran
On Thu, Feb 23, 2023 at 10:53 PM Harald Anlauf wrote: > the patch is mostly fine, but there is a minor style issue: > > + if (sym->attr.ext_attr & (1 << EXT_ATTR_WEAK)) > + gfc_error ("Symbol %qs at %L has the WEAK attribute but is a %s", > + sym->name, &sym->declared_a

Re: Support for WEAK attribute, part 2

2023-02-23 Thread Harald Anlauf via Fortran
Hi Rimvydas, > Attached is part2 patch for weak variables support. the patch is mostly fine, but there is a minor style issue: + if (sym->attr.ext_attr & (1 << EXT_ATTR_WEAK)) + gfc_error ("Symbol %qs at %L has the WEAK attribute but is a %s", + sym->name, &sym->decla

Re: Support for WEAK attribute, part 2

2023-02-23 Thread Rimvydas Jasinskas via Fortran
Thank you Harald, for the feedback! Attached is part2 patch for weak variables support. I'll post part3 patch for module-wide attribute support separately. Best regards, Rimvydas From fb1cf60d3fd7c6aa2d9787bb3af86f18e0178bf7 Mon Sep 17 00:00:00 2001 From: Rimvydas Jasinskas Date: Thu, 23 Feb 20

Re: Support for WEAK attribute, part 2

2023-02-16 Thread Harald Anlauf via Fortran
Hi Rimvydas, > Gesendet: Mittwoch, 15. Februar 2023 um 21:58 Uhr > Von: "Rimvydas Jasinskas" > > On Tue, Feb 14, 2023 at 9:55 PM Harald Anlauf wrote: > > >>> There is one thing I cannot test, which is the handling of weak symbols > > >>> on other platforms. A quick glance at the C testcases sug

Support for WEAK attribute, part 2

2023-02-15 Thread Rimvydas Jasinskas via Fortran
On Tue, Feb 14, 2023 at 9:55 PM Harald Anlauf wrote: > >>> There is one thing I cannot test, which is the handling of weak symbols > >>> on other platforms. A quick glance at the C testcases suggests that > >>> someone with access to either an NVPTX or MingGW target might tell > >>> whether that