I have taken the attempt at inlining f_c_string()
as far as I can. The WIP patch is attached to the
PR along with the final issue that I cannot resolve.
If anyone wants to finish the patch, feel free to
do so.
--
Steve
On Fri, Dec 13, 2024 at 03:09:57PM -0800, Steve Kargl wrote:
> On Fri, Dec 13, 2024 at 10:54:03PM +0100, Mikael Morin wrote:
> > Le 13/12/2024 à 21:55, Steve Kargl a écrit :
> > > On Mon, Dec 09, 2024 at 06:39:19PM -0800, Steve Kargl wrote:
> > > >
> > > > I've an almost complete implementation of
On Fri, Dec 13, 2024 at 10:54:03PM +0100, Mikael Morin wrote:
> Le 13/12/2024 à 21:55, Steve Kargl a écrit :
> > On Mon, Dec 09, 2024 at 06:39:19PM -0800, Steve Kargl wrote:
> > >
> > > I've an almost complete implementation of F_C_STRING,
> > > but need a bit of insight on the inlining that I'm
>
Le 13/12/2024 à 21:55, Steve Kargl a écrit :
On Mon, Dec 09, 2024 at 06:39:19PM -0800, Steve Kargl wrote:
I've an almost complete implementation of F_C_STRING,
but need a bit of insight on the inlining that I'm
trying to implement. In pseudo-code, F_C_STRING is
case 1. f_c_string(string)
On Mon, Dec 09, 2024 at 06:39:19PM -0800, Steve Kargl wrote:
>
> I've an almost complete implementation of F_C_STRING,
> but need a bit of insight on the inlining that I'm
> trying to implement. In pseudo-code, F_C_STRING is
>
> case 1. f_c_string(string) = trim(string) // c_null_
FX,
You're likely correct that the creation of an expression for
c_null_char is overkill. I copied the code from gfc_conv_concat_op()
in trans-expr.cc to get the 'f_c_string(s) -> trim(s) // c_null_char'.
This was the motivation of creating a string. If I look at the
-fdump-tree-orginal for
Hi Steve,
I think it’d be simpler not to create a front-end expression for the
c_null_char. Unless I’m mistaken, you only need it as an argument to pass to
build_call_expr_loc (input_location, gfor_fndecl_concat_string, …). You can
pass a pointer to the constant character, and the length is one
On Tue, Dec 10, 2024 at 09:05:02AM +0100, FX Coudert wrote:
> Hi Steve,
>
> > I've an almost complete implementation of F_C_STRING,
> > but need a bit of insight on the inlining that I'm
> > trying to implement.
>
> Maybe I can help. Can you send in your current patch?
>
FX,
I've attached the
Hi Steve,
> I've an almost complete implementation of F_C_STRING,
> but need a bit of insight on the inlining that I'm
> trying to implement.
Maybe I can help. Can you send in your current patch?
FX