Re: Fix type of malloc call in trans-expr.cc

2024-11-15 Thread Jan Hubicka
> Hi Jakub, > > Good catch! Does it fix any specific PR? > > If you don't have the time, I would be happy to apply the correction to > 13-branch through to mainline. I caught it with my WIP patch to improve tree-ssa-dce. I am not aware it can produce wrong code. It will likely lead to missed o

Re: Fix type of malloc call in trans-expr.cc

2024-11-15 Thread Jakub Jelinek
On Fri, Nov 15, 2024 at 07:45:32AM +, Paul Richard Thomas wrote: > Hi Jakub, Honza's catch. > Good catch! Does it fix any specific PR? Dunno. I think even without a PR it can be backported after a while. Jakub

Re: Fix type of malloc call in trans-expr.cc

2024-11-14 Thread Paul Richard Thomas
Hi Jakub, Good catch! Does it fix any specific PR? If you don't have the time, I would be happy to apply the correction to 13-branch through to mainline. Regards Paul On Thu, 14 Nov 2024 at 22:24, Jakub Jelinek wrote: > On Thu, Nov 14, 2024 at 08:58:26PM +0100, Jan Hubicka wrote: > > fortra

Re: Fix type of malloc call in trans-expr.cc

2024-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2024 at 08:58:26PM +0100, Jan Hubicka wrote: > fortran produces malloc call with signed size instead of unsigned. This > in turn makes gimple_call_builtin_p to fail type checking and we do not > treat the call as malloc call. > > regtested x86_64-linux, OK? > > gcc/fortran/ChangeL