Re: [COMITTED, Patch, Fortran, backport 2 gcc-11] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-06-06 Thread Andre Vehreschild via Fortran
Hi Steve, hi all, the patch for pr98301 has been backported to gcc-11 as 002745ca3668fc5e87c22acc81caaeaaadf9c47a Regards, Andre On Sat, 5 Jun 2021 09:27:16 -0700 Steve Kargl wrote: > On Sat, Jun 05, 2021 at 04:04:51PM +0200, Andre Vehreschild wrote: > > > > I was asked to backport the

Re: [Patch, Fortran, backport 2 gcc-11] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-06-05 Thread Steve Kargl via Fortran
On Sat, Jun 05, 2021 at 04:04:51PM +0200, Andre Vehreschild wrote: > > I was asked to backport the patch for pr98301 to gcc-11. The patches have > been in mainline for two weeks without any defect reports I could fined. The > patch for mainline applied with a bit of shift cleanly. > > Regstested

[Patch, Fortran, backport 2 gcc-11] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-06-05 Thread Andre Vehreschild via Fortran
Hi all, I was asked to backport the patch for pr98301 to gcc-11. The patches have been in mainline for two weeks without any defect reports I could fined. The patch for mainline applied with a bit of shift cleanly. Regstested fine on x86_64/f33. Ok for backport gcc-11? Regards, Andre --

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-23 Thread Martin Liška
On 5/23/21 1:59 PM, Andre Vehreschild wrote: Hi Martin, thanks for pointing that out. I haven't committed for quite some time now and could not find on the webpage how this works nowadays. I was thinking that the special gcc-git-command should have added the Changelog entries automagically and i

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-23 Thread Andre Vehreschild via Fortran
Hi Martin, thanks for pointing that out. I haven't committed for quite some time now and could not find on the webpage how this works nowadays. I was thinking that the special gcc-git-command should have added the Changelog entries automagically and immediately. That they are added by a daily bump

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-22 Thread Martin Liška
On 5/22/21 1:39 PM, Andre Vehreschild via Gcc-patches wrote: Hi Steve and Jerry, thanks for the ok'ing. Committed as https://gcc.gnu.org/g:26ca6dbda23bc6dfab96ce07afa70ebacedfaf9c and https://gcc.gnu.org/g:c4771b3438a8cd9afcef1762957b763f8df3fa6e (for the missing changelog entries). Hello. A

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-22 Thread Andre Vehreschild via Fortran
Hi Steve and Jerry, thanks for the ok'ing. Committed as https://gcc.gnu.org/g:26ca6dbda23bc6dfab96ce07afa70ebacedfaf9c and https://gcc.gnu.org/g:c4771b3438a8cd9afcef1762957b763f8df3fa6e (for the missing changelog entries). - Andre On Fri, 21 May 2021 19:38:00 -0700 Jerry D wrote: > yes, pleas

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-21 Thread Jerry D via Fortran
yes, please commit On 5/21/21 8:08 AM, Steve Kargl via Fortran wrote: On Fri, May 21, 2021 at 10:09:02AM +0200, Andre Vehreschild wrote: Ping, ping! Please find attached a rebased version of the patch for the RANDOM_INIT issue with coarray Fortran. Nothing changed to the previous version, just

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-21 Thread Steve Kargl via Fortran
On Fri, May 21, 2021 at 10:09:02AM +0200, Andre Vehreschild wrote: > Ping, ping! > > Please find attached a rebased version of the patch for the RANDOM_INIT issue > with coarray Fortran. Nothing changed to the previous version, just rebased to > current master. > > Regtested fine on x86_64-linux/

Re: [Ping^2, Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-21 Thread Andre Vehreschild via Fortran
Ping, ping! Please find attached a rebased version of the patch for the RANDOM_INIT issue with coarray Fortran. Nothing changed to the previous version, just rebased to current master. Regtested fine on x86_64-linux/f33. Ok for trunk? - Andre On Mon, 3 May 2021 08:20:36 -0700 Steve Kargl wrote

Re: [Ping, Patch, Fortran, Update 2] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-03 Thread Steve Kargl via Fortran
On Mon, May 03, 2021 at 11:21:10AM +0200, Andre Vehreschild wrote: > Ping! > > Ok for trunk? > > I have looked at other patches, but none was patching any location I have > worked on previously. Therefore I can't return the favor of reviewing any > currently open patches and have to ask for volun

Re: [Ping, Patch, Fortran, Update 2] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-05-03 Thread Andre Vehreschild via Fortran
Ping! Ok for trunk? I have looked at other patches, but none was patching any location I have worked on previously. Therefore I can't return the favor of reviewing any currently open patches and have to ask for volunteers here. - Andre On Mon, 26 Apr 2021 12:36:36 +0200 Andre Vehreschild via Fo

Re: [Patch, Fortran, Update 2] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-04-26 Thread Andre Vehreschild via Fortran
Hi Steve, hi all, I agree. The cas-things have been removed (I will put the patch for them into the pr98301 ticket, so safe them), streamlining the patch a bit more. Bootstraped and regtested ok on x86_64-linux/f33. Ok for trunk? Regards, Andre Steve Kargl PR fortran/98301 - random_

Re: [Patch, Fortran, Update] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-04-25 Thread Steve Kargl via Fortran
On Sat, Apr 24, 2021 at 12:49:45PM +0200, Andre Vehreschild wrote: > Hi Steve, hi all, > > thank you for pointing that out, Steve. When I started the work, I told > myself, that I have to remember to add your patch to the submit. Well, that > did > not last for more than eight hours and I had for

Re: [Patch, Fortran, Update] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-04-24 Thread Dr. Andre Vehreschild via Fortran
Ok, I changed it in the log-file already. - Andre On Sat, 24 Apr 2021 08:44:24 -0700 Steve Kargl wrote: > On Sat, Apr 24, 2021 at 12:49:45PM +0200, Andre Vehreschild wrote: > > > > @Steve: Is this your correct mail address for the changelog or do you > > prefer a different one? > > > > I s

Re: [Patch, Fortran, Update] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-04-24 Thread Steve Kargl via Fortran
On Sat, Apr 24, 2021 at 12:49:45PM +0200, Andre Vehreschild wrote: > > @Steve: Is this your correct mail address for the changelog or do you prefer a > different one? > I still have my ka...@gcc.gnu.org email address. Please use that one. I'll look over the combined patch later today. -- Stev

Re: [Patch, Fortran, Update] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-04-24 Thread Andre Vehreschild via Fortran
Hi Steve, hi all, thank you for pointing that out, Steve. When I started the work, I told myself, that I have to remember to add your patch to the submit. Well, that did not last for more than eight hours and I had forgotten. So here is now the combination of Steve's and my patch (attached). Boo

Re: [Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-04-23 Thread Steve Kargl via Fortran
Andre, Thanks for taking care of OpenCoarray portion of RANDOM_INIT. My last non-coarray aware patch is attached to the PR in bugzilla. Since the change over to git, I no longer commit to the source tree. I suggest combining your patch with my patch if you intend to commit; otherwise, attach your

[Patch, Fortran] PR98301 Re: RANDOM_INIT() and coarray Fortran

2021-04-23 Thread Andre Vehreschild via Fortran
Hi folks, please find attached the library part for supporting RANDOM_INIT for coarray=lib enabled fortran translations. There is also a patch for the Opencoarray library to add RANDOM_INIT there. I am not sure, whether I have modified the gfortran.map file in the libgfortran directory correctly,

Re: RANDOM_INIT() and coarray Fortran

2021-04-03 Thread Steve Kargl via Fortran
On Sat, Apr 03, 2021 at 08:30:31PM -0700, Damian Rouson wrote: > Hi Steve, > > I hope the gfortran developers won't commit a patch that replaces > existing behavior with a stub that simply emits an error message. The current behavior is incorrect with respect to the Fortran standard if one runs a

Re: RANDOM_INIT() and coarray Fortran

2021-04-03 Thread Damian Rouson
. I believe Andre Verheschild has some limited availability so I'm cc'ing him and will discuss it with him if he's interested. If you know others who might be interested, please let us know. Damian On Sat, Apr 3, 2021 at 10:28 AM Steve Kargl via Fortran wrote: > > What to

RANDOM_INIT() and coarray Fortran

2021-04-03 Thread Steve Kargl via Fortran
What to do about RANDOM_INIT() and coarray Fortran? The main issue is that if one compiles with -fcoarray=lib (or the WIP -fcoarray=shared), then RANDOM_INIT() may require communication between images. Thus, RANDOM_INIT() cannot live in libgfortran for at least -fcoarray=lib. Consider the