Re: drop -fdump-fortran-global ? [was: Re: [PATCH, FORTRAN] Fix memory leak of gsymbol]

2023-02-25 Thread Thomas König
On 25.02.23 22:55, Bernhard Reutner-Fischer wrote: but should we really keep the option, if we don't even test basics and if it was more a specific debug dump, from the looks? It is always possible to add test cases if testing is required, but I don't think this is necessary. We also do not ha

drop -fdump-fortran-global ? [was: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol]

2023-02-25 Thread Bernhard Reutner-Fischer via Fortran
On Sun, 31 Oct 2021 21:25:44 +0100 Bernhard Reutner-Fischer wrote: > On Sun, 31 Oct 2021 20:46:07 +0100 > Harald Anlauf wrote: > > > Am 30.10.21 um 23:51 schrieb Bernhard Reutner-Fischer via Fortran: > > >>> The only caller is translate_all_program_units. > > >>> Since we free only module gsy

Re: [PATCH,FORTRAN] Fix memory leak of gsymbol

2021-10-31 Thread Bernhard Reutner-Fischer via Fortran
On Sun, 31 Oct 2021 20:46:07 +0100 Harald Anlauf wrote: > Am 30.10.21 um 23:51 schrieb Bernhard Reutner-Fischer via Fortran: > >>> The only caller is translate_all_program_units. > >>> Since we free only module gsyms, even -fdump-fortran-global is > >>> unaffected by this, fwiw. > > > > AFAICS

Re: [PATCH,FORTRAN] Fix memory leak of gsymbol

2021-10-31 Thread Harald Anlauf via Fortran
Am 30.10.21 um 23:51 schrieb Bernhard Reutner-Fischer via Fortran: The only caller is translate_all_program_units. Since we free only module gsyms, even -fdump-fortran-global is unaffected by this, fwiw. AFAICS we do not have a test for -fdump-fortran-global Do we want to add one, would the att

Re: [PATCH,FORTRAN] Fix memory leak of gsymbol

2021-10-30 Thread Bernhard Reutner-Fischer via Fortran
> > The only caller is translate_all_program_units. > > Since we free only module gsyms, even -fdump-fortran-global is > > unaffected by this, fwiw. AFAICS we do not have a test for -fdump-fortran-global Do we want to add one, would the attached be OK? thanks, >From 7e7856cf9ec88ab7fb48e7c73f9cc6

Re: [PATCH,FORTRAN] Fix memory leak of gsymbol

2021-10-30 Thread Bernhard Reutner-Fischer via Fortran
On Fri, 29 Oct 2021 01:23:02 +0200 Bernhard Reutner-Fischer wrote: > On Thu, 28 Oct 2021 23:37:59 +0200 > Harald Anlauf wrote: > > > Hi Bernhard, > > > > Am 27.10.21 um 23:43 schrieb Bernhard Reutner-Fischer via Gcc-patches: > > > ping > > > [I'll rebase and retest this too since it's been a

Re: [PATCH,FORTRAN] Fix memory leak of gsymbol

2021-10-28 Thread Bernhard Reutner-Fischer via Fortran
On Thu, 28 Oct 2021 23:37:59 +0200 Harald Anlauf wrote: > Hi Bernhard, > > Am 27.10.21 um 23:43 schrieb Bernhard Reutner-Fischer via Gcc-patches: > > ping > > [I'll rebase and retest this too since it's been a while. > > Ok if it passes?] > > > > On Sun, 21 Oct 2018 16:04:34 +0200 > > Bernhard R

Re: [PATCH,FORTRAN] Fix memory leak of gsymbol

2021-10-28 Thread Harald Anlauf via Fortran
Hi Bernhard, Am 27.10.21 um 23:43 schrieb Bernhard Reutner-Fischer via Gcc-patches: ping [I'll rebase and retest this too since it's been a while. Ok if it passes?] On Sun, 21 Oct 2018 16:04:34 +0200 Bernhard Reutner-Fischer wrote: Hi! Regtested on x86_64-unknown-linux, installing on aldot/

Re: [PATCH,FORTRAN] Fix memory leak of gsymbol

2021-10-27 Thread Bernhard Reutner-Fischer via Fortran
ping [I'll rebase and retest this too since it's been a while. Ok if it passes?] On Sun, 21 Oct 2018 16:04:34 +0200 Bernhard Reutner-Fischer wrote: > Hi! > > Regtested on x86_64-unknown-linux, installing on > aldot/fortran-fe-stringpool. > > We did not free global symbols. For a simplified abs