Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-27 Thread Andre Vehreschild
Hi Harald, Am 27. Juli 2025 22:25:40 schrieb Harald Anlauf : Harald, are you still unconvinced? Do we need to discuss the behavior of the testcase test_teams_1? or something else? I will not make any specific suggestions about the actual implementation of coarrays in gfortran. Let me phrase

Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-27 Thread Harald Anlauf
> Gesendet: Sonntag, 27. Juli 2025 um 21:18 > Von: "Mikael Morin" > An: "Andre Vehreschild" > CC: "Harald Anlauf" , fortran@gcc.gnu.org > Betreff: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray > fail to pass, works on 15.1.1 20250712 > > Le 27/07/2025 à 17:35, Andre Vehresch

Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-27 Thread Andre Vehreschild
Well, I have to think about a test case. But a dg-not-present one should be doable. Expr_compcall is not supported in gfortran 's coarray handling at all. I think there is a bug report for this. Teams map to Mpi_communicators 1-to-1. Well, that's my conclusion from reading the standard. It s

Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-27 Thread Mikael Morin
Le 27/07/2025 à 17:35, Andre Vehreschild a écrit : On Sun, 27 Jul 2025 16:57:14 +0200 Mikael Morin wrote: Le 27/07/2025 à 12:57, Andre Vehreschild a écrit : Hi Mikael, In this example, image 1, i.e., for Opencoarrays a thread on image one takes the data from the executing image and wri

Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-27 Thread Andre Vehreschild
On Sun, 27 Jul 2025 16:57:14 +0200 Mikael Morin wrote: > Le 27/07/2025 à 12:57, Andre Vehreschild a écrit : > > Hi Mikael, > > > >>> In this example, image 1, i.e., for > >>> Opencoarrays a thread on image one takes the data from the executing > >>> image and writes it into the memory of im

Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-27 Thread Mikael Morin
Le 27/07/2025 à 12:57, Andre Vehreschild a écrit : Hi Mikael, In this example, image 1, i.e., for Opencoarrays a thread on image one takes the data from the executing image and writes it into the memory of image 1. When you say it takes data, do you mean it takes the assignment right hand side

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Yuao Ma
On 7/27/2025 8:51 PM, Mikael Morin wrote: Le 27/07/2025 à 13:46, Yuao Ma a écrit : On 7/27/2025 7:14 PM, Mikael Morin wrote: Le 27/07/2025 à 11:37, Yuao Ma a écrit : On 7/27/2025 5:19 PM, Mikael Morin wrote: +gfc_charlen_type +string_split (gfc_charlen_type stringlen, const CHARTYPE *str

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Mikael Morin
Le 27/07/2025 à 13:46, Yuao Ma a écrit : On 7/27/2025 7:14 PM, Mikael Morin wrote: Le 27/07/2025 à 11:37, Yuao Ma a écrit : On 7/27/2025 5:19 PM, Mikael Morin wrote: +gfc_charlen_type +string_split (gfc_charlen_type stringlen, const CHARTYPE *string, +  gfc_charlen_type setlen, const

Re: [Fortran, Coarray] Call-out to everyone having Fortran coarray-codes available

2025-07-27 Thread Toon Moene
On 7/24/25 21:49, Toon Moene wrote: On 7/24/25 21:35, Thomas Koenig wrote: Am 23.07.25 um 21:47 schrieb Toon Moene: Today I used Thomas's "locks" example code from the same e-mail message (showing the full output): Actually, I think that example is flawed, it lacks synchronization. Sorry

[PATCH] fortran: Remove useless elements count variable

2025-07-27 Thread Mikael Morin
From: Mikael Morin Regression-tested on x86_64-pc-linux-gnu. OK for master? -- >8 -- The function gfc_array_init_size evaluates the number of array elements to a variable from a caller, but the single caller providing the variable actually doesn't use it. This change removes the variable and t

Re: [PATCH 1/3] fortran: Bound class container lookup after array descriptor [PR121185]

2025-07-27 Thread Paul Richard Thomas
Hi Mikael, This looks fine to me. OK for mainline. Thanks for the fix. Paul On Sat, 26 Jul 2025 at 20:31, Mikael Morin wrote: > From: Mikael Morin > > Regression-tested on x86_64-pc-linux-gnu. > OK for master? > > -- >8 -- > > Don't look for a class container too far after an array descript

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Yuao Ma
Hi Steve, On 7/27/2025 2:25 AM, Steve Kargl wrote: Thanks for the review! If the new patch looks good for trunk and there are no other objections, could you please help me merge it? I haven't committed a patch since the transition from subversion to git. I'm not paid to learn yet-another-SCCS

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Yuao Ma
On 7/27/2025 7:14 PM, Mikael Morin wrote: Le 27/07/2025 à 11:37, Yuao Ma a écrit : On 7/27/2025 5:19 PM, Mikael Morin wrote: +gfc_charlen_type +string_split (gfc_charlen_type stringlen, const CHARTYPE *string, +  gfc_charlen_type setlen, const CHARTYPE *set, +  gfc_charlen_typ

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Mikael Morin
Le 27/07/2025 à 11:37, Yuao Ma a écrit : On 7/27/2025 5:19 PM, Mikael Morin wrote: +gfc_charlen_type +string_split (gfc_charlen_type stringlen, const CHARTYPE *string, +  gfc_charlen_type setlen, const CHARTYPE *set, +  gfc_charlen_type pos, GFC_LOGICAL_4 back) +{ +  gfc_charlen_

Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-27 Thread Andre Vehreschild
Hi Mikael, > > In this example, image 1, i.e., for > > Opencoarrays a thread on image one takes the data from the executing > > image and writes it into the memory of image 1. > When you say it takes data, do you mean it takes the assignment right > hand side (named "data"), or do you mean th

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Yuao Ma
On 7/27/2025 5:43 PM, Mikael Morin wrote: I forgot to add: +  else +    { +  if (pos < 1 || pos > (stringlen + 1)) +    runtime_error ("If BACK is present with the value true, the value of " +   "POS shall be in the range [1, LEN (STRING) + 1]"); + can you provide the valu

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Mikael Morin
I forgot to add: +  else +    { +  if (pos < 1 || pos > (stringlen + 1)) +    runtime_error ("If BACK is present with the value true, the value of " +   "POS shall be in the range [1, LEN (STRING) + 1]"); + can you provide the value of pos and stringlen in the error messages?

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Yuao Ma
On 7/27/2025 5:19 PM, Mikael Morin wrote: +gfc_charlen_type +string_split (gfc_charlen_type stringlen, const CHARTYPE *string, +  gfc_charlen_type setlen, const CHARTYPE *set, +  gfc_charlen_type pos, GFC_LOGICAL_4 back) +{ +  gfc_charlen_type i, j; + +  if (!back) +    { +  i

Re: [PATCH] fortran: implment split for fortran 2023

2025-07-27 Thread Mikael Morin
Le 27/07/2025 à 05:40, Yuao Ma a écrit : Hi Mikael, On 7/27/2025 3:57 AM, Mikael Morin wrote: Hello, here are a few more comments on the patch below. It's not ready yet, but the remarks should be easily addressed. Thanks for the thorough review! I've addressed the comments and attached a n

Re: Aw: Re: Add: [Bug fortran/121043] [16 Regression] Tests of OpenCoarray fail to pass, works on 15.1.1 20250712

2025-07-27 Thread Mikael Morin
Le 26/07/2025 à 23:14, Andre Vehreschild a écrit : Hi Harald and Mikael, sorry when I jumped too much in answering different questions to my evident error. What I am trying to correct with my lastest patch is exactly what Harald wants. Standard compliant evaluation of all arguments to a (coi