[PATCH] fortran, v2: Fix up minloc/maxloc lowering [PR120191]

2025-05-11 Thread Jakub Jelinek
On Sat, May 10, 2025 at 11:21:19AM +0200, Tobias Burnus wrote: > Namely: Similar to above, we should be able to just do: > >    if (dim_arg->expr) > > I think the comment should be also updated and we > can also get rid of the 'actual' variable for cleanup. > > Namely, something like the followi

Re: Testing for prototypes generated from Fortran

2025-05-11 Thread Richard Biener
On Sun, May 11, 2025 at 8:38 PM Harald Anlauf wrote: > > Hi Thomas, > > Am 11.05.25 um 12:51 schrieb Thomas Koenig via Gcc: > > Hi Harald, > > > >> Hi Thomas, > >> > >> On 5/11/25 10:34, Thomas Koenig via Gcc wrote: > >>> As PR120139 has shown (again), it is too easy to create regressions > >>> fo

Re: Testing for prototypes generated from Fortran

2025-05-11 Thread Ben Boeckel
On Sun, May 11, 2025 at 10:34:11 +0200, Thomas Koenig via Gcc wrote: > 2) Dump to standard output and check for the presence of certain > regexps, ignoring anything else. Again, this is something I don't > know how to do. This is…fraught with peril and fiddliness. If the test can stomach some C++

Re: Testing for prototypes generated from Fortran

2025-05-11 Thread Harald Anlauf
Hi Thomas, Am 11.05.25 um 12:51 schrieb Thomas Koenig via Gcc: Hi Harald, Hi Thomas, On 5/11/25 10:34, Thomas Koenig via Gcc wrote: As PR120139 has shown (again), it is too easy to create regressions for dumping C prototypes from Fortran.  The main problem is that there is currently no test

Re: [PATCH] fortran: map atand(y, x) to atan2d(y, x)

2025-05-11 Thread Tobias Burnus
Hi all, hi Yuao, first, thanks for your patch - you are awesome! I believe it fixes the issue reported by Steven in problem report (PR) 113414, https://gcc.gnu.org/PR113413 Thus: * * * [Linking PR numbers] In order to correlate commits to issued (and get them automatically linked), the commit

[PATCH] fortran: map atand(y, x) to atan2d(y, x)

2025-05-11 Thread Yuao Ma
Hi all, According to the Fortran standard, atand(y, x) is equivalent to atan2d(y, x). However, the current atand(y, x) function produces an error. This patch includes the necessary intrinsic mapping, related test, and intrinsic documentation. The minor comment change in intrinsic.cc is cherry-pick

Re: Testing for prototypes generated from Fortran

2025-05-11 Thread Thomas Koenig
Hi Harald, Hi Thomas, On 5/11/25 10:34, Thomas Koenig via Gcc wrote: As PR120139 has shown (again), it is too easy to create regressions for dumping C prototypes from Fortran.  The main problem is that there is currently no test in the testsuite. for something along this variant you can tr

Re: Testing for prototypes generated from Fortran

2025-05-11 Thread Harald Anlauf
Hi Thomas, On 5/11/25 10:34, Thomas Koenig via Gcc wrote: As PR120139 has shown (again), it is too easy to create regressions for dumping C prototypes from Fortran.  The main problem is that there is currently no test in the testsuite. So, what to do?  I see several possibilities: 1a) Change t

Testing for prototypes generated from Fortran

2025-05-11 Thread Thomas Koenig
As PR120139 has shown (again), it is too easy to create regressions for dumping C prototypes from Fortran. The main problem is that there is currently no test in the testsuite. So, what to do? I see several possibilities: 1a) Change the relevant options so that they optionally create a file (s