Re: [Fortran, Patch, PR57598] Fix coarray STOP

2024-12-19 Thread Andre Vehreschild
Hi Jerry, thanks for the review. Committed as gcc-15-6383-ga25cc268846 Thanks again, Andre On Thu, 19 Dec 2024 11:09:20 -0800 Jerry D wrote: > On 12/19/24 4:13 AM, Andre Vehreschild wrote: > > Hi all, > > > > attached patch fixes a rather old open issue, that I stumbled upon > > while

Re: [PATCH] Fortran: potential aliasing of complex pointer inquiry references [PR118120]

2024-12-19 Thread Jerry D
On 12/19/24 1:34 PM, Harald Anlauf wrote: Dear all, the check for potential aliasing of lhs and rhs currently shortcuts if the types differ. This is a problem if one is of type complex and the other is of type real (and of the same kind parameter value), as this ignores that F2008 inquiry refer

Re: [PATCH] Fortran: potential aliasing of complex pointer inquiry references [PR118120]

2024-12-19 Thread Steve Kargl
I'm ok withi your patch. It seems to also catch PR113928. You may want to give others a chance to chime in. -- steve On Thu, Dec 19, 2024 at 09:34:38PM +, Harald Anlauf wrote: > > the check for potential aliasing of lhs and rhs currently shortcuts > if the types differ. This is a problem

[PATCH] Fortran: potential aliasing of complex pointer inquiry references [PR118120]

2024-12-19 Thread Harald Anlauf
Dear all, the check for potential aliasing of lhs and rhs currently shortcuts if the types differ. This is a problem if one is of type complex and the other is of type real (and of the same kind parameter value), as this ignores that F2008 inquiry references (%RE, %IM) could be involved. The att

Re: [Fortran, Patch, PR57598] Fix coarray STOP

2024-12-19 Thread Jerry D
On 12/19/24 4:13 AM, Andre Vehreschild wrote: Hi all, attached patch fixes a rather old open issue, that I stumbled upon while trying to figure, why a test failed on the command line but not in the testsuite. The implementation of the STOP command in caf_single did not hand the errorcode over to

Re: [Fortran, Patch, PR57598] Fix coarray STOP

2024-12-19 Thread Andre Vehreschild
Hi Damian, well F2008 Note 8.30 states: If the stop-code is an integer, it is recommended that the value also be used as the process exit status, if the processor supports that concept. and in F2018 its not even "just a note" anymore, but in 11.4 §2 same sentence as in the note. At least t

Re: [Fortran, Patch, PR57598] Fix coarray STOP

2024-12-19 Thread Damian Rouson
I don’t think the standard requires providing the stop code to the OS, but it recommends doing so. So this is a great idea. Thanks for working on coarray features. Damian On Thu, Dec 19, 2024 at 04:14 Andre Vehreschild wrote: > Hi all, > > attached patch fixes a rather old open issue, that I

[Fortran, Patch, PR57598] Fix coarray STOP

2024-12-19 Thread Andre Vehreschild
Hi all, attached patch fixes a rather old open issue, that I stumbled upon while trying to figure, why a test failed on the command line but not in the testsuite. The implementation of the STOP command in caf_single did not hand the errorcode over to the OS, as does non-caf STOP and as it is requi