Re: [PATCH] Fortran: fix passing of NULL() actual argument to character dummy [PR104819]

2024-11-14 Thread Paul Richard Thomas
Hi Jerry and Harald, I have on several occasions perused gfc_conv_procedure_call with a view to doing exactly the refactoring that you suggest. However, it has grown like Topsy and the logic has become very difficult to follow. This, of course, makes it ripe for refactoring but has turned it into

Re: Fix type of malloc call in trans-expr.cc

2024-11-14 Thread Paul Richard Thomas
Hi Jakub, Good catch! Does it fix any specific PR? If you don't have the time, I would be happy to apply the correction to 13-branch through to mainline. Regards Paul On Thu, 14 Nov 2024 at 22:24, Jakub Jelinek wrote: > On Thu, Nov 14, 2024 at 08:58:26PM +0100, Jan Hubicka wrote: > > fortra

Re: Fix type of malloc call in trans-expr.cc

2024-11-14 Thread Jakub Jelinek
On Thu, Nov 14, 2024 at 08:58:26PM +0100, Jan Hubicka wrote: > fortran produces malloc call with signed size instead of unsigned. This > in turn makes gimple_call_builtin_p to fail type checking and we do not > treat the call as malloc call. > > regtested x86_64-linux, OK? > > gcc/fortran/ChangeL

Re: [PATCH] Fortran: fix passing of NULL() actual argument to character dummy [PR104819]

2024-11-14 Thread Harald Anlauf
Hi Jerry, Am 14.11.24 um 01:17 schrieb Jerry D: On 11/13/24 2:26 PM, Harald Anlauf wrote: Dear all, the attached patch is the third part of a series to fix the handling of NULL() passed to pointer dummy arguments.  This one addresses character dummy arguments (scalar, assumed-shape, assumed-ra