Re: [Patch] Fortran: Dead-function removal in error.cc (shrinking by 40%)

On 11 October 2024 16:42:44 CEST, David Malcolm wrote: >On Fri, 2024-10-11 at 15:34 +0100, Paul Richard Thomas wrote: >> Hi Tobias, >> >> Good catch! It looks 'obvious' to me too :-) yeah, thanks for the explicit cleanup >> > * I want to move support range-based locations, which is also a >>

Re: [Patch] Fortran: Use OpenACC's acc_on_device builtin, fix OpenMP' __builtin_is_initial_device (was: [Patch]

Code review, comments, suggestions, remarks? > +static tree +get_builtin_fn (gfc_symbol * sym) +{ + if (!gfc_option.disable_omp_is_initial_device + && flag_openmp && sym->attr.function && sym->ts.type == BT_LOGICAL + && !strcmp (sym->name, "omp_is_initial_device")) +return bu

[Patch] Fortran: Fix translatability of diagnostic strings

I noticed that several diagnostic strings were not tagged as translatable. I fixed them by adding _ or G_ as prefix ( →gcc/ABOUT-GCC-NLS) and moved a single-use string to the message to make it more readable. One error message did not quit fit the pattern, hence, I modified it slightly, and a fe

Re: [Patch] Fortran: Use OpenACC's acc_on_device builtin, fix OpenMP' __builtin_is_initial_device (was: [Patch]

On 12 October 2024 18:31:41 CEST, Tobias Burnus wrote: >Anyone feeling like reviewing this patch? (Mainly the Fortran side?!?) — Or >should I declare it as OpenMP/(OpenACC) patch and just commit it? > >→ just skimmed briefly again, lgtm >>> Code review, comments, suggestions, remarks? thank

Re: [patch, Fortran] Unsigned constants for ISO_FORTRAN_ENV and ISO_C_BINDING

Hi Jerry, the attached patch implements the constants for UNSIGNED for ISO_FORTRAN_ENV and ISO_C_BINDING.  With this, the implementation of UNSIGNED for gfortran should be complete, modulo bugs, of course. OK for trunk? Looks good to go Thomas. Committed, thanks for the review! Actually, t

Re: [patch, Fortran] Unsigned constants for ISO_FORTRAN_ENV and ISO_C_BINDING

On 10/12/24 9:04 AM, Thomas Koenig wrote: Hello world, the attached patch implements the constants for UNSIGNED for ISO_FORTRAN_ENV and ISO_C_BINDING.  With this, the implementation of UNSIGNED for gfortran should be complete, modulo bugs, of course. OK for trunk? Looks good to go Thomas. Th

Re: [Patch] Fortran: Use OpenACC's acc_on_device builtin, fix OpenMP' __builtin_is_initial_device (was: [Patch]

Anyone feeling like reviewing this patch? (Mainly the Fortran side?!?) — Or should I declare it as OpenMP/(OpenACC) patch and just commit it? → https://gcc.gnu.org/pipermail/gcc-patches/2024-October/664985.html Tobias Tobias Burnus write: I forgot to update the subject line. To make it easier

[patch, Fortran] Unsigned constants for ISO_FORTRAN_ENV and ISO_C_BINDING

Hello world, the attached patch implements the constants for UNSIGNED for ISO_FORTRAN_ENV and ISO_C_BINDING. With this, the implementation of UNSIGNED for gfortran should be complete, modulo bugs, of course. OK for trunk? Best regards Thomas gcc/fortran/ChangeLog: * dump-par

Re: [Patch] Fortran/OpenMP: Warn when mapping polymorphic variables

Now committed as r15-4291-g34b77d1b9ac53c – see attachment. Except that I have excluded the diagnostic-location changes; here, using ranges makes more sense. (I have patch, that works, but I need to check that it won't cause corner-case issues.) Fortran-part of the ChangeLog (see attachment for

Re: [Patch] Fortran: Unify gfc_get_location handling; fix expr->ts bug

Hi Tobias, This unifies the two locus to location_t conversion functions, preparing for some changes I want to do later. In principle, I had the patch this morning; however, the assert is now exercised more often than before - and it triggered rather unexpected when running the testsuite.