[committed] Move gfortran.dg/gomp/allocate-static.f90 to libgomp.fortran/ (was: [r15-4104 Regression] FAIL: gfortran.dg/gomp/allocate-static.f90 -Os (test for excess errors) on Linux/x86_64)

2024-10-07 Thread Tobias Burnus
Committed as r15-4127-gb95ad25f9c9376 Hi Thomas, Thomas Schwinge wrote: On 2024-10-07T17:07:05+0200, Tobias Burnus wrote: If anyone can reproduce this, I would be interested in the excess errors. gfortran: fatal error: cannot read spec file 'libgomp.spec': No such file or directory A

Re: [r15-4104 Regression] FAIL: gfortran.dg/gomp/allocate-static.f90 -Os (test for excess errors) on Linux/x86_64

2024-10-07 Thread Thomas Schwinge
Hi Tobias! On 2024-10-07T17:07:05+0200, Tobias Burnus wrote: > haochen.jiang wrote: >> On Linux/x86_64, >> FAIL: gfortran.dg/gomp/allocate-static.f90 -O0 (test for excess errors) > > If anyone can reproduce this, I would be interested in the excess errors. gfortran: fatal error: cannot re

Re: [Fortran, Patch, PR51815, v3] Fix parsing of substring refs in coarrays.

2024-10-07 Thread Harald Anlauf
Hi Andre, On 10/7/24 11:04, Andre Vehreschild wrote: Hi Harald, thank you for your input. I still have some small nits to discuss to make everyone happy. Therefore: this seems to go into the right direction - except that I am not a great fan of gfc_error_now, as that tries to paper over defic

Re: [patch, fortran] Implement maxloc and minloc for unsigned

2024-10-07 Thread Jerry Delisle
I think your good to go. Thanks for patch! On Mon, Oct 7, 2024, 2:12 AM Andre Vehreschild wrote: > Hi Thomas, > > this patch looks very similar to previous ones. I therefore deem it ok for > mainline. May be you want to wait for Jerry to voice his ok/findings > before you > apply it. > > Thanks

Re: [Ping*3, Patch, Fortran, 77871, v1] Allow for class typed coarray parameter as dummy [PR77871]

2024-10-07 Thread Andre Vehreschild
Hi all, this patch somehow slipped my attention. Anyone for a review? Third time ping! Rebased to current mainline. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre On Wed, 18 Sep 2024 12:30:23 +0200 Andre Vehreschild wrote: > Hi all, > > back from my h

Re: [Patch] OpenMP: Allocate directive for static vars, clean up

2024-10-07 Thread Tobias Burnus
Hi Andre, first, thanks a lot for all your proof reading of patches! That's indeed helpful and reviewing (with offical LGTM stamp or as bystander) is a problem, you help to reduce it! :-) Andre Vehreschild wrote: @@ -821,6 +821,23 @@ gfc_finish_var_decl (tree decl, gfc_symbol * sym) + if (s

Re: [Patch] OpenMP: Allocate directive for static vars, clean up

2024-10-07 Thread Andre Vehreschild
Hi Tobias, just a question: diff --git a/gcc/fortran/trans-decl.cc b/gcc/fortran/trans-decl.cc index 8231bd255d6..2586c6d7a79 100644 --- a/gcc/fortran/trans-decl.cc +++ b/gcc/fortran/trans-decl.cc @@ -821,6 +821,23 @@ gfc_finish_var_decl (tree decl, gfc_symbol * sym) && (TREE_STATIC (decl)

Re: [patch, fortran] Implement maxloc and minloc for unsigned

2024-10-07 Thread Andre Vehreschild
Hi Thomas, this patch looks very similar to previous ones. I therefore deem it ok for mainline. May be you want to wait for Jerry to voice his ok/findings before you apply it. Thanks for the patch. - Andre On Sun, 6 Oct 2024 08:58:30 -0700 Jerry Delisle wrote: > The iparm.m4 was what I was lo

Re: [Fortran, Patch, PR51815, v3] Fix parsing of substring refs in coarrays.

2024-10-07 Thread Andre Vehreschild
Hi Harald, thank you for your input. I still have some small nits to discuss to make everyone happy. Therefore: > this seems to go into the right direction - except that I am not a > great fan of gfc_error_now, as that tries to paper over deficiencies > in error recovery. Me either, but when I r

Re: [Patch] OpenMP: Allocate directive for static vars, clean up

2024-10-07 Thread Tobias Burnus
Now committed as r15-4104-ga8caeaacf499d5. With a wording improvement in the commit log and avoiding an XPASS for C++ by excluding c++98 from the xfail in dg-bogus... xfail. Tobias Tobias Burnus wrote: 'omp allocate' permits to use a different (specified) allocator and alignment for both sta