Re: PRs 88052 and 88190

2024-09-07 Thread Steve Kargl
On Sat, Sep 07, 2024 at 08:17:42PM -0700, Jerry D wrote: > Steve and others > > We continue to run into issues with PRs like this. I would like to close > these out. I completely hate the mechanisms we have for the options. Why? > Because every time I look at it I have to think it through ten w

PRs 88052 and 88190

2024-09-07 Thread Jerry D
Steve and others We continue to run into issues with PRs like this. I would like to close these out. I completely hate the mechanisms we have for the options. Why? Because every time I look at it I have to think it through ten ways to sunday. It is not straight forward. What I would like

Re: New version of unsiged patch

2024-09-07 Thread Thomas Koenig
Steve, Paul, Thanks for doing the review. If it's good enough for you, it is certainly good enough. The first version is committed, thanks! Next on the menu: Matmul (plus whatever bugs turn up when implementing it :) Best regards Thomas

Re: New version of unsiged patch

2024-09-07 Thread Thomas Koenig
Am 06.09.24 um 20:58 schrieb Steve Kargl: Your testcases are all free source form. In fixed form, gfortran would need to deal with 'u = 1 2 3 4 u _8' I don't have the patch in my tree at the moment, it isn't clear to me if the matcher for an unsigned constant is prepared to deal with space betwe

Re: New version of unsiged patch

2024-09-07 Thread Thomas Koenig
Am 06.09.24 um 20:15 schrieb Steve Kargl: +Generally, unsigned integers are only permitted as data in intrinsics. Does the word 'intrinsics' apply to 'intrinsic operators' or 'intrinsic subprograms' or both? This might benefit from a big of wordiness. You're right, that wasn't clear at all.