Re: [PATCH 1/2] PR 115800: Fix libgfortran build using --with-cpu=power5

2024-07-18 Thread Kewen.Lin
Hi Mike, I guess you should CC fortran@gcc.gnu.org as well. on 2024/7/11 01:25, Michael Meissner wrote: > If you build a little endian compiler and select a default CPU of power5 > (i.e. --with-cpu=power5), GCC cannot be built. The reason is that both the > libgfortran and libstdc++-v3 libraries

[PATCH] Fortran: character array constructor with >= 4 constant elements [PR103115]

2024-07-18 Thread Harald Anlauf
Dear all, here's a quite obvious fix for an ICE when processing an array constructor where the first element is of deferred length, and at least four constant elements followed, or an iterator with at least four elements. There is a code path that then tries to combine these constant elements and

Re: [Fortran, Patch, PR77518, (coarray), v1] Fix ICE in sizeof(coarray)

2024-07-18 Thread Paul Richard Thomas
Hi Andre, While I realise that this is not your doing, should we not check DECL_LANG_SPECIFIC ()) before touching GFC_DECL_SAVED_DESCRIPTOR? Or is access guaranteed by the REF_COMPONENT check? A micro-nit line 12 s/User/Use/ Apart from this, it looks to be eminently obvious. OK for mainline. Pa

[Fortran, Patch, PR77518, (coarray), v1] Fix ICE in sizeof(coarray)

2024-07-18 Thread Andre Vehreschild
Hi all, the attached patch fixes an ICE when the object supplied to sizeof() is a coarray of class type. This is fixed by taking the class object from the se's class_container. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre -- Andre Vehreschild * Email: v

Re: [Ping, Fortran, Patch, PR78466, coarray, v1.1] Fix Explicit cobounds of a procedures parameter not respected

2024-07-18 Thread Andre Vehreschild
Hi Paul, thanks for the review. I have experienced that git is a bit picky, when a patch got line breaks from a mailer or something. I usually do `git am ` that also adds the log entry and can `git reset --hard origin/master` easily to get back to the state before the patch application. I will mo

Re: [Patch, fortran] PR108889 -[12/13/14/15 Regression] (Re)Allocate in assignment shows used uninitialized memory warning with -Wall if LHS is unallocated

2024-07-18 Thread Andre Vehreschild
Hi Paul, I checked with an coarray and everything seems to work as expected. Good to merge from my side. Thanks for the patch. - Andre On Thu, 18 Jul 2024 08:04:52 +0100 Paul Richard Thomas wrote: > Hi Andre, > > > > + /* Mark so that rhs "used unallocated" warnings can be > > issued. Co

Re: [Fortran, Patch, PR82904] Fix [11/12/13/14/15 Regression][Coarray] ICE in make_ssa_name_fn, at tree-ssanames.c:261

2024-07-18 Thread Andre Vehreschild
Hi Paul, thanks for the review. Applied as gcc-15-2131-g0231b076dc9 . Regards, Andre > > Hi Andre, > > It looks good to me. I am happy to see that the principle of the > patch has Richi's blessing too. > > OK for mainline. I leave it for you (and Richi?) to decide whether to > backport

Re: [Patch, fortran] PR108889 -[12/13/14/15 Regression] (Re)Allocate in assignment shows used uninitialized memory warning with -Wall if LHS is unallocated

2024-07-18 Thread Paul Richard Thomas
Hi Andre, > + /* Mark so that rhs "used unallocated" warnings can be issued. > Component > +references do not generate the warnings. */ > + for (ref = expr1->ref; ref; ref = ref->next) > + if (ref->type == REF_COMPONENT) > + break; > Good spot - I had gone blind

Re: [Ping, Fortran, Patch, PR78466, coarray, v1.1] Fix Explicit cobounds of a procedures parameter not respected

2024-07-18 Thread Paul Richard Thomas
Hi Andre, The code is standard boilerplate in handling arrays and looks OK to me. That said, I know next to nothing about the handling of co-arrays in gfortran. I hope that others can pick up anything that I have missed. Since you are likely to produce a stream (and have already) of co-array patc