Re: Support for NOINLINE attribute

2023-02-10 Thread Rimvydas Jasinskas via Fortran
On Fri, Feb 10, 2023 at 11:07 PM Harald Anlauf via Fortran wrote: > I actually like the idea of supporting the suggested attributes, > provided they work and behave the same way with and without LTO. All these three declaration attributes apply the same regardless of LTO, LTO just expands what opt

Re: Support for NOINLINE attribute

2023-02-10 Thread Steve Kargl via Fortran
On Fri, Feb 10, 2023 at 10:07:24PM +0100, Harald Anlauf via Fortran wrote: > Hello all, > > I actually like the idea of supporting the suggested attributes, > provided they work and behave the same way with and without LTO. > > - NOINLINE: I disagree with Steve here; we shouldn't invent a new >

Re: Support for NOINLINE attribute

2023-02-10 Thread Harald Anlauf via Fortran
Hello all, I actually like the idea of supporting the suggested attributes, provided they work and behave the same way with and without LTO. - NOINLINE: I disagree with Steve here; we shouldn't invent a new syntax (noinline on/off), and rather follow what other compilers provide (INLINE/NOINL

Re: Support for NOINLINE attribute

2023-02-10 Thread Steve Kargl via Fortran
On Fri, Feb 10, 2023 at 10:38:04AM +0200, Rimvydas Jasinskas wrote: > On Fri, Feb 10, 2023 at 10:24 AM Steve Kargl via Fortran > wrote: > > > would it be possible to extend gfortran attribute support to handle > > > NOINLINE too? Like: "!GCC$ ATTRIBUTES noinline :: ...". > > > > It looks to me lik

[Patch][v2] OpenMP/Fortran: Fix loop-iter var privatization with !$OMP LOOP [PR108512]

2023-02-10 Thread Tobias Burnus
Updated version attached. On 31.01.23 12:20, Jakub Jelinek via Gcc-patches wrote: On Tue, Jan 24, 2023 at 04:24:07PM +0100, Tobias Burnus wrote: + if (code->op == EXEC_OMP_LOOP) +; /* Already rejected in resolve_omp_clauses. */ I don't understand why is this needed. Sure, the vast

Re: Support for NOINLINE attribute

2023-02-10 Thread Rimvydas Jasinskas via Fortran
On Fri, Feb 10, 2023 at 10:24 AM Steve Kargl via Fortran wrote: > > would it be possible to extend gfortran attribute support to handle > > NOINLINE too? Like: "!GCC$ ATTRIBUTES noinline :: ...". > > It looks to me like you are conflating three independent topics. > What does NOINLINE have to do w

Re: Support for NOINLINE attribute

2023-02-10 Thread Steve Kargl via Fortran
On Fri, Feb 10, 2023 at 07:42:47AM +0200, Rimvydas Jasinskas via Fortran wrote: > Hello everyone, > > would it be possible to extend gfortran attribute support to handle > NOINLINE too? Like: "!GCC$ ATTRIBUTES noinline :: ...". It looks to me like you are conflating three independent topics. What