Re: [Patch] Fortran: Fix reallocation on assignment for kind=4 strings [PR107508]

2022-11-05 Thread Bernhard Reutner-Fischer via Fortran
On Sat, 5 Nov 2022 23:28:47 +0100 Tobias Burnus wrote: [no comment. I wonder why we malloc versus realloc in the first place, i'd realloc always for starters. We end up calling into libc anyway, we don't inline any of those calls and we suffer lib-boundary non-IPA trouble either way, still, no? S

[Patch] Fortran: Fix reallocation on assignment for kind=4 strings [PR107508]

2022-11-05 Thread Tobias Burnus
Prior to the attached patch, there is a problem with realloc on assignment with kind=4 characters as the string length was compared with the byte size, which was always true. I initially thought, looking at the code, that scalars have the same issues, but they don't; hence, I ended up with a comm

Re: adding attributes

2022-11-05 Thread Bernhard Reutner-Fischer via Fortran
On Sat, 5 Nov 2022 08:40:06 +0100 Thomas Koenig wrote: > On 04.11.22 21:59, Bernhard Reutner-Fischer via Fortran wrote: > > And not sure if fellow gfortraners would accept this attribute > > target_clones in there in the first place.. > > It might actually be useful. Is there any change about

Re: adding attributes

2022-11-05 Thread Thomas Koenig via Fortran
On 04.11.22 21:59, Bernhard Reutner-Fischer via Fortran wrote: And not sure if fellow gfortraners would accept this attribute target_clones in there in the first place.. It might actually be useful. Is there any change about the calling sequence or anything else that should be visible in a For