Re: [committed] libgomp.fortran/allocate-1.f90: Minor cleanup (was: Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).)

2022-02-04 Thread Tobias Burnus
On 04.02.22 16:33, Thomas Schwinge wrote: Maybe removed locally, I can't tell ;-) -- but it's still in the commit that you pushed. See below. Also, a commented-out '!$omp barrier'; not sure what that one is about. I shall not do commits after one week of 6h+/day virtual OpenMP Face2Face meeting

Re: [committed] libgomp.fortran/allocate-1.f90: Minor cleanup (was: Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).)

2022-02-04 Thread Thomas Schwinge
Hi Tobias! On 2022-02-04T14:57:07+0100, Tobias Burnus wrote: > On 04.02.22 10:37, Thomas Schwinge wrote: >>> I have attached a patch (not commited), which silences the three kind of >>> warnings and fixes the interface issue. >>> TODO: commit it. >> Still "TODO: commit it" ;-) -- and while I have

[committed] libgomp.fortran/allocate-1.f90: Minor cleanup (was: Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).)

2022-02-04 Thread Tobias Burnus
Hi Thomas, On 04.02.22 10:37, Thomas Schwinge wrote: I have attached a patch (not commited), which silences the three kind of warnings and fixes the interface issue. TODO: commit it. Still "TODO: commit it" ;-) -- and while I haven't reviewed the changes in detail, I did spot one item that shou

[Patch] Fortran/OpenMP: Avoid ICE for invalid char array in omp atomic [PR104329]

2022-02-04 Thread Tobias Burnus
Already during parsing, the allocatable character array assignment x = (x) is converted to two gfc_codes with EXEC_ASSIGN, namely: ASSIGN z1:_F.DA0(FULL) (parens z1:x(FULL)) ASSIGN z1:x(FULL) z1:_F.DA0(FULL) But the current code expects only one gfc_code - as parse.c does some checks, th

Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).

2022-02-04 Thread Hafiz Abid Qadeer
On 04/02/2022 09:46, Thomas Schwinge wrote: > > Abid, are you going to address these? I think it does make sense if the > C/C++ and Fortran test cases match as much as feasible. > Sure. I will do that. > However: really (a) remove 'omp_alloctrait (omp_atk_pool_size, 8192)' > altogether, or ins

Re: [PATCH] PR/101135 - Load of null pointer when passing absent assumed-shape array argument for an optional dummy argument

2022-02-04 Thread Mikael Morin
Hello, Le 29/01/2022 à 22:41, Harald Anlauf via Fortran a écrit : Dear Fortranners, compiling with -fsanitize=undefined shows that we did mishandle the case where a missing optional argument is passed to another procedure. Besides the example given in the PR, the existing testcase fortran.dg/m

Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).

2022-02-04 Thread Thomas Schwinge
Hi! On 2022-01-31T19:13:09+, Hafiz Abid Qadeer wrote: > On 25/01/2022 10:32, Tobias Burnus wrote: >> On 25.01.22 10:19, Thomas Schwinge wrote: I am trying to figure out if the problem you observed is a general one or just specific to fortran testcase. >>> So, unless the '-fsanitize=

Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0).

2022-02-04 Thread Thomas Schwinge
Hi Tobias! On 2022-01-24T09:45:48+0100, Tobias Burnus wrote: > On 21.01.22 18:43, Tobias Burnus wrote: >> On 21.01.22 18:15, Thomas Schwinge wrote: >>> 11 | integer(c_int) function is_64bit_aligned (a) bind(C) >>> Warning: Variable ‘a’ at (1) is a dummy argument of the BIND(C) >>