Re: [fluid-dev] invalid instrument/drum selection

2009-03-21 Thread jimmy
> Date: Sun, 15 Mar 2009 18:51:06 -0700 > From: Josh Green > > Hello Jimmy, > > Sorry for the delay.  I looked over your proposed > changes.  It doesn't > seem like that is really the proper place for them though > (would affect > the default SoundFont loader only). > > I went ahead and implem

Re: [fluid-dev] invalid instrument/drum selection

2009-03-15 Thread Josh Green
Hello Jimmy, Sorry for the delay. I looked over your proposed changes. It doesn't seem like that is really the proper place for them though (would affect the default SoundFont loader only). I went ahead and implemented this logic in fluid_synth_program_change. This seems to satisfy basic prese

Re: XG programChange -- Was: Re: [fluid-dev] invalid instrument/drum selection

2009-02-16 Thread Peter Gebauer
Hi Jimmy, migth this be what happens with my Yamaha P-85 when I change istrument? Logged midi events when changing: 2754,M Audio Delta 1010LT:0,System exclusive,,10,f0 43 73 7f 4b 11 00 45 00 f7 2752,M Audio Delta 1010LT:0,Control change,1,94,0 2752,M Audio Delta 1010LT:0,System exclusi

XG programChange -- Was: Re: [fluid-dev] invalid instrument/drum selection

2009-02-15 Thread jimmy
Hi Josh, About XG (and GS) program changes, and how missing instruments might be handled, Here are some comments and observations I found around the web. I think missing drum-kits should be handled similarly. > archive.cs.uu.nl/pub/MIDI/DOC/xg.txt Both specs also operate a scheme of

Re: [fluid-dev] invalid instrument/drum selection

2009-02-07 Thread jimmy
Hi Josh, One more try. This also takes care of drum bank 128 fallback. Here is fluid_defsfont.c : fluid_defsfont_get_preset() > fluid_defpreset_t* fluid_defsfont_get_preset(fluid_defsfont_t* sfont, unsigned int bank, unsigned int num) { fluid_defpreset_t* preset = sfont->preset;

Re: [fluid-dev] invalid instrument/drum selection

2009-02-06 Thread jimmy
> Date: Sat, 31 Jan 2009 20:20:45 -0800 > From: Josh Green > On Fri, 2009-01-30 at 10:14 -0600, S. Christian Collins > wrote: > > I'm used to the following behavior when using MIDI > on a Creative card: > > when I select an instrument not present, such as bank > 8 program 20, > > the MIDI track wi

Re: [fluid-dev] invalid instrument/drum selection

2009-01-31 Thread Josh Green
On Fri, 2009-01-30 at 10:14 -0600, S. Christian Collins wrote: > I'm used to the following behavior when using MIDI on a Creative card: > when I select an instrument not present, such as bank 8 program 20, > the MIDI track will sound using bank 0 program 20 instead. This seems > like a simple and

Re: [fluid-dev] invalid instrument/drum selection

2009-01-30 Thread jimmy
> I'm used to the following behavior when using MIDI on a > Creative card: > when I select an instrument not present, such as bank 8 > program 20, the > MIDI track will sound using bank 0 program 20 instead. > This seems like > a simple and logical way to deal with missing patches, and > is wh

Re: [fluid-dev] invalid instrument/drum selection

2009-01-30 Thread S. Christian Collins
I'm used to the following behavior when using MIDI on a Creative card: when I select an instrument not present, such as bank 8 program 20, the MIDI track will sound using bank 0 program 20 instead. This seems like a simple and logical way to deal with missing patches, and is what I've come to

Re: [fluid-dev] invalid instrument/drum selection

2009-01-29 Thread jimmy
Hi Josh, Thinking some more about hardware and software designs, I believe the safest thing to do when encounter an invalid request is to ignore it, not blindly follow the request/instruction that will cause the system to misbehave. I think FS misbehaves in this case, although it is just my o

Re: [fluid-dev] invalid instrument/drum selection

2009-01-29 Thread jimmy
> Hi Jimmy, > > Just keeping the already selected instrument when an > invalid selection > is received seems strange to me. Do you think that would > create the > desired effect in most MIDI files? It is a case of the > MIDI file > expecting an instrument to be present, which is not, right? > I

Re: [fluid-dev] invalid instrument/drum selection

2009-01-28 Thread jimmy
a PCI SB 5.1 Live! and it doesn't have any muted-channel problem I currently have with FS. Best regards, Jimmy --- On Wed, 1/28/09, Josh Green wrote: > From: Josh Green > Subject: Re: [fluid-dev] invalid instrument/drum selection > To: wg20...@yahoo.com > Cc: fluid-dev@nongnu

Re: [fluid-dev] invalid instrument/drum selection

2009-01-28 Thread Josh Green
Hi Jimmy, Just keeping the already selected instrument when an invalid selection is received seems strange to me. Do you think that would create the desired effect in most MIDI files? It is a case of the MIDI file expecting an instrument to be present, which is not, right? I'm not convinced tha

Re: [fluid-dev] invalid instrument/drum selection

2009-01-28 Thread jimmy
Hi Josh, Also, I dont know much about XG, only bit and pieces I can find on the web. I would love to get to some of the XG docs that were available a while back. I don't know any real info about GS, since I haven't done much searching for GS info. Since I play around with some Yamaha arrange

Re: [fluid-dev] invalid instrument/drum selection

2009-01-28 Thread jimmy
m: Josh Green > Subject: Re: [fluid-dev] invalid instrument/drum selection > To: wg20...@yahoo.com > Cc: fluid-dev@nongnu.org > Date: Tuesday, January 27, 2009, 5:30 PM > Hello Jimmy, > > I remember discussing this issue way back when, but kind of > left it for > later, sinc

Re: [fluid-dev] invalid instrument/drum selection

2009-01-27 Thread Josh Green
Hello Jimmy, I remember discussing this issue way back when, but kind of left it for later, since I wasn't really sure what the best solution was. I should probably read over the older thread, since I think I did have some good ideas of how to resolve it then (something about determining whether

Re: [fluid-dev] invalid instrument/drum selection

2009-01-27 Thread jimmy
Hi Josh, Again, the test midi is: www.sternton.com/midi/xgmidi/orion_xg.mid May I suggest a change in src/fluid_synty.c: fluid_synth_program_change() changing the two lines near the end from: fluid_channel_set_sfontnum(channel, sfont_id); fluid_channel_set_preset(channel

Re: [fluid-dev] invalid instrument/drum selection problem

2009-01-26 Thread jimmy
"preset" variable above is NULL, the channel got set to a NULL-preset. Jimmy --- On Mon, 1/26/09, jimmy wrote: > From: jimmy > Subject: Re: [fluid-dev] invalid instrument/drum selection problem > To: "Josh Green" > Cc: fluid-dev@nongnu.org > Date: Monday, J

Re: [fluid-dev] invalid instrument/drum selection problem

2009-01-26 Thread jimmy
ou have a chance? This is low priority, casual listening for me. Let me know if you can reproduce the problem, or if I could be of any further help. Thanks, Jimmy --- On Wed, 1/9/08, jimmy wrote: > From: jimmy > Subject: Re: [fluid-dev] invalid instrument/drum selection problem

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-09 Thread Josh Green
On Wed, 2008-01-09 at 10:50 -0800, jimmy wrote: > OK, right now I don't often play a midi file by > fluidsynth directly. I do use Kmid, PyKaraoke, or > even some Timidity GUI as Jack client to FluidSynth. > Have a separate FluidSynth instance for praticing my > keyboarding. Recently found Stygmo

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-09 Thread Josh Green
On Wed, 2008-01-09 at 10:27 +, Edenyard wrote: > Josh wrote: > > > I can see an issue though if someone decides to use channel #10 for > > something other than drums (non GM/GS mode). In that case that part of > > your patch would cause a bit of headache for the user. > > I'm not sure if I'm

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-09 Thread jimmy
--- Josh Green <[EMAIL PROTECTED]> wrote: > Hello Jimmy, > > On Mon, 2008-01-07 at 16:15 -0800, jimmy wrote: > > For quick test, I use Kmid to play the MIDI files, > > connect to Qsynth/FluidSynth wiht QJackctl. I > drag > > the MIDI file to Kmid and it interrupts the > existing > > playing, st

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-09 Thread Edenyard
Josh wrote: I can see an issue though if someone decides to use channel #10 for something other than drums (non GM/GS mode). In that case that part of your patch would cause a bit of headache for the user. I'm not sure if I'm understanding this thread correctly since my knowledge of MIDI is,

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-09 Thread Josh Green
Hello Jimmy, On Mon, 2008-01-07 at 16:15 -0800, jimmy wrote: > For quick test, I use Kmid to play the MIDI files, > connect to Qsynth/FluidSynth wiht QJackctl. I drag > the MIDI file to Kmid and it interrupts the existing > playing, starting to play the new file. So probably > Fluidsynth doesn't

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-09 Thread Josh Green
Hello Bernhard, On Tue, 2008-01-08 at 00:40 +0100, Bernhard Schelling wrote: > Hi guys > > Sorry I'm late to the party and I'm not even sure if I can be helpful :-) > > We, too, are using FluidSynth's MIDI file reading and playing capabilities so > we naturally stumbled on the same issues over

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-07 Thread jimmy
--- Josh Green <[EMAIL PROTECTED]> wrote: > It definitely does help. There are a number of > things that need to be > improved with FluidSynth. I rarely use FluidSynth > to play MIDI files, > although it is my plan to use it for that purpose in > the future, for > faster than real-time renderin

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-07 Thread jimmy
--- Josh Green <[EMAIL PROTECTED]> wrote: > Cool, thanks for the examples. Sounds like > FluidSynth should reset > itself to a default state each time a new MIDI file > is started. > > I just tried that last MIDI file and did not > experience the same issue > as far as the drums channel #10 gett

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-07 Thread Bernhard Schelling
Hi guys Sorry I'm late to the party and I'm not even sure if I can be helpful :-) We, too, are using FluidSynth's MIDI file reading and playing capabilities so we naturally stumbled on the same issues over development/testing. Here are two patches which show all our fixes concerning these featu

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-07 Thread Josh Green
On Mon, 2008-01-07 at 12:03 -0800, jimmy wrote: > Hi Josh, > > Sorry, I missed the part you asked about specific MIDI > files that causes problem. The last file on this list > is one that will cause trouble. > > www.geocities.com/TheTropics/Cabana/4967/inicial.html > www.geocities.com/TheTropics

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-07 Thread Josh Green
Hello Jimmy, On Mon, 2008-01-07 at 10:20 -0800, jimmy wrote: > Hi Josh, > > I'm sure the different specs for GM, GS, XG, XG-lite > basically made up their own "specific scenarios". > From what I see, each channel is like a patch cord > into a mixer, if the Cello-ist broke a string, it may > not

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-07 Thread jimmy
Hi Josh, Sorry, I missed the part you asked about specific MIDI files that causes problem. The last file on this list is one that will cause trouble. www.geocities.com/TheTropics/Cabana/4967/inicial.html www.geocities.com/TheTropics/Cabana/4967/Amor_Eterno.mid www.geocities.com/TheTropics/Cabana

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-07 Thread jimmy
Hi Josh, I'm sure the different specs for GM, GS, XG, XG-lite basically made up their own "specific scenarios". >From what I see, each channel is like a patch cord into a mixer, if the Cello-ist broke a string, it may not be ideal but a Timpani-ist or a Guitar-ist from the openning band wouldn't

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-06 Thread Josh Green
Hello Jimmy, I did a little research into this issue and found that it is a bit more involved than I had initially thought. I think it would help to start with looking at some example problem MIDI files. Can you point out specific ones which you are having issues with? Reading up on the subject

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-06 Thread jimmy
Hi Josh, Below is the changes I tried. It does seem to keep the existing dromset for any invalid drum-bank requests. Also changed the constant DRUM_INST_MASK , which could potentially requires a re-compile of any other programss using this constant. I think the DRUM_INST_MASK should be 128, not

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-06 Thread jimmy
Hi Josh, I couldn't do much with Stygmorgan and a few styles I wanted to try, using Qsynth/FluidSynth. As a side note, Timidity gives me some wicked distortion/noise on some fast notes and synth-instruments. FluidSynth handles it well with no distortion that I can tell. So I tried the folowing

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-03 Thread jimmy
Hi Josh, I think I can build from subversion when that is available. Much appreciated. Jimmy --- Josh Green <[EMAIL PROTECTED]> wrote: > Hello Jimmy, > > Seems reasonable to me to use the last selected > instrument when an > invalid bank and/or program change is received. > I've added it

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-03 Thread Josh Green
Hello Jimmy, Seems reasonable to me to use the last selected instrument when an invalid bank and/or program change is received. I've added it as ticket #8: http://fluidsynth.resonance.org/trac/ticket/8 I'll try and get to this sometime soon, so that you can take advantage of its benefits. Hopef

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-03 Thread jimmy
Thanks for the soundfont pointers, I'll try those soundfonts. I still think FluidSynth should "ignores invalid request" rather than void the channel. Imagine a hardware sound-module, or any hardware midi-connected keyboard that would silent the channel because you punch in an instrument number th

Re: [fluid-dev] invalid instrument/drum selection problem

2008-01-03 Thread Julien Claassen
Hi! I suppose timidity just should be your choice for simply playing midi-files. Fluidsynth (and thus qsynth) can play midi-files, but I always felt that fluidsynth's main-gola was to play sounds yourself and record them or use them during performance. But you could use a complete midi-sound

[fluid-dev] invalid instrument/drum selection problem

2008-01-02 Thread jimmy
Hi, My problem is there are times that an instrument, or drumset selection got changed and FludSynth just voided that channel (no instrument loaded for the channel). I assume no instrument/drum recognized, or a drumset/soundbank has no corresponing instrument in the loaded soundfonts. With Timi