> The code has been working this way all along, no behavior changes regarding
> FS handling of GM-mode bank select in anyway, with or without that comment.
>
> I will leave that part of the comment back in there.
>
OK cool. What I meant was, if a comment says "this might need to be fixed"
and you
--- On Thu, 1/27/11, Matt Giuca wrote:
> Yeah, but the comment was about bank selection (and that it
> was hard-coded to channel 10, or 9 if counting from 0).
> Given that your patch no longer hard-codes channel 10, how
> does it handle bank selection for drum channels?
My patch does away with
On Thu, Jan 27, 2011 at 5:28 PM, jimmy wrote:
> Anyone deals with any funky GS drum stuff, which these new changes may
> affect? We will need your help to test your GS stuff (to make sure they
> aren't broken) if these new changes made it into FluidSynth.
My foo_midi component deals with GS dr
--- On Wed, 1/26/11, Matt Giuca wrote:
> I didn't mean to suggest you shouldn't be using
> fluid-dev. I was just disclaiming that when you read my
> reply, you shouldn't consider it to be representative of
> the opinion of the FS devs (for example, just because I like
> it does not mean it will
> On Wed, 26 Jan 2011 23:41:19 -0800 Chris Moeller wrote:
>
> Further to this, I propose a change to the bank number
> handling. While I
> already saw some changes under way to use MSB or LSB or
> both depending
> on the MIDI standard, I think it's better to combine the
> approach.
>
> [snippe
> I mean that the (channel==9) has been the hard-coded hack at the time, and
> is now replaced by the new hack "is_drum_channel" field. At initialization,
> the new code still hard-code a 9, but not anywhere else as they were
> previously.
>
Yeah, but the comment was about bank selection (and tha
Blah, I meant SGM, not SGP.
___
fluid-dev mailing list
fluid-dev@nongnu.org
http://lists.nongnu.org/mailman/listinfo/fluid-dev
Further to this, I propose a change to the bank number handling. While I
already saw some changes under way to use MSB or LSB or both depending
on the MIDI standard, I think it's better to combine the approach.
Since SoundFont hardware devices expect the bank change commands to only
be in the
> I'm not a FS dev either. Just seeing something I may want to use isn't
> there, so I just take a crack at it. Everyone on this [fluid-dev] list is
> one way or another interested in the coding/development side of FS one way
> or another. That's why I ask for opinions instead of contacting just
> On Wed, 26 Jan 2011 22:01:45 +0800 yanli lei wrote:
>
> I wonder when can this changes be commit into the next
> stable release? I
> have a SF2 soundset with the Studio Drum sounds so much
> realistic than the
> hardcode one. Do let me know so the students can enjoy it.
Yanli,
Unless you want
--- On Tue, 1/25/11, Matt Giuca wrote:
> Hi Jimmy,
>
> I am not a FluidSynth developer, just an interested person,
> so my opinions don't represent the view of the
> FluidSynth project.
>
> This seems like a valuable generalisation of a previously
> hard-coded value. Given that your new flag w
I wonder when can this changes be commit into the next stable release? I
have a SF2 soundset with the Studio Drum sounds so much realistic than the
hardcode one. Do let me know so the students can enjoy it.
On Wed, Jan 26, 2011 at 7:48 PM, David Henningsson wrote:
> On 2011-01-26 00:25, jimmy wr
On 2011-01-26 00:25, jimmy wrote:
GOAL FOR THIS PATCH:
This patch would allow the flexibility to set any individual channel to be drum
channel, and/or unset them (revert back to melodic channel).
Nice to see some work with this. I agree roughly with M
Hi Jimmy,
I am not a FluidSynth developer, just an interested person, so my opinions
don't represent the view of the FluidSynth project.
This seems like a valuable generalisation of a previously hard-coded value.
Given that your new flag will default to 0 for all channels and 1 for
channel 9, it
GOAL FOR THIS PATCH:
This patch would allow the flexibility to set any individual channel to be drum
channel, and/or unset them (revert back to melodic channel).
Add a flag to struct:
_fluid_channel_t
to indicate it is a drum channel, using int ty
15 matches
Mail list logo
