Re: [fluid-dev] Patch for fast midi file rendering

2009-04-25 Thread Josh Green
On Sat, 2009-04-25 at 23:04 +0200, David Henningsson wrote: > Josh Green skrev: > > On Mon, 2009-04-20 at 22:08 +0200, David Henningsson wrote: > >>> I like the use of '-' to indicate stdout. That is common to many > >>> applications and would save the user from accidentally getting a > >>> termin

Re: [fluid-dev] Patch for fast midi file rendering

2009-04-25 Thread David Henningsson
Josh Green skrev: > On Mon, 2009-04-20 at 22:08 +0200, David Henningsson wrote: >>> I like the use of '-' to indicate stdout. That is common to many >>> applications and would save the user from accidentally getting a >>> terminal full of seemingly endless junk. >> Seems like a good idea. Hopefull

Re: [fluid-dev] Patch for fast midi file rendering

2009-04-23 Thread Josh Green
On Mon, 2009-04-20 at 22:08 +0200, David Henningsson wrote: > Josh Green skrev: > > I agree that render fits the function of what FluidSynth is doing > > (rendering SoundFont instruments and MIDI files to audio). I'd just as > > well do away with the file writer driver, since I don't see a need fo

Re: [fluid-dev] Patch for fast midi file rendering

2009-04-20 Thread David Henningsson
Josh Green skrev: > I agree that render fits the function of what FluidSynth is doing > (rendering SoundFont instruments and MIDI files to audio). I'd just as > well do away with the file writer driver, since I don't see a need for > live file writing using FluidSynth directly (since you would lik

Re: [fluid-dev] Patch for fast midi file rendering

2009-04-19 Thread Josh Green
On Sun, 2009-03-22 at 06:46 +0100, David Henningsson wrote: > > * fluid_renderer* is another bad name. It is not rendering anything, in the > > sense of translation, like the verb used in "rendering SVG into bitmap > > graphics". The proposed functions are only audio file helpers, because you >

Re: [fluid-dev] Patch for fast midi file rendering

2009-03-22 Thread Antoine Schmitt
Le 22 mars 09 à 06:46, David Henningsson a écrit : But if you ask me; I think the system timers in the player/sequencer should be skipped altogether and then no parameter would be needed at all. Especially if the system timer solution has concurrency problems...? I totally agree. There is

Re: [fluid-dev] Patch for fast midi file rendering

2009-03-21 Thread David Henningsson
Pedro Lopez-Cabanillas skrev: > Hi, > > I've not yet said so in appreciation of all the work you have done, and it > must be shout: Thank you very much! :-) You're welcome :-) And to give some praise back - I think the existing code is well written and easy to understand. (Actually the only thi

Re: [fluid-dev] Patch for fast midi file rendering

2009-03-21 Thread Pedro Lopez-Cabanillas
Hi, I've not yet said so in appreciation of all the work you have done, and it must be shout: Thank you very much! :-) About the patch: I want to commit it after the 1.0.9 release, because it has several ramifications that need to be developed further, and it has enough importance to deserve

Re: [fluid-dev] Patch for fast midi file rendering

2009-03-21 Thread Pedro Lopez-Cabanillas
David Henningsson wrote: > Strange, it works here (gcc (Ubuntu 4.3.2-1ubuntu12) 4.3.2). > Nevertheless, here's a patch that should build on both versions. Yes, this time your patch compiles without error messages. The explanation for the compiler error is: fluidsynth.c is a client, it has only a

Re: [fluid-dev] Patch for fast midi file rendering

2009-03-18 Thread David Henningsson
Strange, it works here (gcc (Ubuntu 4.3.2-1ubuntu12) 4.3.2). Nevertheless, here's a patch that should build on both versions. // David Pedro Lopez-Cabanillas skrev: > David Henningsson wrote: >> Enough said - now go enjoy the new patch! > > Sorry, but: > > fluidsynth.c: In function ‘fast_rende

Re: [fluid-dev] Patch for fast midi file rendering

2009-03-18 Thread Pedro Lopez-Cabanillas
David Henningsson wrote: > Enough said - now go enjoy the new patch! Sorry, but: fluidsynth.c: In function ‘fast_render_loop’: fluidsynth.c:185: error: dereferencing pointer to incomplete type fluidsynth.c:186: error: dereferencing pointer to incomplete type make[2]: *** [fluidsynth-fluidsynth.o]

[fluid-dev] Patch for fast midi file rendering

2009-03-18 Thread David Henningsson
Okay, so here's the patch that enables fast, predictable MIDI file rendering. Whether it goes into 1.0.9 or 1.1.0 is up to you, but I do hope that someone will commit it - so I haven't been working in vain! Notes about the patch: * It includes the previous posted patch for slave timers, and this