Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-23 Thread Tom M. via fluid-dev
Confirmed. ___ fluid-dev mailing list fluid-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/fluid-dev

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-23 Thread Ceresa Jean-Jacques
> [Tom] When changing the existing command and un-deprecate them, we'll only > have two. While still retaining backward compatibility.   So to maintain compatibility with actual command shell, I would like confirmation for the suggested behaviour: 1) we un-deprecate the commands. 2) make thes

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-20 Thread Marcus Weseloh
Am Di., 20. Okt. 2020 um 17:49 Uhr schrieb Tom M. via fluid-dev : > Pls. what has changed your mind to "introduce the proposed new [shell] > commands"? > > With your suggestion, we would have three different ways of setting > reverb+chorus. When changing the existing command and un-deprecate > them

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-20 Thread Tom M. via fluid-dev
Marcus, wait - remember: >> [Tom] However, I vote against introducing new shell commands. Instead, the >> existing commands, should become smart enough to detect whether they >> have been called with one or two parameters. > [Marcus] Good idea! [...] Pls. what has changed your mind to "introduce

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-20 Thread Ceresa Jean-Jacques
Hi,   >So for the shell we introduce the proposed new commands to set specific fx >group settings. >We keep the old fx shell commands deprecated and document that "set >synth.reverb.xxx" should be used instead (if not already done). >And for the API we use the function names suggested above a

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-20 Thread Marcus Weseloh
Hi, Am So., 18. Okt. 2020 um 17:41 Uhr schrieb Tom M. via fluid-dev : > I kept thinking about this. If we decide against the "2"-suffix my > current favorite is: > > fluid_synth_set_reverb_group_x() > fluid_synth_set_chrous_group_x() > > This would be consistent with the synth.effects-grou

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-18 Thread Ceresa Jean-Jacques
>my current favorite is:fluid_synth_set_reverb_group_x() >fluid_synth_set_chrous_group_x() >This would be consistent with the synth.effects-groups setting.   Indeed, replacing "fx" by "group" seems a better naming choice. jjc     ___ fluid-

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-18 Thread Tom M. via fluid-dev
> The reason is that those actual shell fx commands are redundant with > respective settings (synth.reverb., synth.chorus.).> Instead, the > user can use the commands: set synth.reverb., set > synth.chorus. which set the respective setting for all fx unit. Those JJC is correct. >

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-14 Thread Ceresa Jean-Jacques
>Tom: Side note: those existing shell commands have already been deprecated. >Ofc. this should be reverted once this feature will be implemented. >Marcus Ah, I wasn't aware of that. What was the reason for deprecating those >shell commands? The reason is that those actual shell fx commands are r

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-11 Thread Marcus Weseloh
Am So., 11. Okt. 2020 um 14:29 Uhr schrieb Tom M. via fluid-dev : > > The proposed new API functions simply add a "2" to all names. > That was my proposal. I find it hard to find a suitable naming > convention for those new functions. Yes, I completely understand. And I had forgotten (or overlooke

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-11 Thread Tom M. via fluid-dev
> My guess is that most users simply use a single stereo output from FluidSynth. Probably. And I must admit that I'm still not convinced that it makes sense from a musically perspective to control all effects groups independently. However, I understand the technical need for it, so I'll buy it. [T

Re: [fluid-dev] New Reverb and Chorus API versus actual API

2020-10-11 Thread Marcus Weseloh
Hi JJC, Am Do., 17. Sept. 2020 um 11:52 Uhr schrieb Ceresa Jean-Jacques : > To overcome this issue a new set of Revert and Chorus API will be proposed > with one added parameter which is the fx unit index (0 or 1) > to which the change is applied. This new API set can also behave like actual > A

[fluid-dev] New Reverb and Chorus API versus actual API

2020-09-17 Thread Ceresa Jean-Jacques
Hi All,   For those amoung you using actual Reverb and Chorus API (or associated shell commands). You have noticed that theses API (or commands) allow to change one parameter for all fx unit. For example if fluidsynth has been started with synth.effects-groups set to 2, the synthesizer has 2