Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-06 Thread Rui Nuno Capela
On 12/06/2009 09:00 PM, j...@resonance.org wrote: > Quoting Rui Nuno Capela : >> >> ok. the instrument/channel issue may be left as is or to some other >> occasion and debate. i can live with it, pretty well ;) >> >> what really matters now, at least imho, are these 2 issues: 1) >> bank-offsets non

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-06 Thread josh
Quoting Rui Nuno Capela : ok. the instrument/channel issue may be left as is or to some other occasion and debate. i can live with it, pretty well ;) what really matters now, at least imho, are these 2 issues: 1) bank-offsets non-operative on soundfont load/initialization and 2) fluid_synth_pro

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-06 Thread Rui Nuno Capela
On 12/05/2009 03:32 AM, j...@resonance.org wrote: > Quoting Rui Nuno Capela : >> please note that the issue does not affect GM soundfonts, which certainly >> have way more instruments defined than synth number of channels. my >> question is exactly about those non-GM/GM2/GS soundfonts that have >>

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-05 Thread David Henningsson
Rui Nuno Capela wrote: Yes, previous FluidSynth versions assigned incremental program numbers to each channel. Starting with 1.1.0, the default bank/program numbers are 1/1 to be compatible with the MIDI GM standard. This probably isn't going to be changed back to the old way, since there

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-04 Thread josh
Quoting Rui Nuno Capela : please note that the issue does not affect GM soundfonts, which certainly have way more instruments defined than synth number of channels. my question is exactly about those non-GM/GM2/GS soundfonts that have only one or a couple of instrument presets defined. as it happ

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-04 Thread Rui Nuno Capela
On Thu, 03 Dec 2009 17:44:50 -0800, j...@resonance.org wrote: > Quoting Rui Nuno Capela : >> On 12/03/2009 10:21 AM, Rui Nuno Capela wrote: >>> On Fri, 27 Nov 2009 15:30:32 -0800, j...@resonance.org wrote: I committed some changes which adds a new function fluid_synth_unset_program()

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-03 Thread josh
Quoting Rui Nuno Capela : - fluid_synth_program_reset() seems to disregard all previous calls to fluid_synth_unset_program(), reassigning the default/initial bank and program setting to any explicitly unassigned channels. What sort of behavior would you expect in response to MIDI bank and p

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-03 Thread josh
Quoting Rui Nuno Capela : On 12/03/2009 10:21 AM, Rui Nuno Capela wrote: On Fri, 27 Nov 2009 15:30:32 -0800, j...@resonance.org wrote: I committed some changes which adds a new function fluid_synth_unset_program() and finalizes API for fluid_synth_get_channel_info(). With the other changes

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-03 Thread josh
Hey Rui, No problem about the delayed responses. Do let us know if you see any other issues or have any other feature requests for a future release. Cheers! Josh Quoting Rui Nuno Capela : On Fri, 27 Nov 2009 15:30:32 -0800, j...@resonance.org wrote: Hello Rui, I committed some changes

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-03 Thread Rui Nuno Capela
On 12/03/2009 10:21 AM, Rui Nuno Capela wrote: > On Fri, 27 Nov 2009 15:30:32 -0800, j...@resonance.org wrote: >> >> I committed some changes which adds a new function >> fluid_synth_unset_program() and finalizes API for >> fluid_synth_get_channel_info(). >> >> >> >> With the other changes I j

Re: [fluid-dev] More commits on the way to 1.1.1

2009-12-03 Thread Rui Nuno Capela
On Fri, 27 Nov 2009 15:30:32 -0800, j...@resonance.org wrote: > Hello Rui, > > I committed some changes which adds a new function > fluid_synth_unset_program() and finalizes API for > fluid_synth_get_channel_info(). > > Attached is a patch against qsynth 0.3.4 which adds support for the > n

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-27 Thread josh
Hello Rui, I committed some changes which adds a new function fluid_synth_unset_program() and finalizes API for fluid_synth_get_channel_info(). Attached is a patch against qsynth 0.3.4 which adds support for the new fluid_synth_get_channel_info() for thread safety. It also supports old

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-17 Thread josh
Quoting Graham Goode : Josh, Just a quick work of thanks for all the work that you (and all the other guys) have done and are doing on fluidysynth. While the 1.1.0 release might have revealed some issues resulting from the thread safety work, it is also a major step forward. Having release candid

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-17 Thread Pedro Lopez-Cabanillas
On Tuesday, November 17, 2009, Rui Nuno Capela wrote: > On Tue, 17 Nov 2009 00:30:56 +0100, Pedro Lopez-Cabanillas > > On Monday, November 16, 2009, Rui Nuno Capela wrote: > >> iirc, there were some requests on this regard from time to time, that is > >> a way to set one channel silent, unassigned,

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-17 Thread Pedro Lopez-Cabanillas
On Tuesday, November 17, 2009, j...@resonance.org wrote: > Quoting Pedro Lopez-Cabanillas : > >> well, it's been a _long_ time missing function. if one can assign one > >> channel preset, why can't the same be reset unassigned, just for > >> closure, functional completeness sake? > >> > >> iirc, th

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-17 Thread Graham Goode
Josh, Just a quick work of thanks for all the work that you (and all the other guys) have done and are doing on fluidysynth. While the 1.1.0 release might have revealed some issues resulting from the thread safety work, it is also a major step forward. Having release candidate versions for the futu

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-17 Thread josh
Quoting Rui Nuno Capela : On Tue, 17 Nov 2009 00:30:56 +0100, Pedro Lopez-Cabanillas wrote: On Monday, November 16, 2009, Rui Nuno Capela wrote: On Mon, 16 Nov 2009 00:46:43 -0800, j...@resonance.org wrote: >> keep, force or (re)set one channel preset as unassigned ? > > No it doesn't seem the

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-17 Thread josh
Just committed some more changes. I think I resolved the return event queue issue. Its now just a fluid_thread_t which uses a condition to get signaled when events are available. fluid_synth_one_block() will signal the condition if there are any pending events in the return queue. It doe

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-17 Thread Rui Nuno Capela
On Tue, 17 Nov 2009 00:30:56 +0100, Pedro Lopez-Cabanillas wrote: > On Monday, November 16, 2009, Rui Nuno Capela wrote: >> On Mon, 16 Nov 2009 00:46:43 -0800, j...@resonance.org wrote: >> >> keep, force or (re)set one channel preset as unassigned ? >> > >> > No it doesn't seem there is a way to s

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread Corbin Simpson
Anything that improves performance on smaller devices is a win for me. Posting from a mobile, pardon my terseness. ~ C. On Nov 16, 2009 6:41 PM, wrote: Quoting Pedro Lopez-Cabanillas : >> >> well, it's been a _long_ ti... Good point. Couldn't mute be accomplished by simply setting the volume M

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread josh
Quoting Pedro Lopez-Cabanillas : well, it's been a _long_ time missing function. if one can assign one channel preset, why can't the same be reset unassigned, just for closure, functional completeness sake? iirc, there were some requests on this regard from time to time, that is, a way to set on

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread Pedro Lopez-Cabanillas
On Monday, November 16, 2009, Rui Nuno Capela wrote: > On Mon, 16 Nov 2009 00:46:43 -0800, j...@resonance.org wrote: > >> keep, force or (re)set one channel preset as unassigned ? > > > > No it doesn't seem there is a way to set a single channel to > > unassigned with the public API. There is a pr

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread josh
Quoting David Henningsson : j...@resonance.org wrote: Quoting Rui Nuno Capela : We always have a chance :) Sure I can add it. How about something like: int fluid_synth_program_clear (fluid_synth_t *synth, int chan); Something to note though, is that it will keep its sfont ID, bank and p

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread David Henningsson
j...@resonance.org wrote: Quoting Rui Nuno Capela : We always have a chance :) Sure I can add it. How about something like: int fluid_synth_program_clear (fluid_synth_t *synth, int chan); Something to note though, is that it will keep its sfont ID, bank and program numbers. Why can't we

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread josh
Quoting Rui Nuno Capela : No it doesn't seem there is a way to set a single channel to unassigned with the public API. There is a private function called fluid_synth_set_preset, which could be used to set the preset to NULL, which would have the effect of setting it to unassigned, but that isn't

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread Rui Nuno Capela
On Mon, 16 Nov 2009 00:46:43 -0800, j...@resonance.org wrote: > Quoting Rui Nuno Capela : >>> int fluid_synth_get_channel_preset_info >>> (fluid_synth_t *synth, int chan, fluid_preset_info_t *info); >>> >> >> looks good enough. >> > > I have a patch against QSynth 0.3.4 which adds support for the

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread josh
Quoting Rui Nuno Capela : int fluid_synth_get_channel_preset_info (fluid_synth_t *synth, int chan, fluid_preset_info_t *info); looks good enough. I have a patch against QSynth 0.3.4 which adds support for the new API with backwards compatibility with older versions. I'll send it your w

Re: [fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread Rui Nuno Capela
On Mon, 16 Nov 2009 00:04:17 -0800, j...@resonance.org wrote: > I just committed code to make preset querying use the most recent > assigned preset. I also added the code below to the public API as per > previous discussions. > > I'm not completely happy with the new API though, since it does

[fluid-dev] More commits on the way to 1.1.1

2009-11-16 Thread josh
I just committed code to make preset querying use the most recent assigned preset. I also added the code below to the public API as per previous discussions. I'm not completely happy with the new API though, since it does seem really close to fluid_synth_get_program() in functionality and