Re: [fluid-dev] Fix for problem with CC changes to Bank MSB

2009-04-19 Thread Josh Green
On Sun, 2009-04-05 at 00:07 +1100, D.Bartolec wrote: > > I've discovered it after playing some MIDI files that would send bank > LSB:0 for drum channel without sending bank MSB at all. > This would cause drum tracks to change to MSB:0 LSB:0. > Here is the fix: > Its likely those MIDI files ar

Re: [fluid-dev] Fix for problem with CC changes to Bank MSB

2009-04-19 Thread Josh Green
On Sun, 2009-04-05 at 08:08 +0200, David Henningsson wrote: > D.Bartolec skrev: > > I've discovered it after playing some MIDI files that would send bank LSB:0 > > for drum channel without sending bank MSB at all. > > This would cause drum tracks to change to MSB:0 LSB:0. > > I've taken a quick

Re: [fluid-dev] Fix for problem with CC changes to Bank MSB

2009-04-04 Thread D.Bartolec
David, You are right this part of my fix show here: + if ( (chan == 9) && (bank_msb == 0)) + { + bank_msb = 1; /* Ignore CC value and set the default MSB value for drum channel */ + } is not necessary and yes it will prevent from other instruments being assigned to drum channel. I put

Re: [fluid-dev] Fix for problem with CC changes to Bank MSB

2009-04-04 Thread David Henningsson
D.Bartolec skrev: > I've discovered it after playing some MIDI files that would send bank LSB:0 > for drum channel without sending bank MSB at all. > This would cause drum tracks to change to MSB:0 LSB:0. I've taken a quick look at your patch now and I have a question: > + if ( (chan == 9) &&

[fluid-dev] Fix for problem with CC changes to Bank MSB

2009-04-04 Thread D.Bartolec
I've discovered it after playing some MIDI files that would send bank LSB:0 for drum channel without sending bank MSB at all. This would cause drum tracks to change to MSB:0 LSB:0. Here is the fix: Index: src/fluid_chan.c === ---