Re: [fluid-dev] Enable/disable logging at configure time

2017-10-29 Thread Carlo Bramini
Hello, I also noticed that, about this aspect, there are some other interesting poins: - dithering: there is a rand_table[][] inside fluid_synth.c, that it is 384KB of static memory. if somebody would like to recover some space, this may be a good tip. - In fluid_conv.c there are these tables:

Re: [fluid-dev] Enable/disable logging at configure time

2017-10-29 Thread Marcus Weseloh
Hi Carlo, 2017-10-29 11:58 GMT+01:00 Carlo Bramini : > It saves some memory if someone wants (about 12KB on an ARM Thumb2 > microcontroller) and it would be selectable by the user (logging will be > activated by default). > Unrelated to your change request and you probably have seen it already.

Re: [fluid-dev] Enable/disable logging at configure time

2017-10-29 Thread Tom M.
Every implementation is free to override any part of fluid_sys.h and fluidsynth_priv.h; introducing a cmake option for this minor change might be an overkill. If you still think a cmake option is the best way to go it should also make sure that this fluid_log* stuff in fluid_sys.c does not get comp

[fluid-dev] Enable/disable logging at configure time

2017-10-29 Thread Carlo Bramini
Hello, I would like to suggest the addition of an option "disable-logging" in the cmake script, that will allow the user to de-activate the log prints. In the code, this just means a change like this into fluidsynth_priv.h: #ifdef DISABLE_FLUID_LOG #define FLUID_LOG #else #define FLUID_LOGfl