Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-21 Thread Tom M. via fluid-dev
Thanks to all of you for your input. FYI, a PR for this issue is now available: https://github.com/FluidSynth/fluidsynth/pull/629 Tom ___ fluid-dev mailing list fluid-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/fluid-dev

Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-19 Thread Carlo Bramini via fluid-dev
Hello! > There is no guarantee that sf->sffd is a FILE* . Again, this is exposed via > our API. sf->sffd is a void*, which could be some user defined handle, which, > when passing to fseek(), would result in an access violation and in a > horrible, possibly-hard-to-reproduce crash of the entire

Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-17 Thread Dan Eble
On Mar 17, 2020, at 04:44, Tom M. via fluid-dev wrote: > latter doesn't really make sense in practice, because long long is an > intrinsic type guaranteed to be at least 64 bits wide. And because > long long must be available, int64_t will also be available.) That describes int_least64_t. In an

Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-17 Thread Ceresa Jean-Jacques
00;     //  -9223372036854775808 jjc         > Message du 17/03/20 09:45 > De : "Tom M. via fluid-dev" > A : "FluidSynth mailing list" > Copie à : "Tom M." > Objet : Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows > > > If you

Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-17 Thread Tom M. via fluid-dev
There is no guarantee that sf->sffd is a FILE* . Again, this is exposed via our API. sf->sffd is a void*, which could be some user defined handle, which, when passing to fseek(), would result in an access violation and in a horrible, possibly-hard-to-reproduce crash of the entire application. I

Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-17 Thread Carlo Bramini via fluid-dev
Hello, although it is true that you cannot handle files larger than 2GB with current code, there is one thing that's strange in that bug report. If you really have not large file support, the first function to fail should be fseek() and not ftell(), so the first message you should read in the co

Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-17 Thread Tom M. via fluid-dev
> If you decided to require C99, I would think you would want to use int64_t > and its relatives for portability. I actually had "long long" in mind, because int64_t would require fluidsynth's header to include stdint.h, and whenever possible I would like to avoid polluting our header with any C

Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-16 Thread Reinhold Hoffmann
-Ursprüngliche Nachricht- Von: fluid-dev [mailto:fluid-dev-bounces+reinhold=notation@nongnu.org] Im Auftrag von Dan Eble Gesendet: Montag, 16. März 2020 23:24 An: FluidSynth mailing list Cc: Tom M. Betreff: Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows On Mar 16, 2020, at 09:57

Re: [fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-16 Thread Dan Eble
On Mar 16, 2020, at 09:57, Tom M. via fluid-dev wrote: > The current workaround is to build fluidsynth with CygWin, which has "long" > set to 64bit. > > Any ideas how to solve this? Opinions on C99? If you decided to require C99, I would think you would want to use int64_t and its relatives fo

[fluid-dev] About Supporting 2GiB+ Soundfonts on Windows

2020-03-16 Thread Tom M. via fluid-dev
We have a bug report on GitHub [1]: A user reports that loading Soundfonts >2GiB fails on Win10 64bit. There are two factors making up the root cause: 1. The ANSI C file API, namely ftell() and fseek(), use "long" as data type for specifying offsets in the file. 2. Even on 64bit Windows, "long"