On Mon, 17 Sep 2007 17:46:34 -0700
Josh Green <[EMAIL PROTECTED]> wrote:
> The idea with that patch was to make the chorus volume more uniform over
> changes in the number of chorus stages, correct? If that factor could
> be pre-calculated into the other parameters when the chorus count
> changes
On Mon, 17 Sep 2007 17:46:34 -0700
Josh Green <[EMAIL PROTECTED]> wrote:
> Looking at the current code though, I'm also seeing that the chorus->level
> parameter is never actually used (seems this parameter is broken too?).
For evaluating the original effect code, it might make more sense to lo
On Mon, 2007-09-17 at 19:29 -0500, David Hilvert wrote:
> On Mon, 17 Sep 2007 15:51:09 -0700
> Josh Green <[EMAIL PROTECTED]> wrote:
>
> > I think the wet parameter is related to how much of the "wet" reverb
> > signal is being mixed into the output.
>
> Yes. Renaming it as something else woul
On Mon, 17 Sep 2007 15:51:09 -0700
Josh Green <[EMAIL PROTECTED]> wrote:
> I think the wet parameter is related to how much of the "wet" reverb
> signal is being mixed into the output.
Yes. Renaming it as something else would probably be silly; I was being (at
least) temporarily stupid.
> Mos
On Mon, 2007-09-17 at 17:42 -0500, David Hilvert wrote:
> On Mon, 17 Sep 2007 13:09:07 -0700
> Josh Green <[EMAIL PROTECTED]> wrote:
>
> > return rev->wet / scalewet;
> >
> > Probably could even remove the rev->level field at that point. This
> > seems like the right way to do things. Anyone go
On Mon, 17 Sep 2007 13:09:07 -0700
Josh Green <[EMAIL PROTECTED]> wrote:
> return rev->wet / scalewet;
>
> Probably could even remove the rev->level field at that point. This
> seems like the right way to do things. Anyone got any objections or
> comments on this?
If the 'wet' code is uncommen
David Hilvert wrote:
> On Mon, 17 Sep 2007 21:06:36 +0100
> Rui Nuno Capela <[EMAIL PROTECTED]> wrote:
>
>> diff -dupr fluidsynth-1.0.7a.0/src/fluid_rev.c
>> fluidsynth-1.0.7a.1/src/fluid_rev.c
>> --- fluidsynth-1.0.7a.0/src/fluid_rev.c 2004-03-29 11:05:18.0
>> +0100
>> +++ fluidsyn
Dropped the list ...
Begin forwarded message:
Date: Mon, 17 Sep 2007 16:11:47 -0500
From: David Hilvert <[EMAIL PROTECTED]>
To: Josh Green <[EMAIL PROTECTED]>
Subject: Re: [fluid-dev] [PATCH] Effect level clip
On Mon, 17 Sep 2007 11:33:39 -0700
Josh Green <[EMAIL PROTECTED]>
Josh Green wrote:
> Hello David,
>
> On Mon, 2007-09-17 at 04:48 -0500, David Hilvert wrote:
>> On Mon, 17 Sep 2007 00:43:30 -0700
>> Josh Green <[EMAIL PROTECTED]> wrote:
>>
>>> I think I need to get a better idea of how your patch is helping to keep
>>> Reverb and Chorus at a more constant outpu
Dropped the list (again):
Begin forwarded message:
Date: Mon, 17 Sep 2007 16:28:25 -0500
From: David Hilvert <[EMAIL PROTECTED]>
To: Rui Nuno Capela <[EMAIL PROTECTED]>
Subject: Re: [fluid-dev] [PATCH] Effect level clip
On Mon, 17 Sep 2007 21:06:36 +0100
Rui Nuno Capela <[
On Mon, 2007-09-17 at 21:06 +0100, Rui Nuno Capela wrote:
> this is in fact one of my proposed patches (attached once again).
>
> without this one qsynth reverb level is stuck to 100%, surely everyone
> has this for granted ;)
>
> i remember it was argued by Peter himself during 1.0.4 release iir
Hello David,
On Mon, 2007-09-17 at 04:48 -0500, David Hilvert wrote:
> On Mon, 17 Sep 2007 00:43:30 -0700
> Josh Green <[EMAIL PROTECTED]> wrote:
>
> > I think I need to get a better idea of how your patch is helping to keep
> > Reverb and Chorus at a more constant output level, regardless of the
On Mon, 17 Sep 2007 00:43:30 -0700
Josh Green <[EMAIL PROTECTED]> wrote:
> I think I need to get a better idea of how your patch is helping to keep
> Reverb and Chorus at a more constant output level, regardless of the
> synth.gain setting.
If I recall correctly, effective gain was split in 1.0.7
Hello David,
This patch also doesn't seem right, although I admit I'm not yet fully
informed on the Reverb/Chorus settings within FluidSynth. Perhaps you
could describe what you are trying to accomplish with the Reverb and
Chorus level per voice updating, since that is something I did not
underst
On Sun, 02 Sep 2007 20:40:35 -0700
Josh Green <[EMAIL PROTECTED]> wrote:
> I was hoping you might be able to comment on why the calls to
> fluid_voice_set_param occurs within the fluid_synth_one_block() function
> (in other words, it gets assigned every 64 output samples for each
> voice, whether
Hello David,
I was noticing a section of code in your effect level clip patch which
is causing about a 1% or so decrease in performance. Here is the code
in question:
diff -ubr fluidsynth-1.0.7/src/fluid_synth.c
fluidsynth-modified/src/fluid_synth.c
--- fluidsynth-1.0.7/src/fluid_synth.c 2006-
Hello David,
Thank you for the patch. It addresses a problem that has been bothering
me for some time (the increase of volume with Chorus and Reverb
effects). Sounds great too :) I had realized that Chorus and Reverb
effects had a tendency to make things sound really bad, mainly because
of digi
Overview
The following patch moves effect level adjustments prior to the send clip, and
reduces the chorus effect linearly with the number of voices. These changes
seem to make output (volume) levels more uniform; in particular, the phenomenon
of certain instruments with high choral component bei
18 matches
Mail list logo
