Re: [fluid-dev] Some guidelines for FluidSynth development

2009-04-27 Thread David Henningsson
j...@resonance.org skrev: > Doxygen comments should be put in the .c source files above the > definition which they describe, not in the headers. A TODO item is to > move the existing documentation into the C code. What about the public API? I assume we would have one doxygen target for the publ

Re: [fluid-dev] More commits

2009-04-27 Thread David Henningsson
j...@resonance.org skrev: > Its funny how accustomed one becomes to a certain coding style. I could > probably manage with that style, but to me it looks a little messy > (could be just because of what I'm used to though). The space before > and after parenthesis in particular looks confusing. I

Re: [fluid-dev] More commits

2009-04-27 Thread josh
Quoting Pedro Lopez-Cabanillas : On Monday, April 27, 2009, j...@resonance.org wrote: I know coding style is a rather personal matter, but it would be good to agree on it to some extent ;) - Function return value on its own line - Indent by 2 spaces - Braces on new lines - Spaces before open p

Re: [fluid-dev] Some guidelines for FluidSynth development

2009-04-27 Thread josh
Quoting Pedro Lopez-Cabanillas : On Monday, April 27, 2009, j...@resonance.org wrote: Looking at the recent commits, I thought it would be good to mention some general guidelines. Please make use of the ChangeLog. Change details don't have to be incredibly detailed and in fact more general des

Re: [fluid-dev] More commits

2009-04-27 Thread Pedro Lopez-Cabanillas
On Monday, April 27, 2009, j...@resonance.org wrote: > I know coding style is a rather personal matter, but it would be good > to agree on it to some extent ;) > > - Function return value on its own line > - Indent by 2 spaces > - Braces on new lines > - Spaces before open parenthesis '(' > - Space

Re: [fluid-dev] Some guidelines for FluidSynth development

2009-04-27 Thread Pedro Lopez-Cabanillas
On Monday, April 27, 2009, j...@resonance.org wrote: > Looking at the recent commits, I thought it would be good to mention > some general guidelines. > > Please make use of the ChangeLog. Change details don't have to be > incredibly detailed and in fact more general descriptions are better, > sin

[fluid-dev] More commits

2009-04-27 Thread josh
It looks like the fluid_filerenderer.c code was replicated 2 times in the same file (some sort of paste error perhaps?) I removed the duplicates and took the opportunity to move the API docs to the .c file and add "API: 1.1.0" to them. I'm starting to get a little annoyed by the coding sty

Re: [fluid-dev] Documentation

2009-04-27 Thread josh
Quoting Pedro Lopez-Cabanillas : On Monday, April 27, 2009, j...@resonance.org wrote: Ohh, and we can of course host it on http://fluidsynth.resonance.org too. How does the document get built? I'm sure I should probably know that, but.. ;) Josh First, change to the doc/ subdir $ cd f

[fluid-dev] Some guidelines for FluidSynth development

2009-04-27 Thread josh
Looking at the recent commits, I thought it would be good to mention some general guidelines. Please make use of the ChangeLog. Change details don't have to be incredibly detailed and in fact more general descriptions are better, since the details are in the code itself. Doxygen comments

Re: [fluid-dev] Documentation

2009-04-27 Thread Pedro Lopez-Cabanillas
On Monday, April 27, 2009, j...@resonance.org wrote: > Ohh, and we can of course host it on http://fluidsynth.resonance.org > too. How does the document get built? I'm sure I should probably > know that, but.. ;) > > Josh First, change to the doc/ subdir $ cd fluidsynth/doc and: $ doxyge

Re: [fluid-dev] glib changes checked in

2009-04-27 Thread josh
Quoting Pedro Lopez-Cabanillas : On Monday, April 27, 2009, you wrote: Quoting Pedro Lopez-Cabanillas : > On Monday, April 27, 2009, j...@resonance.org wrote: >> I just checked in some initial changes which make glib 2.10+ a > > Really you did it? :) > > Regards, > Pedro Yes yes indeed! I loo

Re: [fluid-dev] glib changes checked in

2009-04-27 Thread David Henningsson
j...@resonance.org skrev: > Quoting Pedro Lopez-Cabanillas : >> On Monday, April 27, 2009, j...@resonance.org wrote: >>> I just checked in some initial changes which make glib 2.10+ a >> Really you did it? :) > Yes yes indeed! I look forward to dedicating more of my free software > programming tim

Re: [fluid-dev] Documentation

2009-04-27 Thread josh
Quoting j...@resonance.org: Quoting Pedro Lopez-Cabanillas : Hi! On Friday, April 24, 2009, Conrad Berhörster wrote: Hello Pedro, On Thursday 23 April 2009 21:04:06 Josh Green wrote: On Mon, 2009-04-20 at 23:38 +0200, Pedro Lopez-Cabanillas wrote: > Hi, > > I've committed some changes to t

Re: [fluid-dev] Documentation

2009-04-27 Thread josh
Quoting Pedro Lopez-Cabanillas : Hi! On Friday, April 24, 2009, Conrad Berhörster wrote: Hello Pedro, On Thursday 23 April 2009 21:04:06 Josh Green wrote: > On Mon, 2009-04-20 at 23:38 +0200, Pedro Lopez-Cabanillas wrote: > > Hi, > > > > I've committed some changes to the developer documentat

Re: [fluid-dev] Documentation

2009-04-27 Thread Pedro Lopez-Cabanillas
Hi! On Friday, April 24, 2009, Conrad Berhörster wrote: > Hello Pedro, > > On Thursday 23 April 2009 21:04:06 Josh Green wrote: > > On Mon, 2009-04-20 at 23:38 +0200, Pedro Lopez-Cabanillas wrote: > > > Hi, > > > > > > I've committed some changes to the developer documentation: > > > http://fluids

Re: [fluid-dev] OS/2 support and glib

2009-04-27 Thread josh
Sending again since I forgot to CC the list with my reply. Quoting KO Myung-Hun : Hi/2. j...@resonance.org wrote: Hello, I've read that the glib library supports OS/2, but I haven't seen a place to download it. I hope that it does not over complicate the OS/2 build of FluidSynth to mov

Re: [fluid-dev] glib changes checked in

2009-04-27 Thread josh
Quoting Pedro Lopez-Cabanillas : On Monday, April 27, 2009, j...@resonance.org wrote: I just checked in some initial changes which make glib 2.10+ a Really you did it? :) Regards, Pedro Yes yes indeed! I look forward to dedicating more of my free software programming time to FluidSynt

Re: [fluid-dev] glib changes checked in

2009-04-27 Thread Pedro Lopez-Cabanillas
On Monday, April 27, 2009, j...@resonance.org wrote: > I just checked in some initial changes which make glib 2.10+ a Really you did it? :) Regards, Pedro ___ fluid-dev mailing list fluid-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/fluid-d

Re: [fluid-dev] OS/2 support and glib

2009-04-27 Thread KO Myung-Hun
Hi/2. j...@resonance.org wrote: Hello, I've read that the glib library supports OS/2, but I haven't seen a place to download it. I hope that it does not over complicate the OS/2 build of FluidSynth to move to using glib. Do let us know. I'll be removing some of the OS/2 specific code in f