David,
You are right this part of my fix show here:
+ if ( (chan == 9) && (bank_msb == 0))
+ {
+ bank_msb = 1; /* Ignore CC value and set the default MSB value for
drum channel */
+ }
is not necessary and yes it will prevent from other instruments being
assigned to drum channel.
I put
D.Bartolec skrev:
> I've discovered it after playing some MIDI files that would send bank LSB:0
> for drum channel without sending bank MSB at all.
> This would cause drum tracks to change to MSB:0 LSB:0.
I've taken a quick look at your patch now and I have a question:
> + if ( (chan == 9) &&
Hello
To 64-bit Debian users, I am forwarding this message that I received
off-list. It would be appreciated if anybody could assist/test on
64-bit Linux.
The latest svn (r168) has a persistent make error, when
compiling from source.
On 64studio 64bit:
Pedro Lopez-Cabanillas skrev:
> David Henningsson wrote:
>> Pedro Lopez-Cabanillas skrev:
> It is something that only Josh can
> do, and he is not answering mails right now.
That is a problem.
> I don't fear any problem if we have to wait a bit. OTOH, I've already
> explained that I'm not comf
I've discovered it after playing some MIDI files that would send bank LSB:0 for
drum channel without sending bank MSB at all.
This would cause drum tracks to change to MSB:0 LSB:0.
Here is the fix:
Index: src/fluid_chan.c
===
---
David Henningsson wrote:
> Pedro Lopez-Cabanillas skrev:
> > David Henningsson wrote:
> > Using a big period size (either 2048 or 4096 is enough) instead of the
> > default size (64 in Linux) makes the test program to sound like a drunken
> > drummer. Of course, using the right function: fluid_sett
Thanks for your effort! Can you please provide a diff or something
similar that shows what changes you have made to the source code?
// David
D.Bartolec skrev:
> Hi,
>
> I've been playing with fluidsynth and have noticed that something is wrong
> with BANK_SELECT_MSB handling in fluid_chan.c
>