Re: [fluid-dev] Subversion checkins

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 23:42 -0500, David Hilvert wrote: > On Mon, 17 Sep 2007 23:38:24 -0500 > David Hilvert <[EMAIL PROTECTED]> wrote: > > > ==26661== Thread 2: > > ==26661== Invalid read of size 4 > > ==26661==at 0x4078F14: fluid_synth_dither_s16 (fluid_synth.c:1824) > > ==26661==by 0x40

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 23:42 -0500, David Hilvert wrote: > On Mon, 17 Sep 2007 23:38:24 -0500 > David Hilvert <[EMAIL PROTECTED]> wrote: > > > ==26661== Thread 2: > > ==26661== Invalid read of size 4 > > ==26661==at 0x4078F14: fluid_synth_dither_s16 (fluid_synth.c:1824) > > ==26661==by 0x40

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 23:38:24 -0500 David Hilvert <[EMAIL PROTECTED]> wrote: > ==26661== Thread 2: > ==26661== Invalid read of size 4 > ==26661==at 0x4078F14: fluid_synth_dither_s16 (fluid_synth.c:1824) > ==26661==by 0x4056651: fluid_alsa_audio_run_s16 (fluid_alsa.c:558) > ==26661==by 0

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
Valgrind output for a failing run using -g CFLAGS follows, providing perhaps slightly more detailed information: ==26661== Memcheck, a memory error detector. ==26661== Copyright (C) 2002-2007, and GNU GPL'd, by Julian Seward et al. ==26661== Using LibVEX rev 1732, a library for dynamic binary tran

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 23:15:13 -0500 David Hilvert <[EMAIL PROTECTED]> wrote: > After many trials with valgrind, I finally got a segfault. It's not > immediately clear whether the output has any interesting data in it. I'll > append a failing run here, and a successful run in a follow-up post. Th

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 19:56:05 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > Bummer, I was hoping to write that one off ;) Perhaps running valgrind > on QSynth might yield something interesting (if not just making it run > too slow to actually work). After many trials with valgrind, I finally got

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 19:56:05 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > Bummer, I was hoping to write that one off ;) Perhaps running valgrind > on QSynth might yield something interesting (if not just making it run > too slow to actually work). I've tried this, and found no particularly in

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 21:57 -0500, David Hilvert wrote: > On Mon, 17 Sep 2007 18:31:13 -0700 > Josh Green <[EMAIL PROTECTED]> wrote: > > > I wonder what the technical reason for the crash was though. > > I've looked into this more closely; it appears that I may have been fooled by > the intermi

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 18:31:13 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > I wonder what the technical reason for the crash was though. I've looked into this more closely; it appears that I may have been fooled by the intermittent nature of the problem, and that qsynth is still not working corr

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 17:46:34 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > The idea with that patch was to make the chorus volume more uniform over > changes in the number of chorus stages, correct? If that factor could > be pre-calculated into the other parameters when the chorus count > changes

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 20:20 -0500, David Hilvert wrote: > On Mon, 17 Sep 2007 10:23:46 -0700 > Josh Green <[EMAIL PROTECTED]> wrote: > > > I wonder if your system being 64 bit capable is a determining factor for > > this issue. Perhaps make sure there are no other FluidSynth headers or > > librar

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 10:23:46 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > I wonder if your system being 64 bit capable is a determining factor for > this issue. Perhaps make sure there are no other FluidSynth headers or > libraries installed elsewhere on your system, then re-build/install > Flui

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 17:46:34 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > Looking at the current code though, I'm also seeing that the chorus->level > parameter is never actually used (seems this parameter is broken too?). For evaluating the original effect code, it might make more sense to lo

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 19:29 -0500, David Hilvert wrote: > On Mon, 17 Sep 2007 15:51:09 -0700 > Josh Green <[EMAIL PROTECTED]> wrote: > > > I think the wet parameter is related to how much of the "wet" reverb > > signal is being mixed into the output. > > Yes. Renaming it as something else woul

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 15:51:09 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > I think the wet parameter is related to how much of the "wet" reverb > signal is being mixed into the output. Yes. Renaming it as something else would probably be silly; I was being (at least) temporarily stupid. > Mos

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 19:05 -0500, David Hilvert wrote: > On Mon, 17 Sep 2007 10:23:46 -0700 > Breakpoint 2, new_fluid_synth (settings=0x81734f0) at fluid_synth.c:555 > 555 synth->reverb = new_fluid_revmodel(); > (gdb) p synth->dither_index > $1 = 0 > (gdb) p sizeof (synth->dither_index) >

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 10:23:46 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > Ok, so the synth.ladspa.active=no, but did you compile FluidSynth with > the --enable-ladspa option? No. Results of breakpointed run follow: GNU gdb 6.6-debian Copyright (C) 2006 Free Software Foundation, Inc. GDB is fre

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 17:42 -0500, David Hilvert wrote: > On Mon, 17 Sep 2007 13:09:07 -0700 > Josh Green <[EMAIL PROTECTED]> wrote: > > > return rev->wet / scalewet; > > > > Probably could even remove the rev->level field at that point. This > > seems like the right way to do things. Anyone go

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 13:09:07 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > return rev->wet / scalewet; > > Probably could even remove the rev->level field at that point. This > seems like the right way to do things. Anyone got any objections or > comments on this? If the 'wet' code is uncommen

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread Rui Nuno Capela
David Hilvert wrote: > On Mon, 17 Sep 2007 21:06:36 +0100 > Rui Nuno Capela <[EMAIL PROTECTED]> wrote: > >> diff -dupr fluidsynth-1.0.7a.0/src/fluid_rev.c >> fluidsynth-1.0.7a.1/src/fluid_rev.c >> --- fluidsynth-1.0.7a.0/src/fluid_rev.c 2004-03-29 11:05:18.0 >> +0100 >> +++ fluidsyn

Fw: Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread David Hilvert
Dropped the list ... Begin forwarded message: Date: Mon, 17 Sep 2007 16:11:47 -0500 From: David Hilvert <[EMAIL PROTECTED]> To: Josh Green <[EMAIL PROTECTED]> Subject: Re: [fluid-dev] [PATCH] Effect level clip On Mon, 17 Sep 2007 11:33:39 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > Thanks fo

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread Rui Nuno Capela
Josh Green wrote: > Hello David, > > On Mon, 2007-09-17 at 04:48 -0500, David Hilvert wrote: >> On Mon, 17 Sep 2007 00:43:30 -0700 >> Josh Green <[EMAIL PROTECTED]> wrote: >> >>> I think I need to get a better idea of how your patch is helping to keep >>> Reverb and Chorus at a more constant outpu

Fw: Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread David Hilvert
Dropped the list (again): Begin forwarded message: Date: Mon, 17 Sep 2007 16:28:25 -0500 From: David Hilvert <[EMAIL PROTECTED]> To: Rui Nuno Capela <[EMAIL PROTECTED]> Subject: Re: [fluid-dev] [PATCH] Effect level clip On Mon, 17 Sep 2007 21:06:36 +0100 Rui Nuno Capela <[EMAIL PROTECTED]> wrot

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 21:06 +0100, Rui Nuno Capela wrote: > this is in fact one of my proposed patches (attached once again). > > without this one qsynth reverb level is stuck to 100%, surely everyone > has this for granted ;) > > i remember it was argued by Peter himself during 1.0.4 release iir

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread Josh Green
Hello David, On Mon, 2007-09-17 at 04:48 -0500, David Hilvert wrote: > On Mon, 17 Sep 2007 00:43:30 -0700 > Josh Green <[EMAIL PROTECTED]> wrote: > > > I think I need to get a better idea of how your patch is helping to keep > > Reverb and Chorus at a more constant output level, regardless of the

Re: [fluid-dev] Windows build

2007-09-17 Thread Josh Green
On Mon, 2007-09-17 at 16:12 +0200, Bernhard Schelling wrote: > Hi Again > > > There are a few changes which were required to make these builds possible. > > In the DSP I added the files for aufile, dspfloat and removed strtok > > which doesn't exist anymore but is still referenced in the DSP. > >

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread Josh Green
Hello David, On Mon, 2007-09-17 at 03:24 -0500, David Hilvert wrote: > On Sun, 16 Sep 2007 18:02:34 -0700 > Josh Green <[EMAIL PROTECTED]> wrote: > > > I'm having trouble re-producing the QSynth crash problem (as mentioned > > in a previous email to the list, forgot to CC you though). > > I th

Re: [fluid-dev] Windows build

2007-09-17 Thread Josh Green
Hello Bernhard, On Mon, 2007-09-17 at 15:02 +0200, Bernhard Schelling wrote: > Hi Josh, Hi mailing list > > > After making a few changes to the existing VC++ 6 project and some > > source files I was able to build FluidSynth on Visual Studio 2003. > > Since I don't have VC++ 6, I was wondering if

Re: [fluid-dev] Windows build

2007-09-17 Thread Bernhard Schelling
Hi Again There are a few changes which were required to make these builds possible. In the DSP I added the files for aufile, dspfloat and removed strtok which doesn't exist anymore but is still referenced in the DSP. For the source itself a few changes were necessary for getting it built under

Re: [fluid-dev] Windows build

2007-09-17 Thread Bernhard Schelling
Hi Josh, Hi mailing list After making a few changes to the existing VC++ 6 project and some source files I was able to build FluidSynth on Visual Studio 2003. Since I don't have VC++ 6, I was wondering if I should just remove the older VC 6 project files and add the newer VS 2003 files. Is anyo

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread David Hilvert
On Mon, 17 Sep 2007 00:43:30 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > I think I need to get a better idea of how your patch is helping to keep > Reverb and Chorus at a more constant output level, regardless of the > synth.gain setting. If I recall correctly, effective gain was split in 1.0.7

Re: [fluid-dev] Subversion checkins

2007-09-17 Thread David Hilvert
On Sun, 16 Sep 2007 18:02:34 -0700 Josh Green <[EMAIL PROTECTED]> wrote: > I'm having trouble re-producing the QSynth crash problem (as mentioned > in a previous email to the list, forgot to CC you though). I think I'm on the list. > I've tried with Jack and ALSA, QSynth 2.5, 2.6 and 3.1. Als

Re: [fluid-dev] [PATCH] Effect level clip

2007-09-17 Thread Josh Green
Hello David, This patch also doesn't seem right, although I admit I'm not yet fully informed on the Reverb/Chorus settings within FluidSynth. Perhaps you could describe what you are trying to accomplish with the Reverb and Chorus level per voice updating, since that is something I did not underst