[FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding

2023-12-31 Thread Thilo Borgmann via ffmpeg-devel
--- libavcodec/webp.c | 50 +-- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 4fd107aa0c..58a20b73da 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -194,6 +194,7 @@ typedef struct We

[FFmpeg-devel] [PATCH v9 6/6] fate: add test for animated WebP

2023-12-31 Thread Thilo Borgmann via ffmpeg-devel
--- tests/fate/image.mak | 3 +++ tests/ref/fate/webp-anim | 22 ++ 2 files changed, 25 insertions(+) create mode 100644 tests/ref/fate/webp-anim diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 400199c28a..2e0d1e8e3f 100644 --- a/tests/fate/image.mak +++ b

[FFmpeg-devel] [PATCH v9 5/6] libavformat/webp: add WebP demuxer

2023-12-31 Thread Thilo Borgmann via ffmpeg-devel
From: Josef Zlomek Adds the demuxer of animated WebP files. It supports non-animated, animated, truncated, and concatenated files. Reading from a pipe (and other non-seekable inputs) is also supported. The WebP demuxer splits the input stream into packets containing one frame. It also marks the

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter: Add fsync filter

2023-12-31 Thread Thilo Borgmann via ffmpeg-devel
Am 18.12.23 um 12:02 schrieb Thilo Borgmann via ffmpeg-devel: Am 17.12.23 um 23:51 schrieb Michael Niedermayer: On Sat, Dec 16, 2023 at 09:13:21AM +0100, Thilo Borgmann via ffmpeg-devel wrote: [...] +// get number of bytes from cur to '\0' +static int buf_get_zero(FsyncContext *ct

Re: [FFmpeg-devel] [PATCH v9 3/6] libavcodec/webp: add support for animated WebP

2023-12-31 Thread Thilo Borgmann via ffmpeg-devel
Am 31.12.23 um 13:56 schrieb Tomas Härdin: +for (int y = 0; y < height; y++) { +const uint8_t *src1 = src1_data[0] + y * src1_linesize[0]; +const uint8_t *src2 = src2_data[0] + (y + pos_y) * src2_linesize[0] + pos_x * src2_step[0]; +uint8_t *dest = dest_data[0]

Re: [FFmpeg-devel] [PATCH v9 5/6] libavformat/webp: add WebP demuxer

2023-12-31 Thread Thilo Borgmann via ffmpeg-devel
Am 31.12.23 um 13:59 schrieb Tomas Härdin: sön 2023-12-31 klockan 13:30 +0100 skrev Thilo Borgmann via ffmpeg- devel: From: Josef Zlomek Adds the demuxer of animated WebP files. It supports non-animated, animated, truncated, and concatenated files. Reading from a pipe (and other non-seekable

[FFmpeg-devel] GSoC 2024

2024-01-02 Thread Thilo Borgmann via ffmpeg-devel
Hi, the application period for GSoC 2024 begins on Jan 22nd. Everyone interested in mentoring a project in 2024, please add your idea(s) to [1]. The application deadline is February 6th, I will aim for sending an application Jan 1st. Thanks, Thilo [1] https://trac.ffmpeg.org/wiki/Sponsoring

Re: [FFmpeg-devel] GSoC 2024

2024-01-02 Thread Thilo Borgmann via ffmpeg-devel
Am 02.01.24 um 22:47 schrieb Thilo Borgmann via ffmpeg-devel: Hi, the application period for GSoC 2024 begins on Jan 22nd. Everyone interested in mentoring a project in 2024, please add your idea(s) to [1]. The application deadline is February 6th, I will aim for sending an application Jan

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2024-01-03 Thread Thilo Borgmann via ffmpeg-devel
Am 01.12.23 um 12:37 schrieb Paul B Mahol: On Fri, Dec 1, 2023 at 12:24 PM Gyan Doshi wrote: On 2023-09-25 11:35 pm, Paul B Mahol wrote: On 9/11/23, Harshit Karwal wrote: 1. Replaced ring buffer ADT with AVAudioFifo from libavutil/audio_fifo.h 2. Fixed potential freeing of uninitialised p

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2024-01-03 Thread Thilo Borgmann via ffmpeg-devel
Am 03.01.24 um 11:10 schrieb Gyan Doshi: On 2024-01-03 02:28 pm, Thilo Borgmann via ffmpeg-devel wrote: Am 01.12.23 um 12:37 schrieb Paul B Mahol: On Fri, Dec 1, 2023 at 12:24 PM Gyan Doshi wrote: On 2023-09-25 11:35 pm, Paul B Mahol wrote: On 9/11/23, Harshit Karwal wrote: 1

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2024-01-03 Thread Thilo Borgmann via ffmpeg-devel
Am 03.01.24 um 11:45 schrieb Gyan Doshi: On 2024-01-03 03:46 pm, Thilo Borgmann via ffmpeg-devel wrote: Am 03.01.24 um 11:10 schrieb Gyan Doshi: On 2024-01-03 02:28 pm, Thilo Borgmann via ffmpeg-devel wrote: Am 01.12.23 um 12:37 schrieb Paul B Mahol: On Fri, Dec 1, 2023 at 12:24 PM Gyan

Re: [FFmpeg-devel] [PATCH v2 00/15] YUV colorspace filter negotiation

2024-01-04 Thread Dong, Ruijing via ffmpeg-devel
[AMD Official Use Only - General] I found out this change caused page fault as well. 8c7934f73ab6c568acaa47c821a6833f9145fdbb is the first bad commit commit 8c7934f73ab6c568acaa47c821a6833f9145fdbb Author: Niklas Haas Date: Sun Dec 31 13:35:03 2023 -0800 avfilter: add negotiation

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter: Add fsync filter

2024-01-05 Thread Thilo Borgmann via ffmpeg-devel
Am 31.12.23 um 13:31 schrieb Thilo Borgmann via ffmpeg-devel: Am 18.12.23 um 12:02 schrieb Thilo Borgmann via ffmpeg-devel: Am 17.12.23 um 23:51 schrieb Michael Niedermayer: On Sat, Dec 16, 2023 at 09:13:21AM +0100, Thilo Borgmann via ffmpeg-devel wrote: [...] +// get number of bytes from

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter: Add fsync filter

2024-01-07 Thread Thilo Borgmann via ffmpeg-devel
Am 06.01.24 um 18:39 schrieb James Almer: On 12/16/2023 5:13 AM, Thilo Borgmann via ffmpeg-devel wrote: ---   Changelog    |   1 +   MAINTAINERS  |   1 +   configure    |   2 +   doc/filters.texi |  33 +   libavfilter/Makefile |   1

Re: [FFmpeg-devel] [PATCH] Revert "doc/faq: replace non-breaking spaces (0xA0) with normal space"

2024-01-07 Thread Thilo Borgmann via ffmpeg-devel
Am 07.01.24 um 13:12 schrieb Stefano Sabatini: On date Saturday 2024-01-06 15:49:56 -0600, Marth64 wrote: This reverts commit 6442d1ddd62160e96c686c30648b6111e3e0c264. A valid point was made, that the non-breaking space will cause this text to render better by ensuring the unit never seperates

Re: [FFmpeg-devel] [PATCH v3] avformat/mov: Add support for demuxing still HEIC images

2024-01-10 Thread Vignesh Venkat via ffmpeg-devel
On Tue, Jan 9, 2024 at 4:39 AM James Almer wrote: > > On 10/4/2023 1:40 PM, Vignesh Venkatasubramanian via ffmpeg-devel wrote: > > They are similar to AVIF images (both use the HEIF container). > > The only additional work needed is to parse the hvcC box and put >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: rename avif fields to heif

2024-01-10 Thread Vignesh Venkat via ffmpeg-devel
On Tue, Jan 9, 2024 at 11:56 AM James Almer wrote: > > They are no longer avif specific. > > Signed-off-by: James Almer > --- > libavformat/isom.h | 4 ++-- > libavformat/mov.c | 28 ++-- > 2 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/libavformat/

[FFmpeg-devel] [PATCH] doc/utils: fix atan2 parameter order

2024-01-14 Thread Haixia Shi via ffmpeg-devel
The C library function double atan2(double y, double x) takes y as the first parameter and x as the second parameter. Signed-off-by: Haixia Shi --- doc/utils.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/utils.texi b/doc/utils.texi index 0c4f146f4f..76e704fc3c 1006

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mdec: DC reading for STRv1 is like STRv2

2024-01-14 Thread Michael Niedermayer via ffmpeg-devel
Hi aybe On Sat, Jan 13, 2024 at 02:28:52AM +, aybe aybe wrote: > Here are the two STR files I have used when writing this patch: > https://github.com/aybe/FFmpeg-PSX-STR-tests ok, i can confirm the version patch fixes these, i will apply it > Fanatics would probably say that 30 FPS for NTS

Re: [FFmpeg-devel] Hardware purchase request: AVX512-capable laptop

2024-01-18 Thread Steve Williams via ffmpeg-devel
You know, you could have flipped some burgers & made enough for that laptop by now. Sometimes the obvious way is the way. On 18/01/2024 06:07, Lynne wrote: Jan 18, 2024, 04:29 by [email protected]: On Wed, Jan 17, 2024 at 04:39:21PM +0100, Lynne wrote: Jan 17, 2024, 14:37 by mich...@n

Re: [FFmpeg-devel] [PATCH v1 2/5] avformat: add muxer support for H266/VVC

2024-01-18 Thread Ridley Combs via ffmpeg-devel
> On Jan 4, 2024, at 16:31, James Almer wrote: > > On 11/3/2023 6:57 AM, Thomas Siedel wrote: >> Add muxer for vvcc byte stream format. >> Add AV_CODEC_ID_VVC to ff_mp4_obj_type. >> Add AV_CODEC_ID_VVC to ISO Media codec (VvcConfigurationBox vvi1, >> vvc1 defined in ISO/IEC 14496-15:2021). >> A

[FFmpeg-devel] RISC-V vector DSP functions: Motivation for commit 446b009

2024-01-19 Thread Michael Platzer via ffmpeg-devel
Hi, Commit 446b0090cbb66ee614dcf6ca79c78dc8eb7f0e37 by Remi Denis-Courmont has replaced RISC-V vector loads and stores with negative stride with vrgather (generalized permutation within vector registers) instructions in order to reverse the elements in a vector register. The commit message expl

[FFmpeg-devel] [PATCH] configure: autodetect libglslang ldflags

2024-01-21 Thread Matthew White via ffmpeg-devel
Since glslang 14.0.0, OGLCompiler and HLSL stub libraries have been fully removed from the build. This fixes the configuration by detecting if the stub libraries are still present (glslang releases before version 14.0.0). ffbuild/config.log: /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-

Re: [FFmpeg-devel] [PATCH] configure: autodetect libglslang ldflags

2024-01-22 Thread Matthew White via ffmpeg-devel
As far as I can tell, there're no pkg-config features in https://github.com/KhronosGroup/glslang installation, at least by installing it on my system, GNU/Linux Gentoo. ___ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH] configure: autodetect libglslang ldflags

2024-01-22 Thread Matthew White via ffmpeg-devel
> Also, how does this work when cross compiling - won't the "glslang" binary > be for the foreign cross target? Or is it something like the sdl-config > script which is a local shell script that can give relevant build flags (a > design preceding pkg-config)? I don't have an answer to that, in

Re: [FFmpeg-devel] [PATCH] configure: autodetect libglslang ldflags

2024-01-22 Thread Matthew White via ffmpeg-devel
> This is very very cursed. Fitting for the public API of the world's fifth > worst library. > Debian is stuck on version 13, so the majority of users are still stuck on > version 13. > Debian ships a pkg-config file, but of course it's incorrect, if you try to > compile against it. > Oh, and li

Re: [FFmpeg-devel] RISC-V vector DSP functions: Motivation for commit 446b009

2024-01-23 Thread Michael Platzer via ffmpeg-devel
Hi Rémi, Thanks for your reply. > It was faster on what the best approximation of real hardware available at > the time, i.e. a Sipeed Lichee Pi4A board. There are no benchmarks in the > commit because I don't like to publish benchmarks collected from prototypes. > Nevertheless I think the comm

[FFmpeg-devel] h264 - Late SEI is not implemented

2024-01-23 Thread Harald Linden via ffmpeg-devel
Hello list, I sent this mail to the list earlier today, before I actually subscribed. Didn't get an error, but also not sure if it was silently discarded, hence, this second attempt. --- I am currently running ffmpeg version N-112750-g6d60cc7baf with the following library versions: liba

Re: [FFmpeg-devel] h264 - Late SEI is not implemented

2024-01-23 Thread Harald Linden via ffmpeg-devel
Hi Leo, You can try to truncate the file to the smallest size that reproduces the issue, obvious, of course, now that you've explained it. Thanks and sorry for being a bit slow there. I've cropped 3 seconds of black from the video which contains enough frames to trigger the issue. I have r

Re: [FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding

2024-01-25 Thread Thilo Borgmann via ffmpeg-devel
Am 25.01.24 um 11:04 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-31 13:30:14) --- libavcodec/webp.c | 50 +-- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index

[FFmpeg-devel] [PATCH] libavcodec: add tune_content option also for VP8.

2024-01-25 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Change authored by Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 7 +-- libavcodec/libvpxenc.c | 35 ++- 2 files changed, 39 insertions(+), 3 deletions(-) diff --

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/s302m: enable non-PCM decoding

2024-01-28 Thread Gyan Doshi via ffmpeg-devel
On 2024-01-28 04:24 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2024-01-26 05:23:50) On 2024-01-25 06:47 pm, Andreas Rheinhardt wrote: Gyan Doshi: On 2024-01-25 10:29 am, Andreas Rheinhardt wrote: Gyan Doshi: Set up framework for non-PCM decoding in-place and add support for Dolby-E deco

Re: [FFmpeg-devel] [PATCH] libavcodec: add tune_content option also for VP8.

2024-01-29 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Please ignore this version of the patch. I'll send out v2 soon. Apologies for the noise. On Thu, Jan 25, 2024 at 6:13 PM Dariusz Marcinkiewicz wrote: > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > Change authored by Erik Språng > > Signed-off-by: Dariusz Marcinkiewicz > --

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-01-29 Thread Cosmin Stejerean via ffmpeg-devel
> On Jan 28, 2024, at 7:54 AM, Kieran Kunhya wrote: > > So work like Anton's threading, YUVJ removal etc, that couldn't be funded > via bounties as they have no direct commercial value but require expertise > in the codebase. > Statements of Work and milestones (by definition) are for features.

Re: [FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding

2024-01-30 Thread Thilo Borgmann via ffmpeg-devel
Am 28.01.24 um 11:29 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2024-01-25 16:39:19) Am 25.01.24 um 11:04 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-31 13:30:14) --- libavcodec/webp.c | 50

Re: [FFmpeg-devel] [PATCH 2/2] fate/video: add DXV3 HQ tests

2024-01-30 Thread Thilo Borgmann via ffmpeg-devel
Am 30.01.24 um 21:53 schrieb Connor Worley: In that case, it is probably worth replacing the existing "normal quality" samples as they're even larger. dxv3-nqwa.mov does not adequately exercise the code fixed in https://patchwork.ffmpeg.org/project/ffmpeg/patch/20240130062626.98273-1-connorbwor..

Re: [FFmpeg-devel] GSoC 2024

2024-01-30 Thread Thilo Borgmann via ffmpeg-devel
Am 02.01.24 um 23:14 schrieb Thilo Borgmann via ffmpeg-devel: Am 02.01.24 um 22:47 schrieb Thilo Borgmann via ffmpeg-devel: Hi, the application period for GSoC 2024 begins on Jan 22nd. Everyone interested in mentoring a project in 2024, please add your idea(s) to [1]. The application

[FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-01-31 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Changes since v1: - Put the new param initialzation in the right place, - Account for cases when the encoder's output is queued up. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 7 +++

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-01-31 Thread Cosmin Stejerean via ffmpeg-devel
> On Jan 31, 2024, at 11:07 AM, Michael Niedermayer > wrote: > > On Wed, Jan 31, 2024 at 06:22:41PM +, Kieran Kunhya wrote: >> On Wed, 31 Jan 2024 at 18:03, Michael Niedermayer >> wrote: >> >>> Hi Jonatas, Remi >>> >>> _THIS_ reply shows why i LOVE SPI >>> >>> I mean this is transparen

Re: [FFmpeg-devel] [PATCH 2/2] fate/video: add DXV3 HQ tests

2024-02-01 Thread Thilo Borgmann via ffmpeg-devel
Am 30.01.24 um 22:57 schrieb Connor Worley: OK, attached are some significantly smaller HQ samples that produce the same coverage. 5b11c393dda223b5dd198ad2f2576fe2 fate-suite/dxv/dxv3-hqna.mov 3af30eaba2b6ec68a0f5b2c136f4dab6 fate-suite/dxv/dxv3-hqwa.mov 5b11c393dda223b5dd198ad2f2576fe2 dow

Re: [FFmpeg-devel] [RFC] Vote STF/SPI 2024-02

2024-02-01 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 1, 2024, at 9:45 AM, Vittorio Giovara > wrote: > > Since all objections and requests for more time have been ignored, and this > is happening anyway, can we add a small amendment for the sake of > transparency and for avoiding any conflict of interest? Whoever was > involved with the

Re: [FFmpeg-devel] [PATCH] configure: fix compilation with glslang 14

2024-02-02 Thread Philip Langdale via ffmpeg-devel
On Wed, 31 Jan 2024 17:34:08 +0100 (CET) Lynne wrote: > The configure check already had fallback for the previous version > of glslang, which had different requirements for flags. > This commit simply moves the flags needed for glslang 13 to the > fallback, while first trying to use new flags for

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp8: Enforce key-frame only for WebP

2024-02-04 Thread Thilo Borgmann via ffmpeg-devel
On 03.02.24 14:57, Andreas Rheinhardt wrote: Andreas Rheinhardt: VP8-in-WebP only uses key frame encoding (see [1]), yet this is currently not enforced. This commit does so in order to make output reproducible with frame-threading as the VP8 decoder's update_thread_context is not called at al

Re: [FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding

2024-02-04 Thread Thilo Borgmann via ffmpeg-devel
On 03.02.24 14:53, Andreas Rheinhardt wrote: Thilo Borgmann via ffmpeg-devel: Am 28.01.24 um 11:29 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2024-01-25 16:39:19) Am 25.01.24 um 11:04 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-31 13:30:14

[FFmpeg-devel] [PATCH v3 0/3] avformat/mov: add support for 'amve' ambient viewing environment box

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean This rebases the previous patch series from Damiano Galassi after the packet side data changes and adds FATE tests for both reading and writing amve Cosmin Stejerean (1): tests/fate/mov: add a test for reading and writing amve box Damiano Galassi (2): avcodec: add amb

[FFmpeg-devel] [PATCH v3 1/3] avcodec: add ambient viewing environment packet side data.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Damiano Galassi --- fftools/ffprobe.c | 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 7 +++ 4 files changed, 12 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index f33e2471cb..aa1153e709 100644 --- a/fftools/ffprobe.c

[FFmpeg-devel] [PATCH v3 2/3] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Damiano Galassi Co-Authored-By: Cosmin Stejerean --- libavformat/dump.c | 15 +++ libavformat/isom.h | 3 +++ libavformat/mov.c| 35 +++ libavformat/movenc.c | 30 ++ 4 files changed, 83 insertions(+) diff -

[FFmpeg-devel] [PATCH v3 3/3] tests/fate/mov: add a test for reading and writing amve box

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean --- tests/fate/mov.mak| 5 + tests/ref/fate/mov-read-amve | 8 tests/ref/fate/mov-write-amve | 33 + 3 files changed, 46 insertions(+) create mode 100644 tests/ref/fate/mov-read-amve create mode 100644 tests/ref

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec: add ambient viewing environment packet side data.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 4, 2024, at 12:45, Anton Khirnov wrote: > > Quoting Cosmin Stejerean via ffmpeg-devel (2024-02-04 12:16:53) >> diff --git a/libavcodec/packet.h b/libavcodec/packet.h >> index 2c57d262c6..215b1c9970 100644 >> --- a/libavcodec/packet.h >> +++ b/libavco

Re: [FFmpeg-devel] [PATCH v3 3/3] tests/fate/mov: add a test for reading and writing amve box

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 4, 2024, at 13:44, James Almer wrote: > > On 2/4/2024 8:16 AM, Cosmin Stejerean via ffmpeg-devel wrote: >> From: Cosmin Stejerean >> >> --- >> tests/fate/mov.mak| 5 + >> tests/ref/fate/mov-read-amve | 8

[FFmpeg-devel] [PATCH v4 0/3] avformat/mov: add support for 'amve' ambient viewing environment

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean Version 4 resolves feedback from v3 by moving new side data field in packet.h to the end for ABI compatibility, bumping the minor API version for lavc, adding APIChanges entry, using -c:v in the FATE test, cleaning up formatting in avformat/movenc and renaming rescale_mdcv

[FFmpeg-devel] [PATCH v4 1/3] avcodec: add ambient viewing environment packet side data.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Damiano Galassi --- doc/APIchanges| 3 +++ fftools/ffprobe.c | 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 9 - libavcodec/version.h | 2 +- 6 files changed, 17 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges b/do

[FFmpeg-devel] [PATCH v4 2/3] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Damiano Galassi Co-Authored-By: Cosmin Stejerean --- libavformat/dump.c | 15 + libavformat/isom.h | 3 +++ libavformat/mov.c| 35 +++ libavformat/movenc.c | 50 ++-- 4 files changed, 92 insertions(+)

[FFmpeg-devel] [PATCH v4 3/3] tests/fate/mov: add a test for reading and writing amve box

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean --- tests/fate/mov.mak| 5 + tests/ref/fate/mov-read-amve | 8 tests/ref/fate/mov-write-amve | 33 + 3 files changed, 46 insertions(+) create mode 100644 tests/ref/fate/mov-read-amve create mode 100644 tests/ref

[FFmpeg-devel] [PATCH v10 0/5] webp: add support for animated WebP decoding

2024-02-05 Thread Thilo Borgmann via ffmpeg-devel
From: Thilo Borgmann Still images fixed, includes FATE tests, VP8 decoder not decoupled, fixed more asserts, fixed ffprobe regression, removed unnecessary parser changes, put the whole animated sequence into one packet. Patch 4/6 is still there for making changes in lavc/webp reviewable but sh

[FFmpeg-devel] [PATCH v10 1/5] avcodec/webp: remove unused definitions

2024-02-05 Thread Thilo Borgmann via ffmpeg-devel
From: Thilo Borgmann --- libavcodec/webp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 54b3fde6dc..4fd107aa0c 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -59,8 +59,6 @@ #define VP8X_FLAG_ALPHA 0x10 #define VP8X_

[FFmpeg-devel] [PATCH v10 2/5] libavcodec/webp: add support for animated WebP

2024-02-05 Thread Thilo Borgmann via ffmpeg-devel
From: Josef Zlomek Fixes: 4907 Adds support for decoding of animated WebP. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_container#animation The frames of the animation may be smaller than the image canvas. Theref

[FFmpeg-devel] [PATCH v10 4/5] libavformat/webp: add WebP demuxer

2024-02-05 Thread Thilo Borgmann via ffmpeg-devel
From: Josef Zlomek Adds the demuxer of animated WebP files. It supports non-animated, animated, truncated, and concatenated files. Reading from a pipe (and other non-seekable inputs) is also supported. The WebP demuxer splits the input stream into packets containing one frame. It also marks the

[FFmpeg-devel] [PATCH v10 5/5] fate: add test for animated WebP

2024-02-05 Thread Thilo Borgmann via ffmpeg-devel
From: Thilo Borgmann --- tests/fate/image.mak | 3 +++ tests/ref/fate/webp-anim | 22 ++ 2 files changed, 25 insertions(+) create mode 100644 tests/ref/fate/webp-anim diff --git a/tests/fate/image.mak b/tests/fate/image.mak index 400199c28a..2e0d1e8e3f 100644 --- a/tes

[FFmpeg-devel] [PATCH v10 3/5] avcodec/webp: make init_canvas_frame static

2024-02-05 Thread Thilo Borgmann via ffmpeg-devel
From: Thilo Borgmann --- libavcodec/webp.c | 142 +++--- 1 file changed, 70 insertions(+), 72 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 4119ae679d..0931112546 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -1358,7 +1

[FFmpeg-devel] [PATCH] .mailmap: update my mailmap entry

2024-02-05 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 7546cf0caf..cbe6b3ff99 100644 --- a/.mailmap +++ b/.mailmap @@ -22,3 +22,4 @@ rcombs +Cosmin Stejerean Cosmin Stejerean via ffmpeg-devel -- 2.42.1

Re: [FFmpeg-devel] [PATCH] .mailmap: update my mailmap entry

2024-02-06 Thread Thilo Borgmann via ffmpeg-devel
Am 05.02.24 um 21:02 schrieb Cosmin Stejerean via ffmpeg-devel: From: Cosmin Stejerean --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 7546cf0caf..cbe6b3ff99 100644 --- a/.mailmap +++ b/.mailmap @@ -22,3 +22,4 @@ rcombs +Cosmin

Re: [FFmpeg-devel] STF SoWs

2024-02-06 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 6, 2024, at 10:17 AM, Michael Niedermayer > wrote: > > if "merge to git master" is a requirement then iam not participating > in this. The risk simply outweights the gain. I wont work for months to > then be at the mercy of not a single of 2000 subscribers posting some > "i object" an

[FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-02-07 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Changes since v1: - Put the new param initialzation in the right place, - Account for cases when the encoder's output is queued up. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 7 +++

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 7, 2024, at 1:55 AM, Anton Khirnov wrote: > > As a compromise, we could start requiring C11 now, and C17 in 7.1. > Or does anyone still care about compilers without even c11 support? How about C11 now and C17 in a year with ffmpeg 8? - Cosmin _

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-02-07 Thread Cosmin Stejerean via ffmpeg-devel
> On Jan 23, 2024, at 11:22 AM, Michael Niedermayer > wrote: > > What is blocking? (IMHO) > * regressions (unless its non possible to fix before release) > * crashes > * security issues > * data loss > * privacy issues > * anything the commuity agrees should be in the release Can we get the a

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 7, 2024, at 11:27 AM, Lynne wrote: > >>> >>> As a compromise, we could start requiring C11 now, and C17 in 7.1. >>> Or does anyone still care about compilers without even c11 support? >>> >> >> How about C11 now and C17 in a year with ffmpeg 8? >> > > Do you have setups and reason

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-07 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 7, 2024, at 1:48 PM, Lynne wrote: > > Feb 7, 2024, 22:11 by [email protected]: > >> >> >>> On Feb 7, 2024, at 11:27 AM, Lynne wrote: >>> > > As a compromise, we could start requiring C11 now, and C17 in 7.1. > Or does anyone still care about compilers without ev

Re: [FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-02-07 Thread James Zern via ffmpeg-devel
Hi, On Wed, Feb 7, 2024 at 8:04 AM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > For the subject use '(libavcodec|avcodec|lavc)/libvpxenc: ...' to better document what is being changed. See the history of th

[FFmpeg-devel] [PATCH v3] lavc/libvpxenc: add screen-content-mode option

2024-02-08 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx and makes us retry encode if screen_content_mode == 2 and no output was produced by encoder. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 3 +++ libavcodec/libvpxenc.c | 57 +++

Re: [FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

2024-02-08 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Hi. On Thu, Feb 8, 2024 at 7:13 AM James Zern wrote: > > Hi, > > On Wed, Feb 7, 2024 at 8:04 AM Dariusz Marcinkiewicz via ffmpeg-devel > wrote: > > > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > > > For the subject use '

Re: [FFmpeg-devel] [PATCH v2] libavfi/dnn: add LibTorch as one of DNN backend

2024-02-09 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 1, 2024, at 11:26 PM, [email protected] wrote: > > From: Wenbin Chen > > PyTorch is an open source machine learning framework that accelerates > the path from research prototyping to production deployment. Official > websit: https://pytorch.org/. We call the C++ libr

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpxenc: add screen-content-mode option

2024-02-09 Thread James Zern via ffmpeg-devel
On Thu, Feb 8, 2024 at 1:58 PM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx and makes > us retry encode if screen_content_mode == 2 and no output was produced > by encoder. > > Co-authored-by: Erik Språng > S

[FFmpeg-devel] [PATCH v4] lavc/libvpxenc: add screen-content-mode option

2024-02-10 Thread Dariusz Marcinkiewicz via ffmpeg-devel
This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. Co-authored-by: Erik Språng Signed-off-by: Dariusz Marcinkiewicz --- doc/encoders.texi | 3 +++ libavcodec/libvpxenc.c | 11 +++ libavcodec/version.h | 2 +- 3 files changed, 15 insertions(+), 1 deletion(-) diff --g

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpxenc: add screen-content-mode option

2024-02-10 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Hello. On Fri, Feb 9, 2024 at 7:28 PM James Zern wrote: > Just sent v4, which addresses the below comments. Thank you. > On Thu, Feb 8, 2024 at 1:58 PM Dariusz Marcinkiewicz via ffmpeg-devel > wrote: ... > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] apsnr's PSNR formula is different from Wikipedia's formula

2024-10-07 Thread Shawn Singh via ffmpeg-devel
On Tue, Oct 1, 2024 at 3:41 PM Jing Lu wrote: > Hi ffmpeg-devel@, > > I recently came across the apnsr filter > , > and the formula for PSNR it uses: > > 2.0 * log(s->max) - log(s->nb_samples / s->chs[ch].uv) > > > which is

[FFmpeg-devel] can not run encoding example of FFmpeg

2024-10-08 Thread cfd new via ffmpeg-devel
Tried to run the following FFmpeg example:https://ffmpeg.org/doxygen/4.2/encode_video_8c-example.html | | | | FFmpeg: encode_video.c | | | On Ubuntu 22.04 and Windows 11 with the latest FFmpeg. Two runs failed at ret = avcodec_send_frame(enc_ctx, frame);ret = -22. What is wrong? ___

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/dnxuc_parser: Use av_fourcc2str instead of av_fourcc_make_string

2024-10-13 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-12 23:36 +0200, martin schitter wrote: > On 12.10.24 23:18, [email protected] wrote: > > Maybe just squash them into one commit. > > Yes -- this looks like the most desirable solution. > > And thanks to Alex for the suggested improvement! Thank you Martin and Marvin for the quick respo

[FFmpeg-devel] [PATCH 1/2] lavc/dnxuc_parser: Adhere to av_fourcc_make_string API

2024-10-12 Thread Alexander Strasser via ffmpeg-devel
The documentation of av_fourcc_make_string states the passed in buffer must be of at least the size of AV_FOURCC_MAX_STRING_SIZE Also move the buffer into inner scope where it is used. Fixes: CID 1632380 --- libavcodec/dnxuc_parser.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 2/2] libavcodec/dnxuc_parser: Use av_fourcc2str instead of av_fourcc_make_string

2024-10-12 Thread Alexander Strasser via ffmpeg-devel
The string representation of the FourCC is only used once for logging. --- Could also merge this with the first patch in this series and make it a single patch. Or drop this one. I don't have a strong opinion on these details. libavcodec/dnxuc_parser.c | 5 + 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-14 19:22 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 18:27:24) > > On 2024-10-14 17:52 +0200, Michael Niedermayer wrote: > > > On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote: > > > > --- >

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-14 22:35 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-14 22:21:38) > > > It is documented in the header. > > > > I figured as much but couldn't find a hint in in avfilter.h > > > > You changed it in a previou

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-15 10:37 +0200, [email protected] wrote: > > > On 15 Oct 2024, at 10:30, Anton Khirnov wrote: > > > Quoting Alexander Strasser via ffmpeg-devel (2024-10-15 07:34:26) > >> On 2024-10-14 22:35 +0200, Anton Khirnov wrote: > >>> Quoting Alexander Stra

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-15 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-15 15:09 +0200, Anton Khirnov wrote: > Quoting James Almer (2024-10-15 14:54:08) > > On 10/15/2024 6:57 AM, Anton Khirnov wrote: > > > avfilter_process_command() may or may not return ENOSYS whether that > > > flag is set or not, so I don't see what exactly would it be useful for. > > >

Re: [FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-10-14 Thread Thomas Guillem via ffmpeg-devel
Ping. On Mon, Oct 7, 2024, at 17:43, Thomas Guillem via ffmpeg-devel wrote: > Fixes the following assert: > > [7f1df83d17e0] vaapi generic error: > avcodec_get_hw_frames_parameters failed: -22 > Assertion p_dst->hwaccel_threadsafe || (!dst->hwaccel && > !

Re: [FFmpeg-devel] [PATCH] avfilter/vf_subtitles: Respect YCbCr Matrix header

2024-10-15 Thread Ridley Combs via ffmpeg-devel
> On Oct 13, 2024, at 05:45, arch1t3cht wrote: > > As specified in libass's ass_types.h, the colors or ASS_Images > should be converted to YCbCr using the matrix/range specified in > the track's YCbCrMatrix field (unless that field is set to YCBCR_NONE, > and defaulting to TV.601 if the header

Re: [FFmpeg-devel] [PATCH 1/2] configure: suggest installing nasm/yasm before using --disable-x86asm

2024-10-09 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-03 04:04 +0200, Lynne via ffmpeg-devel wrote: > On 01/10/2024 15:24, vipyne wrote: > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index c8fb49a7a4..d178ef59

[FFmpeg-devel] [PATCH] vulkan_decode: remove yuv sampler for DPB images

2024-10-11 Thread Benjamin Cheng via ffmpeg-devel
The YCbCr sampler is only required for multi-plane images if the image is created with SAMPLED usage, and the image view is created with aspectMask = COLOR. For DPB images, it is expected that some implementations will have opaque DPBs (i.e. they do not support SAMPLED/TRANSFER/STORAGE usages). Si

Re: [FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-10-06 Thread Thomas Guillem via ffmpeg-devel
Ping. On Mon, Sep 30, 2024, at 13:44, Thomas Guillem via ffmpeg-devel wrote: > cf. https://trac.ffmpeg.org/ticket/11013 > > > On Mon, Sep 30, 2024, at 10:27, Thomas Guillem via ffmpeg-devel wrote: >> Fixes the following assert: >> >> [7f1

[FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-09-30 Thread Thomas Guillem via ffmpeg-devel
Fixes the following assert: [7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters failed: -22 Assertion p_dst->hwaccel_threadsafe || (!dst->hwaccel && !dst->internal->hwaccel_priv_data) failed at libavcodec/pthread_frame.c:349 Reproduced from VLC with VAAPI, when fallbacking

Re: [FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-10-07 Thread Thomas Guillem via ffmpeg-devel
On Mon, Oct 7, 2024, at 17:12, Rémi Denis-Courmont wrote: > Le 30 septembre 2024 17:27:46 GMT+09:00, Thomas Guillem via > ffmpeg-devel a écrit : >>Fixes the following assert: >> >>[7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters >>

[FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-10-07 Thread Thomas Guillem via ffmpeg-devel
Fixes the following assert: [7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters failed: -22 Assertion p_dst->hwaccel_threadsafe || (!dst->hwaccel && !dst->internal->hwaccel_priv_data) failed at libavcodec/pthread_frame.c:349 Reproduced from VLC with VAAPI, when fallbacking

[FFmpeg-devel] [RFC PATCH 3/2] FIXUP

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
--- Sorry I forgot this fixup to the previous patch, that I had in my work tree but not committed... tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 72251ec571..bed8f7127c 100755 --- a/tests/fate-run.sh +++ b/test

[FFmpeg-devel] [RFC PATCH 1/2] Reapply "tests/fate: disable compression for zlib-based codecs"

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
The problems that caused the revert will be fixed with the follow-up change right after this commit. This reverts commit e206e72b83a0e512e21694a43af4df2b53f6d045. --- tests/fate/cover-art.mak | 6 ++-- tests/fate/image.mak | 4 +-- tests/fate/lavf-image.mak

Re: [FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-19 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 21:02 +0200, Michael Niedermayer wrote: > On Fri, Oct 18, 2024 at 02:02:48PM +0200, Alexander Strasser via ffmpeg-devel > wrote: > > This is as subject notes an RFC. I wanted to send it out quickly. > > Didn't actually test on zlib systems yet (old and new

Re: [FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 13:16 +0200, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-10-18 12:55:49) > > FTR and FWIW it was useful for me for identifying filters that can do > > more with commands than timeline enable/disable. > > And then what do you do with

Re: [FFmpeg-devel] [RFC PATCH 2/2] fate: Make it possible to have alternative reference files

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 16:36 +0200, Lynne via ffmpeg-devel wrote: > On 18/10/2024 14:41, Hendrik Leppkes wrote: > > On Fri, Oct 18, 2024 at 2:09 PM Alexander Strasser via ffmpeg-devel > > wrote: > > > This caused differences > > > with 2 fate tests depending on the zlib v

[FFmpeg-devel] [RFC PATCH 2/2] fate: Make it possible to have alternative reference files

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
Sometimes deps (external from FFmpeg) can cause different results either because of bugs or because of drop in replacements. This feature of alternate reference files should only be used where absolutely necessary because other solutions are not feasible in practice. Maintaining two reference file

[FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-18 Thread Alexander Strasser via ffmpeg-devel
This is as subject notes an RFC. I wanted to send it out quickly. Didn't actually test on zlib systems yet (old and new). So it is not that heavily tested yet and maybe has rough edges I didn't notice. I hope this would help to unbreak zlib-ng systems and not disturb systems with older zlib versi

Re: [FFmpeg-devel] [RFC PATCH 0/2] Make fate tests succeed with zlib-ng

2024-10-19 Thread Alexander Strasser via ffmpeg-devel
On 2024-10-18 15:55 +0100, Derek Buitenhuis wrote: > On 10/18/2024 1:02 PM, Alexander Strasser via ffmpeg-devel wrote: > > Alexander Strasser (2): > > Reapply "tests/fate: disable compression for zlib-based codecs" > > fate: Make it possible to have alternativ

<    13   14   15   16   17   18   19   20   21   22   >