Re: [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx

2024-06-05 Thread Lynne via ffmpeg-devel
On 03/06/2024 11:19, [email protected] wrote: From: Tong Wu This patch is to make FFHWBaseEncodeContext a standalone component and avoid getting FFHWBaseEncodeContext from avctx->priv_data. This patch also removes some unnecessary AVCodecContext arguments. For receive_packet cal

Re: [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx

2024-06-06 Thread Lynne via ffmpeg-devel
On 06/06/2024 08:46, Wu, Tong1 wrote: From: ffmpeg-devel On Behalf Of Lynne via ffmpeg-devel Sent: Thursday, June 6, 2024 2:11 PM To: [email protected] Cc: Lynne Subject: Re: [FFmpeg-devel] [PATCH v13 15/15] avcodec/hw_base_encode: avoid getting FFHWBaseEncodeContext from avctx On 03/06

Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-06-07 Thread Lynne via ffmpeg-devel
On 03/06/2024 11:18, [email protected] wrote: From: Tong Wu Move receive_packet function to base. This requires adding *alloc, *issue, *output, *free as hardware callbacks. HWBaseEncodePicture is introduced as the base layer structure. The related parameters in VAAPIEncodeContext

Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-06-07 Thread Lynne via ffmpeg-devel
On 07/06/2024 17:22, Wu, Tong1 wrote: From: ffmpeg-devel On Behalf Of Lynne via ffmpeg-devel Sent: Friday, June 7, 2024 11:10 PM To: [email protected] Cc: Lynne Subject: Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer On 03/06/2024

Re: [FFmpeg-devel] [PATCH v10] avcodec: add farbfeld encoder, decoder and demuxer

2024-06-07 Thread Lynne via ffmpeg-devel
On 07/06/2024 21:33, Marcus B Spencer wrote: On Friday, June 7th, 2024 at 1:12 PM, Lynne via ffmpeg-devel wrote: Since the "codec" is essentially just raw data, you should just make the demuxer output native RGBA64, and the muxer accept RGBA64. There's no reason to have

Re: [FFmpeg-devel] [PATCH 4/4] lavu/riscv: use Zbb CLZ/CTZ/CLZW/CTZW at run-time

2024-06-08 Thread Lynne via ffmpeg-devel
On 08/06/2024 13:37, Rémi Denis-Courmont wrote: Zbb staticZbb dynamic I baseline clz 0.668032642 1.336072283 19.552376803 clzl 0.668092643 1.336181786 26.110855571 ctz 1.336208533 3.340209702 26.054869008 ctzl 1.336247784 3.340362457 26.055266

Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-06-09 Thread Lynne via ffmpeg-devel
On 07/06/2024 18:48, Lynne wrote: On 07/06/2024 17:22, Wu, Tong1 wrote: From: ffmpeg-devel On Behalf Of Lynne via ffmpeg-devel Sent: Friday, June 7, 2024 11:10 PM To: [email protected] Cc: Lynne Subject: Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: Support write on drm frame

2024-06-11 Thread Lynne via ffmpeg-devel
On 11/06/2024 06:55, Xiang, Haihao wrote: From: Haihao Xiang Otherwise nothing is written into the destination when a write mapping is requested. For example, a vulkan frame mapped from a drm frame (which is wrapped as a vaapi frame in the example) is used as the output of scale_vulkan filter,

Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-06-14 Thread Lynne via ffmpeg-devel
On 12/06/2024 10:44, Wu, Tong1 wrote: From: ffmpeg-devel On Behalf Of Lynne via ffmpeg-devel Sent: Monday, June 10, 2024 10:01 AM To: FFmpeg development discussions and patches Cc: Lynne Subject: Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base

[FFmpeg-devel] [PATCH] avformat/aeadec, avcodec/atrac1: Fix 8 and 4-channel ATRAC1 support

2024-06-14 Thread asivery via ffmpeg-devel
Right now both the ATRAC1 decoder implementation, and the AEA demuxer don't accept 4-track and 8-track ATRAC data. This patch fixes that problem.From c42e05855a018e28159bf29b49137bb33f5e45fd Mon Sep 17 00:00:00 2001 From: asivery Date: Sat, 15 Jun 2024 07:47:40 +0200 Subject: [PATCH] avformat/aea

[FFmpeg-devel] [PATCH 1/6] aacdec_usac: apply specification fix M55715

2024-06-16 Thread Lynne via ffmpeg-devel
--- libavcodec/aac/aacdec_usac.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index 98e8c1c0bc..065bc869d9 100644 --- a/libavcodec/aac/aacdec_usac.c +++ b/libavcodec/aac/aacdec_usac.c @@ -835,6 +835,11 @@ stati

[FFmpeg-devel] [PATCH 2/6] aac: expose ff_aac_sample_rate_idx() in aac.h

2024-06-16 Thread Lynne via ffmpeg-devel
The rate index is a value important to both encoders and decoders. USAC needs it as well, so put it into the shared main header. --- libavcodec/aac.h| 16 libavcodec/aac/aacdec.c | 18 +- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH 3/6] aacdec_ac: fix an overread

2024-06-16 Thread Lynne via ffmpeg-devel
Fixes reading state->last[i + 1] in ff_aac_ac_get_context for the last array member. --- libavcodec/aac/aacdec_ac.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aac/aacdec_ac.h b/libavcodec/aac/aacdec_ac.h index 0b98c0f0d9..b8d4ade4c6 100644 --- a/libavcodec/aac/a

[FFmpeg-devel] [PATCH 4/6] aacdec_usac: rename noise_scale to noise_bands

2024-06-16 Thread Lynne via ffmpeg-devel
This was a typo. --- libavcodec/aac/aacdec.h | 2 +- libavcodec/aac/aacdec_usac.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/aac/aacdec.h b/libavcodec/aac/aacdec.h index 86faf6454a..d1a80e9ac1 100644 --- a/libavcodec/aac/aacdec.h +++ b/libavcodec/aac/a

[FFmpeg-devel] [PATCH 5/6] aacdec_usac: remove custom rate_idx and use standard variable for it

2024-06-16 Thread Lynne via ffmpeg-devel
m4ac.sampling_index is what aacdec.c uses. --- libavcodec/aac/aacdec.h | 1 - libavcodec/aac/aacdec_usac.c | 35 ++- 2 files changed, 14 insertions(+), 22 deletions(-) diff --git a/libavcodec/aac/aacdec.h b/libavcodec/aac/aacdec.h index d1a80e9ac1..e5a79a7139

[FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-16 Thread Lynne via ffmpeg-devel
Currently, no eSBR features are supported. Thankfully, no encoders exist for it yet. --- libavcodec/aac/aacdec_usac.c | 119 +++--- libavcodec/aacsbr.h | 11 ++ libavcodec/aacsbr_template.c | 232 --- libavcodec/sbr.h | 32 +++-- 4

Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-17 Thread Lynne via ffmpeg-devel
On 17/06/2024 09:35, Anton Khirnov wrote: No tests? Tests for this particular part are tricky. We still have the SBR issue where we add a single sample of delay to the output, which the reference samples and their decodings do not. Adding a test would mean modifying the samples in a way wher

Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-17 Thread Lynne via ffmpeg-devel
On 17/06/2024 21:01, Lynne wrote: On 17/06/2024 09:35, Anton Khirnov wrote: No tests? Tests for this particular part are tricky. We still have the SBR issue where we add a single sample of delay to the output, which the reference samples and their decodings do not. Adding a test would mean m

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-06-18 Thread Lynne via ffmpeg-devel
On 17/06/2024 20:34, Michael Niedermayer wrote: On Tue, Apr 30, 2024 at 07:42:53PM +0200, Michael Niedermayer wrote: On Mon, Apr 22, 2024 at 01:32:27PM +0200, Lynne wrote: Apr 22, 2024, 13:07 by [email protected]: On date Sunday 2024-04-21 22:12:56 -0300, James Almer wrote: On 4/17/2024 10

Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-19 Thread Lynne via ffmpeg-devel
On 16/06/2024 10:54, Lynne wrote: Currently, no eSBR features are supported. Thankfully, no encoders exist for it yet. --- libavcodec/aac/aacdec_usac.c | 119 +++--- libavcodec/aacsbr.h | 11 ++ libavcodec/aacsbr_template.c | 232 --- lib

[FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-22 Thread Lynne via ffmpeg-devel
This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to more conveniently convert the values into floats without hardcoding specific conversion constants. The draft implementation of this mechanism for

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-22 Thread Lynne via ffmpeg-devel
On 22/06/2024 22:19, James Almer wrote: On 6/22/2024 5:11 PM, Lynne via ffmpeg-devel wrote: This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to more conveniently convert the values into floats

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-22 Thread Lynne via ffmpeg-devel
On 22/06/2024 23:30, James Almer wrote: On 6/22/2024 6:26 PM, Lynne via ffmpeg-devel wrote: On 22/06/2024 22:19, James Almer wrote: On 6/22/2024 5:11 PM, Lynne via ffmpeg-devel wrote: This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future

Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC

2024-06-23 Thread Lynne via ffmpeg-devel
On 20/06/2024 04:12, Lynne wrote: On 16/06/2024 10:54, Lynne wrote: Currently, no eSBR features are supported. Thankfully, no encoders exist for it yet. ---   libavcodec/aac/aacdec_usac.c | 119 +++---   libavcodec/aacsbr.h  |  11 ++   libavcodec/aacsbr_template.c | 232 ++

[FFmpeg-devel] [PATCH v2] lavu/stereo3d: change the horizontal FOV field to a rational

2024-06-23 Thread Lynne via ffmpeg-devel
This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to more conveniently convert the values into floats without hardcoding specific conversion constants. The API was committed 2 days ago, so changing t

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-23 Thread Lynne via ffmpeg-devel
On 23/06/2024 13:05, Derek Buitenhuis wrote: On 6/22/2024 9:11 PM, Lynne via ffmpeg-devel wrote: The API was committed 2 days ago, so changing these fields now is within the realms of acceptable. --- You also had weeks to comment on 3 revisions of the set, and it would have been nice to hear

Re: [FFmpeg-devel] [PATCH v2] lavu/stereo3d: change the horizontal FOV field to a rational

2024-06-24 Thread Lynne via ffmpeg-devel
On 24/06/2024 17:51, Derek Buitenhuis wrote: On 6/24/2024 1:13 AM, James Almer wrote: If Derek is also ok with this then LGTM. I do not object. - Derek ___ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: use correct NULL value for Vulkan type

2024-06-24 Thread Lynne via ffmpeg-devel
On 24/06/2024 20:48, Timo Rothenpieler wrote: --- fftools/ffplay_renderer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay_renderer.c b/fftools/ffplay_renderer.c index 80b700b3c5..f272cb46f1 100644 --- a/fftools/ffplay_renderer.c +++ b/fftools/ffplay_rendere

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-25 Thread Lynne via ffmpeg-devel
On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NULL. I have no real testcase to implement/test this, so failing in this case seems safest. Fixes: member access within null pointer of type 'AACDecContext' (aka 'stru

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-25 Thread Lynne via ffmpeg-devel
On 26/06/2024 01:57, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be set but some callers pass NULL. I have no real testcase to implement

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/aac/aacdec_usac: Test ac in usac

2024-06-26 Thread Lynne via ffmpeg-devel
On 26/06/2024 21:45, Andreas Rheinhardt wrote: Lynne via ffmpeg-devel: On 26/06/2024 01:57, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 01:35:18AM +0200, Lynne via ffmpeg-devel wrote: On 24/06/2024 01:01, Michael Niedermayer wrote: ff_aac_usac_config_decode() needs AACDecContext to be

[FFmpeg-devel] [RFC] patch for LTS release

2024-06-27 Thread jfrederich via ffmpeg-devel
Hello, we have found a minor bug in dshow.c that we would like to submit as a patch. Is it possible to submit a patch for 5.1.x LTS? Do I have to consider anything special for this? Best regards Jens ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables

2024-06-27 Thread Lynne via ffmpeg-devel
On 21/06/2024 23:20, Leo Izen wrote: int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. --- libavcodec/aac/aacdec_lpd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b/libavco

[FFmpeg-devel] [PATCH] lavc/hevcdsp_qpel_neon: using movi.16b instead of movi.2d

2023-11-14 Thread xufuji456 via ffmpeg-devel
Building iOS platform with arm64, the compiler has a warning: "instruction movi.2d with immediate #0 may not function correctly on this CPU, converting to movi.16b" Signed-off-by: xufuji456 <[email protected]> --- libavcodec/aarch64/hevcdsp_epel_neon.S | 136 - libavcodec

[FFmpeg-devel] [PATCH 1/2] avformat/flvenc: support enhanced flv PacketTypeMetadata

2023-11-15 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- libavformat/flvenc.c | 158 +++ 1 file changed, 158 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index f6d10f331c..615a072928 100644 --- a/liba

[FFmpeg-devel] [PATCH 2/2] avformat/flvdec: support enhanced flv PacketTypeMetadata

2023-11-15 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- libavformat/flvdec.c | 171 ++- 1 file changed, 170 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index e25b5bd163..46bb0825ca 10

[FFmpeg-devel] [PATCH 2/2] avcodec/amd: fix pict_type, match it with amf & ffmpeg. add sps pps when frame->keyframe

2023-11-15 Thread reito via ffmpeg-devel
The frame->key_frame currently doesn't set extra header into frames when using amf encoders. The frame->pict_type is not set to amf picture type, now we force it. Signed-off-by: reito --- libavcodec/amfenc.c | 52 + 1 file changed, 52 insertions(+) di

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/qsv: add sps pps header whenframe->key_frame is true

2023-11-18 Thread Reito via ffmpeg-devel
Hi, I'm new to here, what else should I do to finish this patch? Also, does another patch (PATCH 2/2 avcodec/amf) also need your signature?  Thanks 发自我的iPhone -- Original -- From: Michael Niedermayer https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubs

[FFmpeg-devel] [PATCH] avdevice/avfoundation: replace AVCaptureDevice with new api

2023-12-04 Thread xufuji456 via ffmpeg-devel
Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <[email protected]> --- libavdevice/avfoundation.m | 81 +++--- 1 f

[FFmpeg-devel] [PATCH] avdevice/avfoundation: replace AVCaptureDevice with new api

2023-12-05 Thread xufuji456 via ffmpeg-devel
Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <[email protected]> --- libavdevice/avfoundation.m | 25 - 1 file changed,

[FFmpeg-devel] [PATCH] avdevice/avfoundation: replace deprecated AVCaptureDevice

2023-12-06 Thread xufuji456 via ffmpeg-devel
Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <[email protected]> --- libavdevice/avfoundation.m | 23 ++- 1 file changed, 18

[FFmpeg-devel] [PATCH] avdevice/avfoundation: replace deprecated AVCaptureDevice

2023-12-09 Thread xufuji456 via ffmpeg-devel
Building with iOS platform, the compiler has a warning: "'devicesWithMediaType:' is deprecated: first deprecated in iOS 10.0 - Use AVCaptureDeviceDiscoverySession instead" Signed-off-by: xufuji456 <[email protected]> --- libavdevice/avfoundation.m | 65 +++--- 1 f

[FFmpeg-devel] [PATCH] avdevice/audiotoolbox: silence warning with new api

2023-12-09 Thread xufuji456 via ffmpeg-devel
Building with macOS platform, the compiler has a warning: 'kAudioObjectPropertyElementMaster' is deprecated in macOS 12.0 Signed-off-by: xufuji456 <[email protected]> --- libavdevice/audiotoolbox.m | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/audiotoolbox.m b/libavdevice/au

[FFmpeg-devel] [PATCH] gdigrab: Allow capturing a window by its handle

2023-12-10 Thread Lena via ffmpeg-devel
x11grab can capture windows by their ID, but gdigrab can only capture windows by their names, internally calling FindWindowW to lookup its handle. This patch simply allows the user to specify a window handle directly. Signed-off-by: Lena --- libavdevice/gdigrab.c | 6 +- 1 file changed, 5

Re: [FFmpeg-devel] [PATCH] gdigrab: Allow capturing a window by its handle

2023-12-10 Thread Lena via ffmpeg-devel
I'm so sorry, will resend immediately. Andreas Rheinhardt via ffmpeg-devel: Lena via ffmpeg-devel: x11grab can capture windows by their ID, but gdigrab can only capture windows by their names, internally calling FindWindowW to lookup its handle. This patch simply allows the user to sp

Re: [FFmpeg-devel] [PATCH] gdigrab: Allow capturing a window by its handle

2023-12-10 Thread Lena via ffmpeg-devel
x11grab can capture windows by their ID, but gdigrab can only capture windows by their names, internally calling FindWindowW to lookup its handle. This patch simply allows the user to specify a window handle directly. Signed-off-by: Lena --- libavdevice/gdigrab.c | 6 +- 1 file changed, 5 i

[FFmpeg-devel] [PATCH v2] gdigrab: Allow capturing a window by its handle

2023-12-12 Thread Lena via ffmpeg-devel
Added the change to the documentation and added error checking on `strtol`, according to the stdlib documentation. The documentation for `strtol` says that on error, 0 is returned. This makes it impossible to specify a window handle of 0 (the whole desktop), but that case is already covered by

[FFmpeg-devel] [PATCH v3] gdigrab: Allow capturing a window by its handle

2023-12-14 Thread Lena via ffmpeg-devel
Updated the wording of the documentation, and added error checking for strtol. I looked at how other parts of the codebase check for errors on strtol and implemented it that way (iec61883, filter_units_bsf, etc). As for checking if the string value is larger/smaller than a long, i don't think t

[FFmpeg-devel] [PATCH] avfilter/metal: fix compile below iOS 13

2023-12-16 Thread xufuji456 via ffmpeg-devel
Here is the msg: "libavfilter/metal/utils.m:35: error: 'MTLGPUFamilyCommon3' is only available on iOS 13.0" More Info: https://developer.apple.com/documentation/metal/mtlgpufamily/mtlgpufamilycommon3 Signed-off-by: xufuji456 <[email protected]> --- libavfilter/metal/utils.m | 2 +- 1 file change

[FFmpeg-devel] [PATCH v2 1/2] avformat/flvenc: support enhanced flv PacketTypeMetadata

2023-12-17 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- libavformat/flvenc.c | 155 +++ 1 file changed, 155 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index f6d10f331c..7268394b93 100644 --- a/liba

[FFmpeg-devel] [PATCH v2 2/2] avformat/flvdec: support enhanced flv PacketTypeMetadata

2023-12-17 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- libavformat/flvdec.c | 178 ++- 1 file changed, 177 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index e25b5bd163..6d40b4c7d5 10

[FFmpeg-devel] [PATCH v4] gdigrab: Allow capturing a window by its handle

2023-12-17 Thread Lena via ffmpeg-devel
Added more context in the error message and did a final test that it all works. Thanks for the smooth patch submission process! x11grab can capture windows by their ID, but gdigrab can only capture windows by their names, internally calling FindWindowW to lookup its handle. This patch simply a

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add MJPEG support

2024-03-28 Thread gnattu via ffmpeg-devel
For example: ./ffmpeg -hwaccel videotoolbox\ -i INPUT -c:v mjpeg_videotoolbox\ out.mp4 This encoder does not have many options and can only use ``-q:v` to control quality. Signed-off-by: Gnattu OC --- Changelog| 1 + configure| 2 ++ libavcodec/

Re: [FFmpeg-devel] 7.0 Name

2024-04-03 Thread RaDSL via ffmpeg-devel
On 4/3/2024 6:42 AM, Niklas Haas wrote: On Mon, 01 Apr 2024 19:42:29 -0400 Sean McGovern wrote: Hi, On Mon, Apr 1, 2024, 18:00 Lynne wrote: Apr 1, 2024, 22:01 [email protected]: Hi all I think we didnt decide on a name for 7.0 yet Previously suggested names: Darwin, De broglie,

[FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

2024-05-11 Thread Lynne via ffmpeg-devel
Unintentionally removed as part of 03cf10164578aed33f4d0cb5b69d63669c01a538. Untested, but its assumed that unlike most of the old ARM code, this one was still working. --- libavcodec/aac/aacdec_float.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/aac/aacdec_float.c b/libavc

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed

2024-05-11 Thread Lynne via ffmpeg-devel
On 12/05/2024 02:03, Michael Niedermayer wrote: Fixes: CID1473514 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/lpc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/lpc.c b/libavcodec/lpc

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed

2024-05-11 Thread Lynne via ffmpeg-devel
On 12/05/2024 02:18, Michael Niedermayer wrote: On Sun, May 12, 2024 at 02:13:06AM +0200, Lynne via ffmpeg-devel wrote: On 12/05/2024 02:03, Michael Niedermayer wrote: Fixes: CID1473514 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec/aacenc_tns: remove unreachable code branch

2024-05-12 Thread Lynne via ffmpeg-devel
On 12/05/2024 14:24, Yotam Ofek wrote: Nope :) Last commit that touched this was 9 years ago, seems like it's an oversight that was never noticed/fixed. The native AAC encoder is stable, even if this code was supposed to behave differently, it's probably good enough as is, and I think that having

Re: [FFmpeg-devel] [PATCH 6/8 v2] x86/flacdsp: add a SSE2 version of wasted32

2024-05-12 Thread Lynne via ffmpeg-devel
On 12/05/2024 20:51, James Almer wrote: flac_wasted_32_c: 851.3 flac_wasted_32_sse2: 41.3 Signed-off-by: James Almer --- libavcodec/x86/flacdsp.asm| 24 libavcodec/x86/flacdsp_init.c | 3 +++ 2 files changed, 27 insertions(+) diff --git a/libavcodec/x86/flacds

Re: [FFmpeg-devel] [PATCH] aacdec: restore arm32 dequantization optimizations

2024-05-13 Thread Lynne via ffmpeg-devel
On 13/05/2024 12:13, Martin Storsjö wrote: On Sat, 11 May 2024, Lynne via ffmpeg-devel wrote: Unintentionally removed as part of 03cf10164578aed33f4d0cb5b69d63669c01a538. Untested, but its assumed that unlike most of the old ARM code, this one was still working. --- libavcodec/aac

Re: [FFmpeg-devel] [PATCH] Revert "lavc/sbrdsp: R-V V neg_odd_64"

2024-05-13 Thread Lynne via ffmpeg-devel
On 13/05/2024 18:43, Rémi Denis-Courmont wrote: While this function can easily be written with vectors, it just fails to get any performance improvement. For reference, this is a simpler loop-free implementation that does get better performance than the current one depending on hardware, but sti

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-14 Thread Lynne via ffmpeg-devel
On 14/05/2024 17:09, Christian Bartnik wrote: From: Thomas Siedel Add external decoder VVdeC for H266/VVC decoding. Register new decoder libvvdec. Add libvvdec to wrap the vvdec interface. Enable decoder by adding --enable-libvvdec in configure step. Co-authored-by: Christian Bartnik chris1031

[FFmpeg-devel] [PATCH] aacdec: move from scalefactor ranged arrays to flat arrays

2024-05-14 Thread Lynne via ffmpeg-devel
AAC uses an unconventional system to send scalefactors (the volume+quantization value for each band). Each window is split into either 1 or 8 blocks (long vs short), and transformed separately from one another, with the coefficients for each being also completely independent. The scalefactors sligh

Re: [FFmpeg-devel] [PATCH v4 3/4] all: Link to "context" from all contexts with documentation

2024-05-15 Thread Lynne via ffmpeg-devel
On 15/05/2024 17:54, Andrew Sayers wrote: Some headings needed to be rewritten to accomodate the text, (hopefully) without changing the meaning. --- libavcodec/aac/aacdec.h| 2 +- libavcodec/aacenc.h| 2 +- libavcodec/ac3enc.h| 2 +- libavcodec/

[FFmpeg-devel] [PATCH 0/8] aacdec: add a native xHE-AAC decoder

2024-05-16 Thread Lynne via ffmpeg-devel
This commit adds a decoder for the frequency-domain part of USAC. What works: - Mono - Stereo (no prediction) - Stereo (mid/side coding) What doesn't: - Preroll decoding (every single decoder seems faulty or weird?) - Complex stereo prediction Known issues: - Spec incompliance due to the s

[FFmpeg-devel] [PATCH 1/8] aacdec: move from scalefactor ranged arrays to flat arrays

2024-05-16 Thread Lynne via ffmpeg-devel
AAC uses an unconventional system to send scalefactors (the volume+quantization value for each band). Each window is split into either 1 or 8 blocks (long vs short), and transformed separately from one another, with the coefficients for each being also completely independent. The scalefactors sligh

[FFmpeg-devel] [PATCH 3/8] aacdec: expose decode_tns

2024-05-16 Thread Lynne via ffmpeg-devel
USAC has the same syntax, with one minor change we can check for. --- libavcodec/aac/aacdec.c | 6 +++--- libavcodec/aac/aacdec.h | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 40554ff9e4..a7e5b2a369 100644 --- a/liba

[FFmpeg-devel] [PATCH 2/8] aacdec: expose channel layout related functions

2024-05-16 Thread Lynne via ffmpeg-devel
--- libavcodec/aac/aacdec.c | 73 - libavcodec/aac/aacdec.h | 19 +-- 2 files changed, 51 insertions(+), 41 deletions(-) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index 35722f9b9b..40554ff9e4 100644 --- a/libavcodec/aac/aacdec.c

[FFmpeg-devel] [PATCH 4/8] aacdec_dsp: implement 768-point transform and windowing

2024-05-16 Thread Lynne via ffmpeg-devel
Required for USAC --- libavcodec/aac/aacdec.c | 4 ++ libavcodec/aac/aacdec.h | 5 +++ libavcodec/aac/aacdec_dsp_template.c | 67 libavcodec/aac/aacdec_fixed.c| 2 + libavcodec/aac/aacdec_float.c| 4 ++ libavcodec/sinewin_f

[FFmpeg-devel] [PATCH 5/8] aactab: add deemphasis tables for USAC

2024-05-16 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 25 + libavcodec/aactab.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 3718b81a07..8ce5e43974 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -3377,3 +3377,28 @@ const DECLAR

[FFmpeg-devel] [PATCH 6/8] aactab: add tables for the new USAC arithmetic coder

2024-05-16 Thread Lynne via ffmpeg-devel
--- libavcodec/aactab.c | 376 libavcodec/aactab.h | 6 + 2 files changed, 382 insertions(+) diff --git a/libavcodec/aactab.c b/libavcodec/aactab.c index 8ce5e43974..dfb2dfd98d 100644 --- a/libavcodec/aactab.c +++ b/libavcodec/aactab.c @@ -1193,6 +11

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2024-02-11 Thread asivery via ffmpeg-devel
I apologize for not having responded earlier. I've attached the updated patch. >From 68c77320954e44a7f02e95537fc9a6436da7549c Mon Sep 17 00:00:00 2001 From: asivery Date: Sun, 11 Feb 2024 23:13:07 +0100 Subject: [PATCH] avformat/matroska: Add support for A_ATRAC/AT1 Signed-off-by: asivery ---

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2024-02-12 Thread asivery via ffmpeg-devel
I've attached the updated patch. Both new entries are now placed in an alphabetically correct way in their appropriate lists. On Monday, February 12th, 2024 at 11:53 AM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > I apologize for not having responded

[FFmpeg-devel] [PATCH] libavformat/rtpenc_jpeg.c: Added support for DRI frames in MJPEG RTP packetization

2024-02-19 Thread rayjay via ffmpeg-devel
Signed-off-by: rayjay <[email protected]> --- libavformat/rtpenc_jpeg.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/rtpenc_jpeg.c b/libavformat/rtpenc_jpeg.c index e4e95931f4..721c02ff76 100644 --- a/libavformat/rtpenc_jpeg.c +++ b/libavformat/rtpenc_jpeg.c @@ -3

[FFmpeg-devel] [PATCH] avfilter: add vf_overlay_videotoolbox

2024-02-20 Thread gnattu via ffmpeg-devel
Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will perform format conversion automatically with hardware accelerated methods. Signed-off-by: Gnattu OC --- Changelog

[FFmpeg-devel] [PATCH v2] Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will pe

2024-02-20 Thread gnattu via ffmpeg-devel
Signed-off-by: Gnattu OC --- Changelog | 1 + configure | 1 + doc/filters.texi | 52 +++ libavfilter/Makefile | 3 +++ libavfilter/allfilters.c | 1 + libavfilter/metal/utils.h | 1 - libavfilter/metal/utils.

[FFmpeg-devel] [PATCH v2] avfilter: add vf_overlay_videotoolbox

2024-02-20 Thread gnattu via ffmpeg-devel
Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will perform format conversion automatically with hardware accelerated methods. Signed-off-by: Gnattu OC --- Changelog

[FFmpeg-devel] [PATCH v3] avfilter: add vf_overlay_videotoolbox

2024-02-20 Thread gnattu via ffmpeg-devel
Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will perform format conversion automatically with hardware accelerated methods. Signed-off-by: Gnattu OC --- Changelog

[FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread gnattu via ffmpeg-devel
There is no device context to be setup, nor devices to be selected with VideoToolbox. Just a simple return would allow us to use derived device in filters like `hwupload=derive_device=videotoolbox` Signed-off-by: Gnattu OC --- libavutil/hwcontext_videotoolbox.c | 9 + 1 file changed, 9 i

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread ChenLiucheng via ffmpeg-devel
to upload to the OpenCL device without `device_derive` set if it comes after an OpenCL filter. > On Feb 23, 2024, at 03:28, Mark Thompson wrote: > > On 22/02/2024 18:46, gnattu via ffmpeg-devel wrote: >> There is no device context to be setup, nor devices to be >> selec

[FFmpeg-devel] [PATCH v4] avfilter: add vf_overlay_videotoolbox

2024-02-27 Thread gnattu via ffmpeg-devel
Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will perform format conversion automatically with hardware accelerated methods. Signed-off-by: Gnattu OC --- Changes from v3: - F

[FFmpeg-devel] [PATCH v4 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-02 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- libavformat/flvdec.c | 178 ++- 1 file changed, 177 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index e25b5bd163..d0806c5338 10

[FFmpeg-devel] [PATCH v4 2/3] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-03-02 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- libavformat/flvenc.c | 142 +++ 1 file changed, 142 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index f6d10f331c..ae7ea84bad 100644 --- a/liba

[FFmpeg-devel] [PATCH v4 3/3] fate/flvenc: support enhanced flv PacketTypeMetadata

2024-03-02 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- tests/fate/lavf-container.mak| 2 ++ tests/ref/fate/enhanced-flv-hevc | 4 ++-- tests/ref/fate/enhanced-flv-vp9 | 4 ++-- tests/ref/lavf-fate/hevc.flv | 3 +++ 4 files changed, 9 insertions(+), 4 delet

Re: [FFmpeg-devel] [PATCH v4 2/3] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-03-02 Thread zhupengfei via ffmpeg-devel
> 2024年3月2日 22:59,Andreas Rheinhardt 写道: > > zhupengfei via ffmpeg-devel: >> From: Zhu Pengfei <[email protected]> >> >> Signed-off-by: Zhu Pengfei <[email protected]> >> --- >> libavformat/flvenc.c | 142 ++

[FFmpeg-devel] [PATCH v5 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-04 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- libavformat/flvdec.c | 177 ++- 1 file changed, 176 insertions(+), 1 deletion(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index e25b5bd163..2a0aec7291 10

[FFmpeg-devel] [PATCH v5 2/3] avformat/flvenc: support enhanced flv PacketTypeMetadata

2024-03-04 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- libavformat/flvenc.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index f6d10f331c..261e5d800c 100644 --- a/liba

[FFmpeg-devel] [PATCH v5 3/3] fate/flvenc: support enhanced flv PacketTypeMetadata

2024-03-04 Thread zhupengfei via ffmpeg-devel
From: Zhu Pengfei <[email protected]> Signed-off-by: Zhu Pengfei <[email protected]> --- tests/fate/lavf-container.mak| 2 ++ tests/ref/fate/enhanced-flv-hevc | 4 ++-- tests/ref/fate/enhanced-flv-vp9 | 4 ++-- tests/ref/lavf-fate/hevc.flv | 3 +++ 4 files changed, 9 insertions(+), 4 delet

[FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
Empty MessageFrom 955fc035abbb5cfc1a52b1a5ea6900e4a21cef12 Mon Sep 17 00:00:00 2001 From: asivery Date: Fri, 8 Mar 2024 11:17:51 +0100 Subject: [PATCH] avformat/aea: Add aea muxer Signed-off-by: asivery --- libavformat/Makefile| 3 +- libavformat/{aea.c => aeadec.c} | 0 libavfo

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
Apologies for my oversight. I've attached the new patch. - asivery On Friday, March 8th, 2024 at 12:22 PM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > diff --git a/libavformat/allformats.c b/libavformat/allformats.c > > index b04b43cab3..1a50

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
; asivery via ffmpeg-devel: > > > +typedef struct { > > + int block_count; > > +} AeaMuxerContext; > > + > > +static int aea_init(AVFormatContext *s) > > +{ > > + AeaMuxerContext *c = s->priv_data; > > + c->block_count = 0; > > >

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-09 Thread asivery via ffmpeg-devel
uncated to UINT32_MAX if needed. Is there anything else that needs changes? - asivery On Saturday, March 9th, 2024 at 1:06 PM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > +#include "libavutil/intreadwrite.h" > > +#include "libavutil/avstri

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-09 Thread asivery via ffmpeg-devel
I see, I've changed title_length to size_t, but left the warning as is to inform the user in case truncation needs to take place. On Saturday, March 9th, 2024 at 6:48 PM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > + const char *title_contents = t

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-10 Thread asivery via ffmpeg-devel
Great, thank you very much! I'm attaching the (hopefully) final version of the patch. MD studio was a piece of software created by a company called "EDL", which in combination with alternative firmware for the Sony MDH-10 MiniDisc recorder (https://www.minidisc.wiki/equipment/sony/misc/mdh-10) l

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-12 Thread asivery via ffmpeg-devel
Thank you Stefano Sabatini and Andreas Rheinhardt - you guys have the patience of saints. On Tuesday, March 12th, 2024 at 11:27 AM, Stefano Sabatini wrote: > On date Sunday 2024-03-10 16:10:15 +0100, Stefano Sabatini wrote: > > > On date Sunday 2024-03-10 14:20:12 +, ffmpeg-devel Mailing

Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-07-02 Thread Lynne via ffmpeg-devel
On 15/06/2024 18:05, Tong Wu wrote: From: ffmpeg-devel On Behalf Of Lynne via ffmpeg-devel Sent: Monday, June 10, 2024 10:01 AM To: FFmpeg development discussions and patches Cc: Lynne Subject: Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_usac: Fix array size

2024-07-02 Thread Lynne via ffmpeg-devel
On 02/07/2024 23:25, Marvin Scholz wrote: The array in ff_aac_usac_mdst_filt_cur that is passed to that has a size of 7 elements, not 6 and the code in the function accesses the array at index 6, which would be out of bounds if the size was actually 6. Fixes: CID1603196 --- libavcodec/aac/aacd

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio

2024-07-02 Thread Lynne via ffmpeg-devel
On 01/07/2024 01:12, Michael Niedermayer wrote: Fixes: CID1605475 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec_usac.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacd

Re: [FFmpeg-devel] [PATCH] avcodec/aaccoder_twoloop: remove unread max scaler

2024-07-02 Thread Lynne via ffmpeg-devel
On 14/06/2024 12:21, Yotam Ofek wrote: --- libavcodec/aaccoder_twoloop.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h index c1dcdbb5ed..c56abc68a7 100644 --- a/libavcodec/aaccoder_twoloop.h +++ b/libavcodec

[FFmpeg-devel] [PATCH 1/2] avformat/aeadec, avcodec/atrac1: Fix 8 and 4-channel ATRAC1 support

2024-07-03 Thread asivery via ffmpeg-devel
I'm sending the patch again, so that it is correctly rebased on the current master. Here are the two sample files required by the FATE test: https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcm Please let me know if I need to pro

<    1   2   3   4   5   6   7   8   9   10   >