[FFmpeg-devel] Re: [RFC] C++

2025-10-22 Thread Leo Izen via ffmpeg-devel
On 10/20/25 13:50, Tomas Härdin via ffmpeg-devel wrote: Hi I'm writing this email to get a feel for how everyone feels about making more use of C++ in the codebase. I am only proposing using C++ *internally*, and only where it makes sense. I am not suggesting a "move" to C++, merely using featur

[FFmpeg-devel] [PATCH] avcodec/exif: avoid printing errors for makernote non-IFD parsing (PR #20604)

2025-09-24 Thread Leo Izen via ffmpeg-devel
PR #20604 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20604 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20604.patch When we parse a MakerNote, we first try to parse it as an IFD and if that fails, we try to re-parse it as a binary blob. This is becau

[FFmpeg-devel] [PATCH] avcodec/pngenc: include EXIF buffer in max_packet_size (PR #20539)

2025-09-17 Thread Leo Izen via ffmpeg-devel
PR #20539 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20539 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20539.patch When calculating the max size of an output PNG packet, we should include the size of a possible eXIf chunk that we may write. Signed-

[FFmpeg-devel] [PATCH] avcodec/decode: treat orientation 1 as valid displaymatrix (PR #20447)

2025-09-05 Thread Leo Izen via ffmpeg-devel
PR #20447 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20447 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20447.patch Since 9dc79241d9680fc050376bb0cc37875a41d00cc9 we now always pop the orientation off of the IFD and use a display matrix instead. This

[FFmpeg-devel] [PATCH] .forge/CODEOWNERS: add myself to EXIF code (PR #20369)

2025-08-29 Thread Leo Izen via ffmpeg-devel
PR #20369 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20369 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20369.patch Now that the major EXIF overhaul has been merged, I should be suggested to review patches that modify it. Signed-off-by: Leo Izen

[FFmpeg-devel] [PATCH] avcodec/libjxldec: consume input on error (PR #20355)

2025-08-27 Thread Leo Izen via ffmpeg-devel
PR #20355 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20355 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20355.patch libjxl consumes no input if it returns an error, so this loops over and over while it spits out the same error many times. If we got a

[FFmpeg-devel] [PATCH] libjxldec/libjxlenc: fix leaks (PR #20352)

2025-08-27 Thread Leo Izen via ffmpeg-devel
PR #20352 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20352 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20352.patch Fix leaks. We forgot to free these. >From a8d6b87a4442c690587db6f44cc7ed72a2de81fc Mon Sep 17 00:00:00 2001 From: Leo Izen Date: We

[FFmpeg-devel] [PATCH] avcodec/libjxldec: submit frame after file is complete (PR #20337)

2025-08-25 Thread Leo Izen via ffmpeg-devel
PR #20337 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20337 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20337.patch This commit causes the libjxl decoder wrapper to hold onto the decoded frame until the trailing metadata after the frame is possibly c

[FFmpeg-devel] [PATCH] Two exif Fixes (PR #20326)

2025-08-24 Thread Leo Izen via ffmpeg-devel
PR #20326 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20326 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20326.patch Fixes for two EXIF bugs, notably #20305 and #20291. >From c9e86ffd2ae9b3f296b761f3d7c2f10d69a46840 Mon Sep 17 00:00:00 2001 From: Le

[FFmpeg-devel] [PATCH] avcodec/exif: fix some coverity errors (PR #20296)

2025-08-20 Thread Leo Izen via ffmpeg-devel
PR #20296 opened by Leo Izen (Traneptora) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20296 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20296.patch This commit fixes some memory and security issues due to improper sanitizing and checks. Fixes: - CID 1665100..1665107 Signed-off-b