[FFmpeg-devel] Re: question about submitting security patches

2025-11-10 Thread Rémi Denis-Courmont via ffmpeg-devel
Le 11 novembre 2025 04:59:42 GMT+02:00, Michael Niedermayer via ffmpeg-devel a écrit : >Hi Remi > >On Mon, Nov 10, 2025 at 06:03:38PM +0200, Rémi Denis-Courmont via ffmpeg-devel >wrote: >> Le lauantaina 8. marraskuuta 2025, 10.34.24 Itä-Euroopan normaaliaika Thomas >> Dullien via ffmpeg-devel

[FFmpeg-devel] [PATCH] swscale/ops: fix ff_sws_pixel_type_to_uint (PR #20891)

2025-11-10 Thread cancername via ffmpeg-devel
PR #20891 opened by cancername URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20891 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20891.patch ff_sws_pixel_type_size uses size in bytes, not bits, but ff_sws_pixel_type_to_uint assumes size in bits. ff_sws_pixel_type_to_uint is never cal

[FFmpeg-devel] Re: [PATCH] avformat/mpjpegdec: add support for X-Timestamp and X-Framerate headers

2025-11-10 Thread Michael Niedermayer via ffmpeg-devel
Hi Vladimir On Sun, Nov 09, 2025 at 02:38:56AM +0200, Vladimir Sobolev via ffmpeg-devel wrote: > >From 31d73c6774c1ea6d621db57f26439e297cc23c3d Mon Sep 17 00:00:00 2001 > From: Vladimir Sobolev > Date: Sun, 9 Nov 2025 02:28:13 +0200 > Subject: [PATCH] avformat/mpjpegdec: add support for X-Timest

[FFmpeg-devel] Re: question about submitting security patches

2025-11-10 Thread Michael Niedermayer via ffmpeg-devel
Hi Remi On Mon, Nov 10, 2025 at 06:03:38PM +0200, Rémi Denis-Courmont via ffmpeg-devel wrote: > Le lauantaina 8. marraskuuta 2025, 10.34.24 Itä-Euroopan normaaliaika Thomas > Dullien via ffmpeg-devel a écrit : > > What's the best way to submit these patches? There is the bug tracker, > > there i

[FFmpeg-devel] Re: [PATCH] libavfilter: Fix incorrect ebur128 peak calculation.

2025-11-10 Thread Michael Niedermayer via ffmpeg-devel
Hi adding niklas to the CC so its not missed but i agree the patch LGTM On Tue, Nov 04, 2025 at 08:52:36PM +0100, Nicolas George via ffmpeg-devel wrote: > Carl Hetherington via ffmpeg-devel (HE12025-11-03): > > Since 3b26b782eeded9b9ab7fac013cd1a83a30d68206 it would only look at the > > first cha

[FFmpeg-devel] Re: [RFC] performance tuning, memcpy

2025-11-10 Thread Niklas Haas via ffmpeg-devel
On Monday, November 10th, 2025 at 3:09 PM, Thilo Schunck via ffmpeg-devel wrote: > > > Hi Team! > > Apologies for maybe breaking submit rules but as of now I don't know better > :-) > > I figured out on arm "hwdownload" is quite slow. > I turns out this is caused by imgutils.c image_copy_pl

[FFmpeg-devel] [PATCH] Re-initialize stream on new metadata. (PR #20890)

2025-11-10 Thread toots via ffmpeg-devel
PR #20890 opened by toots URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20890 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20890.patch >From 7993a24cf4062fc4ed943ec5f3e66b0bbb325741 Mon Sep 17 00:00:00 2001 From: Romain Beauxis Date: Fri, 14 Mar 2025 00:27:04 -0500 Subject: [PATCH]

[FFmpeg-devel] Re: [REFUND-REQUEST] VDD'25 travel expense

2025-11-10 Thread Niklas Haas via ffmpeg-devel
On Monday, November 10th, 2025 at 10:55 PM, Stefano Sabatini via ffmpeg-devel wrote: > > On Sat, Nov 8, 2025 at 2:31 AM Michael Niedermayer via ffmpeg-devel > [email protected] wrote: > > > On Mon, Nov 03, 2025 at 12:07:24PM +0100, Niklas Haas via ffmpeg-devel > > wrote: > > > > > Hi al

[FFmpeg-devel] Re: [REFUND-REQUEST] VDD'25 travel expense

2025-11-10 Thread Stefano Sabatini via ffmpeg-devel
On Sat, Nov 8, 2025 at 2:31 AM Michael Niedermayer via ffmpeg-devel wrote: > > On Mon, Nov 03, 2025 at 12:07:24PM +0100, Niklas Haas via ffmpeg-devel wrote: > > Hi all, > > > > I travelled to VDD'25 where I held two talks, one of which was directly > > related to FFmpeg. I am hereby requesting rei

[FFmpeg-devel] Re: question about submitting security patches

2025-11-10 Thread Thomas Dullien via ffmpeg-devel
Hey there, I've ended up creating a PR and made sure the patch code itself is human-written, hence untainted - LLMs are just used in the crash triage and analysis. Thanks for the reply! One (open) question: is generating commit messages by an LLM permissible, or is that something that should al

[FFmpeg-devel] [PATCH] avformat/riff: add support for HEAACWAVEFORMAT (PR #20888)

2025-11-10 Thread James Almer via ffmpeg-devel
PR #20888 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20888 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20888.patch This is an extension to WAVEFORMATEX used for some AAC streams, defined in the Windows SDK. Fixes issue #20887. >From 05a6c683e9a3

[FFmpeg-devel] Re: question about submitting security patches

2025-11-10 Thread Rémi Denis-Courmont via ffmpeg-devel
Le lauantaina 8. marraskuuta 2025, 10.34.24 Itä-Euroopan normaaliaika Thomas Dullien via ffmpeg-devel a écrit : > What's the best way to submit these patches? There is the bug tracker, > there is this mailing list - what's the best way to contribute them? I don't think that DNN-generated patches

[FFmpeg-devel] [PATCH] fftools: Fix MediaCodec on Android15+ (PR #20886)

2025-11-10 Thread Dmitrii Okunev via ffmpeg-devel
PR #20886 opened by Dmitrii Okunev (xaionaro) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20886 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20886.patch On Android15+ MediaCodec HAL backend was switched from HIDL to AIDL. As a result, MediaCodec operations started to hang, see:

[FFmpeg-devel] [PATCH] fftools: Fix MediaCodec on Android15+

2025-11-10 Thread xaionaro--- via ffmpeg-devel
From: Dmitrii Okunev On Android15+ MediaCodec HAL backend was switched from HIDL to AIDL. As a result, MediaCodec operations started to hang, see: https://github.com/termux/termux-packages/issues/21264 To fix that it is necessary to initialize binder thread pool. Signed-off-by: Dmitrii Oku

[FFmpeg-devel] question about submitting security patches

2025-11-10 Thread Thomas Dullien via ffmpeg-devel
Hey all, after the recent social media discussion around P0 reported bugs etc. I'd like to contribute a few patches for a few open crash bugs in the bugtracker (and hopefully for the remaining BIGSLEEP bug reports, too). I am using a coding assistant combined with a stack of ASAN + rr, and while

[FFmpeg-devel] [PATCH] avcodec/rv60dec: add upper bound check for qp

2025-11-10 Thread Reaxx via ffmpeg-devel
This patch fixes an out-of-bounds read in the RV60 decoder where qp can reach 65, exceeding the rv60_qp_to_idx[64] array bounds. The previous fix (61cbcaf93f) only covered intra frames. This adds validation at the source for all frame types. 0001-avcodec-rv60dec-add-upper-bound-check-for-qp.patch

[FFmpeg-devel] [PATCH] avcodec/tiff: Check order only for tags that we process

2025-11-10 Thread Mathias Koehler via ffmpeg-devel
The initial out of order check was introduced with commit ad29f9e47cb avcodec/tiff: Restrict tag order based on specification This changes the check to only check against tags the we process since tags that we don't process shouldn't cause any bugs. Example of CinemaDNG files with incorrect order

[FFmpeg-devel] [RFC] performance tuning, memcpy

2025-11-10 Thread Thilo Schunck via ffmpeg-devel
Hi Team! Apologies for maybe breaking submit rules but as of now I don't know better :-) I figured out on arm "hwdownload" is quite slow. I turns out this is caused by imgutils.c image_copy_plane which does a memcpy loop for (;height > 0; height--) { memcpy(dst, src, bytewidth);

[FFmpeg-devel] Re: [GASPP PATCH] Handle .drectve sections with armasm

2025-11-10 Thread Martin Storsjö via ffmpeg-devel
On Sat, 8 Nov 2025, Martin Storsjö wrote: This is used for embedding directives in COFF objects for the linker (e.g. for dllexport). --- Will push within a day or two, this is quite uncontroversial. --- gas-preprocessor.pl | 1 + 1 file changed, 1 insertion(+) Pushed this one now. // Martin __

[FFmpeg-devel] [PATCH] Revert "Re-initialize stream on new metadata." (PR #20885)

2025-11-10 Thread Martin Storsjö via ffmpeg-devel
PR #20885 opened by Martin Storsjö (mstorsjo) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20885 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20885.patch This reverts commit 7b18eafabd7cfd9e179dc28ae93911437faa. That commit added tests that don't work on Windows, and which also

[FFmpeg-devel] [PATCH] avfilter/vf_libplacebo: fix a more edge cases when combining rotated video with custom fit modes (PR #20884)

2025-11-10 Thread Niklas Haas via ffmpeg-devel
PR #20884 opened by Niklas Haas (haasn) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20884 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20884.patch This whole logic is beginning to get rather annoying and I'm starting to feel like a whole redesign is needed. >From 2cc48b34340738f3

[FFmpeg-devel] [PATCH] swscale/yuv2rgb: fix out-of-bounds access with odd srcSliceH in YUV422 (PR #20883)

2025-11-10 Thread thomasdullien via ffmpeg-devel
PR #20883 opened by thomasdullien URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20883 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20883.patch For transparency: I am experimenting with an AI-assisted patch process, where the AI agent attempts to help root-cause analyze a crash by mea

[FFmpeg-devel] [PATCH] avcodec/nvenc: fix -Wenum-conversion on colorspace/pri/trc (PR #20882)

2025-11-10 Thread Zhao Zhili via ffmpeg-devel
PR #20882 opened by Zhao Zhili (quink) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20882 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20882.patch >From 9fddad48ada500acaf0c1320cee74cebb4432dae Mon Sep 17 00:00:00 2001 From: Zhao Zhili Date: Mon, 10 Nov 2025 16:44:49 +0800 Subject: