Re: [FFmpeg-devel] [PATCH] avformat/dump: lowercase 'Start' prefix for start offset

2025-06-14 Thread Marton Balint
On Sun, 15 Jun 2025, Marth64 wrote: Just applying some UX polish. This is to match the lowercase trend of attributes in the dump string (and similar to chapters). Signed-off-by: Marth64 --- libavformat/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dum

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Add -reprobe_stream_if_pmt_es_stream_type_changes option

2025-06-14 Thread Marton Balint
On Sat, 14 Jun 2025, Pavel Koshevoy wrote: Make runtime AVStream.codecpar codec_id updates optional and disabled by default, so that avformat API clients can enable this feature explicitly when they add support for runtime codec changes. --- libavformat/mpegts.c | 8 +++- tests/fate/demux.

[FFmpeg-devel] [PATCH] avformat/dump: lowercase 'Start' prefix for start offset

2025-06-14 Thread Marth64
Just applying some UX polish. This is to match the lowercase trend of attributes in the dump string (and similar to chapters). Signed-off-by: Marth64 --- libavformat/dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index c263921b9

Re: [FFmpeg-devel] [PATCH v5 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-06-14 Thread Emma Worley
> Hi, > > It seems to be failing on Windows ARM64 MSVC build. See for details: > https://github.com/kasper93/FFmpeg/actions/runs/15656127992/job/44107440896 > > The test output doesn't match. > > -0, 0, 0, 1, 76190, 0x0e6f0326 > +0, 0, 0, 1, 74457, 0x2ef5e716 > Test dxv3enc-dxt1 failed. Look at tes

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: remove unused has_cc field

2025-06-14 Thread Marth64
Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index f92c5ae54a..40f5e0ac95 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@ -80,7 +80,6 @@ typedef struct DVDV

Re: [FFmpeg-devel] [PATCH] avfilter/vf_thumbnail: support high bit depth formats

2025-06-14 Thread Andreas Rheinhardt
Niklas Haas: > From: Niklas Haas > > Implementation is the same as 8 bit formats, just right shifted to 8 bits. > > It's worth pointing out that this also works for HDR formats (and even DV), > because the underlying implementation is just trying to minimize the histogram > difference. If anythi

Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-14 Thread Andreas Rheinhardt
Jack Lau via ffmpeg-devel: > api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem > > In higher versions (openssl 1.0.2 and higher), > the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), > so passing a const string doesn't cause an warnings. > However, in lower versions of

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Add -reprobe_stream_if_pmt_es_stream_type_changes option

2025-06-14 Thread Andreas Rheinhardt
Pavel Koshevoy: > Make runtime AVStream.codecpar codec_id updates optional and disabled > by default, so that avformat API clients can enable this feature explicitly > when they add support for runtime codec changes. > --- > libavformat/mpegts.c | 8 +++- > tests/fate/demux.mak | 2 +- > 2 fil

Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-14 Thread softworkz .
From: ffmpeg-devel on behalf of softworkz . Sent: Sunday, June 15, 2025 3:20 AM To: Kacper Michajlow; FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build __

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Add -reprobe_stream_if_pmt_es_stream_type_changes option

2025-06-14 Thread Pavel Koshevoy
On Sat, Jun 14, 2025 at 3:56 PM Michael Niedermayer wrote: > On Sat, Jun 14, 2025 at 01:58:28PM -0600, Pavel Koshevoy wrote: > > Make runtime AVStream.codecpar codec_id updates optional and disabled > > by default, so that avformat API clients can enable this feature > explicitly > > when they ad

Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-14 Thread softworkz .
From: Kacper Michajlow Sent: Sunday, June 15, 2025 12:48 AM To: FFmpeg development discussions and patches Cc: [email protected] Subject: graph.{html,css} embed failure on Windows build Hello, Since the recent addition of resman.c and embedding of

[FFmpeg-devel] [PATCHv2] configure: add celp_math component

2025-06-14 Thread Peter Ross
libavcodec/tests/celp_math depends on libavcodec/celp_math.o This fixes fate when configuring with --disable-everything --- patch v2: also add celp_math component to libavcodec/mips/Makefile configure | 13 - libavcodec/Makefile | 17 + libavcod

Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-14 Thread Michael Niedermayer
Hi Kacper On Sun, Jun 15, 2025 at 12:48:50AM +0200, Kacper Michajlow wrote: > Hello, > > Since the recent addition of resman.c and embedding of > graph.{html,css} some of the Windows builds fail. There seems to be a > regression in path joining, caused by \ / mismatch. > > Generally those issues

Re: [FFmpeg-devel] [PATCH v5 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-06-14 Thread Kacper Michajlow
On Fri, 25 Apr 2025 at 18:05, Emma Worley wrote: > > Improves compatibility with Resolume products by adding an additional > hashtable for DXT color+LUT combinations, and padding the DXT texture > dimensions to the next largest multiple of 16. Produces identical > packets to Resolume Alley in manu

Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-06-14 Thread Michael Niedermayer
On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote: > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 using a flat > memory storage for the extradata. > > PR review comments addressed: > * Use flat memory bytestream > * Re-use existing xiph extradata layout > > --- > liba

Re: [FFmpeg-devel] [PATCH v5] gcc: Don't disable '-ftree-vectorize' if gcc version higher than 13.

2025-06-14 Thread Michael Niedermayer
Hi Martin On Fri, Jun 13, 2025 at 11:42:11AM +0300, Martin Storsjö wrote: > On Fri, 13 Jun 2025, Jiawei wrote: > > > This patch modifies the FFmpeg build system to allow GCC to use the > > `-ftree-vectorize` flag when the compiler version is 13 or newer. > > Enabling this flag can improve perform

[FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-14 Thread Kacper Michajlow
Hello, Since the recent addition of resman.c and embedding of graph.{html,css} some of the Windows builds fail. There seems to be a regression in path joining, caused by \ / mismatch. Generally those issues were never a problem and I would prefer to keep it this way. This configuration has always

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Add -reprobe_stream_if_pmt_es_stream_type_changes option

2025-06-14 Thread Michael Niedermayer
On Sat, Jun 14, 2025 at 01:58:28PM -0600, Pavel Koshevoy wrote: > Make runtime AVStream.codecpar codec_id updates optional and disabled > by default, so that avformat API clients can enable this feature explicitly > when they add support for runtime codec changes. > --- > libavformat/mpegts.c | 8

Re: [FFmpeg-devel] [PATCH] rtpdec: explicit timestamp wraparound handling

2025-06-14 Thread Michael Niedermayer
On Sun, Jun 08, 2025 at 05:07:37PM +0200, Clément Péron wrote: > Change delta_timestamp to int32_t and add explicit cast to handle > RTP timestamp wraparound correctly. This fixes implementation-defined > behavior when computing negative timestamp differences due to 32-bit > wraparound. > > Signed

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mpegts: update stream info when PMT ES stream_type changes"

2025-06-14 Thread Michael Niedermayer
On Fri, Jun 13, 2025 at 04:06:31PM -0600, Pavel Koshevoy wrote: > On Fri, Jun 13, 2025 at 2:46 PM Michael Niedermayer > wrote: > > > On Mon, Jun 09, 2025 at 02:25:51PM +0200, Michael Niedermayer wrote: > > > This fixes mixing up contexts, use of uninitialized data and crashes. > > > More specific

Re: [FFmpeg-devel] [PATCH] add yuv444p support to mcdeint

2025-06-14 Thread Michael Niedermayer
On Sun, Jun 08, 2025 at 01:07:37AM -0500, Ethan Halsall wrote: > Hi Michael, > > On 6/7/25 6:25 PM, Michael Niedermayer wrote: > > Hi Ethan > > > > On Sat, Jun 07, 2025 at 12:15:06PM -0500, Ethan Halsall wrote: > >> Hi Michael, > > [...] > >> @@ -201,8 +203,14 @@ static int filter_frame(AVFilterL

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mpegts: update stream info when PMT ES stream_type changes"

2025-06-14 Thread Michael Niedermayer
On Sat, Jun 14, 2025 at 01:15:24PM -0600, Pavel Koshevoy wrote: > On Fri, Jun 13, 2025 at 3:48 PM Pavel Koshevoy wrote: > > > > > > > On Fri, Jun 13, 2025 at 2:46 PM Michael Niedermayer < > > [email protected]> wrote: > > > >> > >> > > > > >> Pavel, are you ok with this being reverted or d

Re: [FFmpeg-devel] [PATCH v2 4/6] avformat/segment: Don't allow negative segment duration

2025-06-14 Thread Michael Niedermayer
On Sat, Jun 14, 2025 at 12:59:10AM +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > libavformat/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

[FFmpeg-devel] [PATCH] avformat/mpegts: Add -reprobe_stream_if_pmt_es_stream_type_changes option

2025-06-14 Thread Pavel Koshevoy
Make runtime AVStream.codecpar codec_id updates optional and disabled by default, so that avformat API clients can enable this feature explicitly when they add support for runtime codec changes. --- libavformat/mpegts.c | 8 +++- tests/fate/demux.mak | 2 +- 2 files changed, 8 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mpegts: update stream info when PMT ES stream_type changes"

2025-06-14 Thread Pavel Koshevoy
On Fri, Jun 13, 2025 at 3:48 PM Pavel Koshevoy wrote: > > > On Fri, Jun 13, 2025 at 2:46 PM Michael Niedermayer < > [email protected]> wrote: > >> >> > >> Pavel, are you ok with this being reverted or do you want to submit a >> patch that puts this behind some runtime flag ? >> > > I'd pre

Re: [FFmpeg-devel] [PATCH v2] avformat/http: Add max_request_size option

2025-06-14 Thread Marth64
Hello, bringing this back from the grave. Nicolas Frattaroli: > if I'll change it to anything then maybe max_requested_size, but > max_range_size seems less clear to me because that it does this through > the range header is not relevant to the user, its effect is, which is > that FFmpeg requests

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: fix seeking on multi-angle discs

2025-06-14 Thread Marth64
I apologize that I did not apply this sooner, around that time I had to detach due to some personal priorities. Will rebranch, retest, and apply in the next few days. ___ ffmpeg-devel mailing list [email protected] https://ffmpeg.org/mailman/listinf

Re: [FFmpeg-devel] [PATCH 4/4] Revert "fftools/resources: Add resource manager files with build-time compression"

2025-06-14 Thread Marton Balint
On Sat, 14 Jun 2025, Kacper Michajlow wrote: On Sat, 17 May 2025 at 01:11, Marton Balint wrote: This reverts commit 517a8055655798970d94a4c5ea912511362520ea. Building resources directly in the ffmpeg util needs quite a bit of code, increases binary size and makes it harder for the users t

Re: [FFmpeg-devel] [PATCH 05/10] doc/muxers: Add documentation for segment_limit option

2025-06-14 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz . wrote: [...] (Please note, that the default is 0, which means that nothing is dropped and there's no change in behavior when it's 0). Probably it's best to look at an example. Let's say we have: - a 300s video - that we want to stream via HLS - Segment-Dura

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Fix path handling for Windows

2025-06-14 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of Marton Balint Sent: Freitag, 13. Juni 2025 23:36 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Fix path handling for Windows On

Re: [FFmpeg-devel] [PATCH 4/4] Revert "fftools/resources: Add resource manager files with build-time compression"

2025-06-14 Thread Kacper Michajlow
On Sat, 17 May 2025 at 01:11, Marton Balint wrote: > > This reverts commit 517a8055655798970d94a4c5ea912511362520ea. > > Building resources directly in the ffmpeg util needs quite a bit of code, > increases binary size and makes it harder for the users to change those > resources at will. > > The

Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-06-14 Thread Romain Beauxis
Le jeu. 12 juin 2025 à 13:35, Michael Niedermayer a écrit : > > Hi Romain Hi, > On Tue, Jun 10, 2025 at 01:04:35PM -0500, Romain Beauxis wrote: > > Hi all, > > > > > > Le mer. 4 juin 2025 à 11:58, Romain Beauxis a écrit : > > > > > > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 us

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: fix rmtp packet leak in gen_connect()

2025-06-14 Thread Zhao Zhili
> On Jun 14, 2025, at 16:33, Lidong Yan > wrote: > > In libavformat/rtmpproto.c:gen_connect(), if check on string length > or check on codec fourcc failed, ff_rtmp_packet_create() allocated > data in pkt would leak. Add ff_rtmp_packet_destory before return error > code. > > Signed-off-by: Li

[FFmpeg-devel] [PATCH] avformat/rtmpproto: fix rmtp packet leak in gen_connect()

2025-06-14 Thread Lidong Yan
In libavformat/rtmpproto.c:gen_connect(), if check on string length or check on codec fourcc failed, ff_rtmp_packet_create() allocated data in pkt would leak. Add ff_rtmp_packet_destory before return error code. Signed-off-by: Lidong Yan <[email protected]> -BEGIN PGP PUBLIC KEY B