[FFmpeg-devel] [PATCH v4] fate/vvc: Add a sample which lose frames before 5c66a3

2024-09-17 Thread Zhao Zhili
From: Zhao Zhili --- sample: 8054b4b8e62c0171476b40206d044590 Hierarchical.bit https://drive.google.com/file/d/1U5WGWeSsMFiEkhsl_vL4NiMma-LLh02t/view?usp=sharing Put Hierarchical.bit under $(TARGET_SAMPLES)/vvc tests/fate/vvc.mak| 3 ++- tests/ref/fate/vvc-output-ref | 35 +++

[FFmpeg-devel] [PATCH] avcodec/h2645_parse: add a flag to store skipped byte positions

2024-09-17 Thread James Almer
This is only used by two out of several modules, so it's a waste of resources for the rest. Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 6 -- libavcodec/h2645_parse.c | 10 ++ libavcodec/h2645_parse.h | 1 + libavcodec/hevc/hevcdec.c | 2 +- 4 files changed, 12 in

Re: [FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

2024-09-17 Thread Michael Niedermayer
On Sun, Sep 15, 2024 at 09:09:39PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-09-13 19:48:46) [...] > > > > > > > +#include "libavcodec/internal.h" > > > > > > I dislike this as well. > > > > I am fine with it. > > > > But if you dont, then maybe you can suggest another way

Re: [FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

2024-09-17 Thread Michael Niedermayer
On Mon, Sep 16, 2024 at 11:30:34AM -0300, James Almer wrote: > On 9/13/2024 2:48 PM, Michael Niedermayer wrote: > > On Fri, Sep 13, 2024 at 12:08:45PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-09-13 01:33:31) > > > > We do not support more channels. For example avcodec_ope

Re: [FFmpeg-devel] [PATCH 16/23] avcodec/hevc/refs: export Stereo 3D side data

2024-09-17 Thread James Almer
On 9/17/2024 8:53 AM, Anton Khirnov wrote: Quoting James Almer (2024-09-15 00:12:52) (is there a reason you wanted the view_id side data and this one applied to the frame before get_buffer()?), So that the caller knows what view is get_buffer() called for. As this is now being called before

Re: [FFmpeg-devel] [PATCH v3] avcodec/h264: ignore POC when flag is set

2024-09-17 Thread Kevin Wang
I have a file that repro's the issue along with a description of what's going on in the file: https://trac.ffmpeg.org/ticket/11190 I can try dumping that into the `fate` samples? I don't see any corrupted file samples in there though so I'm happy to follow whatever guidance you can provide. On Tu

Re: [FFmpeg-devel] [PATCH] ffmpeg_mux_init: correct log suggestion

2024-09-17 Thread Anton Khirnov
Quoting Gyan Doshi (2024-09-17 13:15:45) > The option is enc_time_base, not enc_timebase > --- > fftools/ffmpeg_mux_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c > index 30d74d37bd..571c9808b9 100644 > --- a/f

Re: [FFmpeg-devel] [PATCH v3] avcodec/h264: ignore POC when flag is set

2024-09-17 Thread Anton Khirnov
Quoting Kevin Wang (2024-09-16 06:26:34) > When the flag AV_CODEC_FLAG_OUTPUT_CORRUPT or AV_CODEC_FLAG2_SHOW_ALL > is set, ignore any out of order POC's as they may still be valid > frames. > --- > Reformat with more lines so the patch is better. > > libavcodec/h264_slice.c | 5 - > 1 file ch

[FFmpeg-devel] [PATCH 5/5] checkasm: Print the SVE vector length at startup

2024-09-17 Thread Martin Storsjö
--- tests/checkasm/checkasm.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index c932e028a5..c9d2b5faf1 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -94,6 +94,10 @@ #define isatt

[FFmpeg-devel] [PATCH 4/5] aarch64: Print the SVE vector length in libavutil/tests/cpu.c

2024-09-17 Thread Martin Storsjö
This makes this aspect more visible in test logs. --- libavutil/aarch64/Makefile | 2 ++ libavutil/aarch64/cpu.h | 4 libavutil/aarch64/cpu_sve.S | 29 + libavutil/tests/cpu.c | 8 4 files changed, 43 insertions(+) create mode 100644 libavut

[FFmpeg-devel] [PATCH 3/5] aarch64: Add CPU feature flags for SVE and SVE2

2024-09-17 Thread Martin Storsjö
Add code for detecting the feature on Linux and Windows. --- libavutil/aarch64/cpu.c | 20 libavutil/aarch64/cpu.h | 2 ++ libavutil/cpu.c | 2 ++ libavutil/cpu.h | 2 ++ libavutil/tests/cpu.c | 2 ++ tests/checkasm/checkasm.c | 2 ++ 6 files c

[FFmpeg-devel] [PATCH 2/5] configure: Add detection of assembler support for SVE/SVE2

2024-09-17 Thread Martin Storsjö
It turns out that recent versions of MS armasm64 does support some SVE instructions, but not all of them. Test for one of the instructions that it currently doesn't support. --- Just as disclaimer, I'm not currently actively planning on writing SVE/SVE2 optimizations. However, related projects su

[FFmpeg-devel] [PATCH 1/5] aarch64: Detect I8MM on Windows via SVE-I8MM

2024-09-17 Thread Martin Storsjö
There's no direct processor feature constant for I8MM alone, but there is a flag for SVE-I8MM (added in WinSDK 10.0.26100 and recent versions of mingw-w64). If SVE-I8MM is available, we can assume that I8MM is available. While HW supporting these features isn't yet commonly running Windows, this a

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-09-17 Thread Niklas Haas
On Mon, 08 Jul 2024 09:25:08 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Mon, Jul 8, 2024 at 8:34 AM Andrew Sayers > wrote: > > > We often say e.g. "this struct currently has such-and-such members, but the > > size is not part of the public API". So it's not much of a stretch to say > > "this

Re: [FFmpeg-devel] [PATCH 16/23] avcodec/hevc/refs: export Stereo 3D side data

2024-09-17 Thread Anton Khirnov
Quoting James Almer (2024-09-15 00:12:52) > (is there a reason you wanted the view_id side data and this one > applied to the frame before get_buffer()?), So that the caller knows what view is get_buffer() called for. > As this is now being called before ff_progress_frame_get_buffer() it > became

[FFmpeg-devel] [PATCH] ffmpeg_mux_init: correct log suggestion

2024-09-17 Thread Gyan Doshi
The option is enc_time_base, not enc_timebase --- fftools/ffmpeg_mux_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index 30d74d37bd..571c9808b9 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c